Skip to content

Adding Oracle Database Vector Store Connector #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 85 commits into from
Aug 27, 2025
Merged

Adding Oracle Database Vector Store Connector #327

merged 85 commits into from
Aug 27, 2025

Conversation

psilberk
Copy link
Contributor

@psilberk psilberk commented Jul 8, 2025

Motivation and Context

Addressing #321

  1. Why is this change required?: adding Oracle implementation.
  2. What problem does it solve?: NA
  3. What scenario does it contribute to?: NA
  4. If it fixes an open issue, please link to the issue here.

Description

We added the Oracle implementation. Following the similar approach of other vendors.

Contribution Checklist

psilberk and others added 30 commits April 22, 2025 09:33
@psilberk
Adding Oracle Vector Store
bc2c366
@psilberk
Upsert and Main sample
ba1aa96
@fmeheust
Split out the data into its own module
7d476fc
@fmeheust
Removed dependencies
bf0c167
@psilberk
Merge branch 'microsoft:main' into main
9a7c650
@psilberk
Merge pull request #1 from fmeheust/split-data-module
a643fe2 
Split data module
@fmeheust
Added oracle store
376d8d2
@fmeheust
Added Oracle store
458ace8
@psilberk
Added reference to parent's pom in sqlite
8bef1ff
@fmeheust
Any tag filter
a514b28
@psilberk
Clean pom and 1st Sample
d8b6895
@psilberk
Merge branch 'main' into pom_and_demos1
e3ea6a2
@psilberk
Merge pull request #2 from psilberk/pom_and_demos1
e5e4ae3 
Pom and demos1
@psilberk
Sample wip #2
df07b40
@psilberk
Merge pull request #3 from psilberk/pom_and_demos1
f0099cf 
Sample wip #2
@norah-li
Add test for IndexKind.UNDEFINED and IndexKind.HNSW
805f5fa
@psilberk
Remove old implementation
1ca9439
@psilberk
Merge pull request #4 from psilberk/pom_and_demos1
92339ab 
Remove old implementation
@fmeheust
Added constants for type mapping and matched ODP type mapping when po…
c3bfafb 
…ssible.
@psilberk
Adding Book class and pom fixes
bc0f640
@fmeheust
Missing getter methods and wrong null check
3cbee72
@norah-li
Merge remote-tracking branch 'origin/add-oracle-store' into add-oracl…
03456d1 
…e-store-tests
@norah-li
add test for key type
c3db036
@norah-li
enable test for COSINE_DISTANCE, COSINE_SIMILARITY, DOT_PRODUCT in Ho…
2306e21 
…tel.java
@fmeheust
Refactoring
0bf9199
@norah-li
Add test for supported data type(timestamp and uuid not included)
434b9e6
@fmeheust
Merge remote-tracking branch 'origin/add-oracle-store-tests' into add…
89bc5ea 
…-oracle-store
@fmeheust
Test and bug fixes
1c83d62
@fmeheust
BigDecimal mapping and value range
a6fac68
@fmeheust @psilberk
Any tag filter
2f421a8
@karianna
Copy link
Member

Still seeing failures. I recommend running the same ./mvnw command as is listed in the GH Action locally:

Error: Medium: A prepared statement is generated from a nonconstant String in com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreQueryProvider.search(String, List, VectorSearchOptions, VectorStoreRecordDefinition, VectorStoreRecordMapper) [com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreQueryProvider] At OracleVectorStoreQueryProvider.java:[line 470] SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING
Error: Medium: A prepared statement is generated from a nonconstant String in com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreQueryProvider.upsertRecords(String, List, VectorStoreRecordDefinition, UpsertRecordOptions) [com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreQueryProvider] At OracleVectorStoreQueryProvider.java:[line 295] SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING
Error: Medium: com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreQueryProvider$Builder.withObjectMapper(ObjectMapper) may expose internal representation by storing an externally mutable object into OracleVectorStoreQueryProvider$Builder.objectMapper [com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreQueryProvider$Builder] At OracleVectorStoreQueryProvider.java:[line 830] EI_EXPOSE_REP2
Error: Medium: com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreRecordMapper$Builder.withAnnotatedTypeMapping(Map) may expose internal representation by storing an externally mutable object into OracleVectorStoreRecordMapper$Builder.annotatedTypeMapping [com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreRecordMapper$Builder] At OracleVectorStoreRecordMapper.java:[line 145] EI_EXPOSE_REP2
Error: Medium: com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreRecordMapper$Builder.withSupportedDataTypesMapping(Map) may expose internal representation by storing an externally mutable object into OracleVectorStoreRecordMapper$Builder.supportedDataTypesMapping [com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreRecordMapper$Builder] At OracleVectorStoreRecordMapper.java:[line 140] EI_EXPOSE_REP2
Error: Medium: Unread field: com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreRecordMapper$Builder.annotatedTypeMapping [com.microsoft.semantickernel.data.jdbc.oracle.OracleVectorStoreRecordMapper$Builder] At OracleVectorStoreRecordMapper.java:[line 145] URF_UNREAD_FIELD

@psilberk
Copy link
Contributor Author

Hi @karianna @johnoliver if you can please take a look we'd appreciate. Thanks

@karianna
Copy link
Member

Error: Failures:
Error: OracleVectorStoreRecordCollectionTest.exactSearch:221 expected: <30.3399> but was: <30.34000015258789>
Error: OracleVectorStoreRecordCollectionTest.searchWithFilter:261 expected: <30.34000015258789> but was: <30.3399>

johnoliver
johnoliver reviewed Aug 18, 2025
View reviewed changes
johnoliver
johnoliver reviewed Aug 18, 2025
View reviewed changes
johnoliver
johnoliver reviewed Aug 18, 2025
View reviewed changes
fmeheust and others added 8 commits August 18, 2025 15:01
@fmeheust @johnoliver
Update samples/semantickernel-concepts/semantickernel-syntax-examples…
24490cc 
…/pom.xml

Co-authored-by: John Oliver <[email protected]>
@fmeheust @johnoliver
Update samples/semantickernel-learn-resources/pom.xml
b854f9b 
Co-authored-by: John Oliver <[email protected]>
@fmeheust @johnoliver
Update samples/semantickernel-learn-resources/pom.xml
ba45bb3 
Co-authored-by: John Oliver <[email protected]>
@fmeheust @johnoliver
Update samples/semantickernel-learn-resources/pom.xml
735587b 
Co-authored-by: John Oliver <[email protected]>
@fmeheust @johnoliver
Update samples/semantickernel-concepts/semantickernel-syntax-examples…
f0c9615 
…/pom.xml

Co-authored-by: John Oliver <[email protected]>
@fmeheust
Fix: Run Java Integration Tests and Samples
4d61f13
@fmeheust
Added oracle store to BOM
f78b2ab 
* integration tests

* Added oracle module to BOM
@fmeheust
Disable spotless plugin (#15)
ced785b 
* integration tests

* Added oracle module to BOM

* Disable spotless for oracle store and result of spotless apply
@karianna karianna requested a review from johnoliver August 19, 2025 01:52
@johnoliver johnoliver merged commit 6dad4b7 into microsoft:main Aug 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnoliver johnoliver johnoliver approved these changes

+2 more reviewers

@jeandelavarene jeandelavarene jeandelavarene left review comments

@fmeheust fmeheust fmeheust left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@psilberk @karianna @johnoliver @jeandelavarene @fmeheust @norah-li