Skip to content

Commit de7470c

Browse files
.Net: Making Gemini MaxTokens Optional when not provided (#12539)
### Motivation and Context - Fixes #12334 --------- Co-authored-by: Mark Wallace <[email protected]>
1 parent 76f7da9 commit de7470c

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

dotnet/src/Connectors/Connectors.Google.UnitTests/GeminiPromptExecutionSettingsTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public void ItCreatesGeminiExecutionSettingsWithCorrectDefaults()
2929
Assert.Null(executionSettings.AudioTimestamp);
3030
Assert.Null(executionSettings.ResponseMimeType);
3131
Assert.Null(executionSettings.ResponseSchema);
32-
Assert.Equal(GeminiPromptExecutionSettings.DefaultTextMaxTokens, executionSettings.MaxTokens);
32+
Assert.Null(executionSettings.MaxTokens);
3333
}
3434

3535
[Fact]

dotnet/src/Connectors/Connectors.Google/GeminiPromptExecutionSettings.cs

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,6 @@ public sealed class GeminiPromptExecutionSettings : PromptExecutionSettings
3333
private GeminiToolCallBehavior? _toolCallBehavior;
3434
private GeminiThinkingConfig? _thinkingConfig;
3535

36-
/// <summary>
37-
/// Default max tokens for a text generation.
38-
/// </summary>
39-
public static int DefaultTextMaxTokens { get; } = 256;
40-
4136
/// <summary>
4237
/// Temperature controls the randomness of the completion.
4338
/// The higher the temperature, the more random the completion.
@@ -358,7 +353,7 @@ public static GeminiPromptExecutionSettings FromExecutionSettings(PromptExecutio
358353
switch (executionSettings)
359354
{
360355
case null:
361-
return new GeminiPromptExecutionSettings() { MaxTokens = DefaultTextMaxTokens };
356+
return new GeminiPromptExecutionSettings();
362357
case GeminiPromptExecutionSettings settings:
363358
return settings;
364359
}

0 commit comments

Comments
 (0)