Skip to content

Commit 4b78811

Browse files
Merge pull request #208 from JocaPC/master
Added logging in json/nodejs/todo app
2 parents 596cec3 + ec65352 commit 4b78811

File tree

1 file changed

+23
-14
lines changed
  • samples/features/json/todo-app/nodejs-express4-rest-api

1 file changed

+23
-14
lines changed

samples/features/json/todo-app/nodejs-express4-rest-api/db.js

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -19,28 +19,29 @@ function createRequest(query, connection) {
1919
var req =
2020
new Request(query,
2121
function (err, rowCount) {
22-
if (err) {
23-
throw err;
24-
}
25-
connection && connection.close();
22+
if (err) {
23+
console.trace(err);
24+
throw err;
25+
}
26+
connection && connection.close();
27+
console.log('Connection closed');
2628
});
27-
2829
return req;
2930
}
3031

3132
function stream (query, connection, output, defaultContent) {
3233

3334
var request = query;
3435
if (typeof query == "string") {
35-
request = this.createRequest(query, connection);
36+
request = createRequest(query, connection);
3637
}
37-
pipe(request, output, defaultContent);
38-
}
3938

40-
function pipe (request, output, defaultContent) {
4139
var empty = true;
4240
request.on('row', function (columns) {
43-
empty = false;
41+
if(empty) {
42+
console.log('Response fetched from SQL Database!');
43+
empty = false;
44+
}
4445
output.write(columns[0].value);
4546
});
4647

@@ -50,19 +51,28 @@ function pipe (request, output, defaultContent) {
5051

5152
request.on('doneProc', function (rowCount, more, rows) {
5253
_OnDone(empty, defaultContent, output);
53-
});
54+
});
55+
56+
executeRequest (request, connection);
5457
}
5558

5659
function _OnDone(empty, defaultContent, output) {
5760
if(empty) {
5861
output.write(defaultContent);
62+
console.log('No results from database - default content is returned.');
5963
}
60-
try { output.end(); } catch (err) { /* Ignore stream close error. */ }
64+
try {
65+
console.log('Closing Http Response output.');
66+
output.end();
67+
} catch (err) {
68+
console.error(err);
69+
}
6170
}
6271

6372
function executeRequest (request, connection) {
6473
connection.on('connect', function (err) {
6574
if (err) {
75+
console.trace(err);
6676
throw err;
6777
}
6878
connection.execSql(request);
@@ -72,5 +82,4 @@ function executeRequest (request, connection) {
7282
module.exports.createConnection = createConnection;
7383
module.exports.createRequest = createRequest;
7484
module.exports.executeRequest = executeRequest;
75-
module.exports.stream = stream;
76-
module.exports.pipe = pipe;
85+
module.exports.stream = stream;

0 commit comments

Comments
 (0)