add params

Author: cloudmelon

samples/features/sql-big-data-cluster/deployment/README.md

@@ -17,5 +17,5 @@ Using the sample Python script in **offline** folder, you will push the necessar
 
 ## __[Deploy SQL Server big data clusters (BDC) with Azure Kubernetes service (AKS) private cluster](private-aks/)__
 
-Using the sample Python script in **private-aks** folder, you will Deploy SQL Server big data cluster in private mode with Azure Kubernetes service (AKS) private cluster.
+Using the sample Python script in **private-aks** folder, you will Deploy SQL Server big data cluster in in your private network with Azure Kubernetes service (AKS) private cluster.
 

samples/features/sql-big-data-cluster/deployment/private-aks/README.md

@@ -12,21 +12,9 @@ This repository contains 3 bash scripts :
 
 You can run those scripts on the following client envionrment with Linux OS or WSL/WSL2.
 
-The following table lists common big data cluster tools and how to install them:
-
-| Tool | Required | Description | Installation |
-|---|---|---|---|
-| `python` | Yes | Python is an interpreted, object-oriented, high-level programming language with dynamic semantics. Many parts of big data clusters for SQL Server use python. | [Install python](#python)|
-| `azdata` | Yes | Command-line tool for installing and managing a big data cluster. | [Install](deploy-install-azdata.md) |
-| `kubectl`<sup>1</sup> | Yes | Command-line tool for monitoring the underlying Kubernetes cluster ([More info](https://kubernetes.io/docs/tasks/tools/install-kubectl/)). | [Windows](https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-with-powershell-from-psgallery) \| [Linux](https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-using-native-package-management) |
-| **Azure Data Studio** | Yes | Cross-platform graphical tool for querying SQL Server. | [Install](https://aka.ms/getazuredatastudio) |
-| **Data Virtualization extension** | Yes | Extension for Azure Data Studio that provides a Data Virtualization wizard. | [Install](../azure-data-studio/data-virtualization-extension.md) |
-| **Azure CLI**<sup>2</sup> | For AKS | Modern command-line interface for managing Azure services. Used with AKS big data cluster deployments ([More info](https://docs.microsoft.com/cli/azure/?view=azure-cli-latest)). | [Install](https://docs.microsoft.com/cli/azure/install-azure-cli?view=azure-cli-latest) |
-| **mssql-cli** | Optional | Modern command-line interface for querying SQL Server ([More info](../tools/mssql-cli.md)). | [Windows](https://github.com/dbcli/mssql-cli/blob/master/doc/installation/windows.md) \| [Linux](https://github.com/dbcli/mssql-cli/blob/master/doc/installation/linux.md) |
-| **sqlcmd** | For some scripts | Legacy command-line tool for querying SQL Server ([More info](https://docs.microsoft.com/sql/tools/sqlcmd-utility?view=sql-server-ver15)). You might need to install the Microsoft ODBC Driver 11 for SQL Server before installing the SQLCMD package. | [Windows](https://www.microsoft.com/download/details.aspx?id=36433) \| [Linux](../linux/sql-server-linux-setup-tools.md) |
-| `curl` <sup>3</sup> | For some scripts | Command-line tool for transferring data with URLs. | [Windows](https://curl.haxx.se/windows/) \| Linux: install curl package |
-| `oc` | Required for Red Hat OpenShift and Azure Redhat OpenShift deployments. |`oc` is the Open Shift command line interface (CLI). | [Installing the CLI](https://docs.openshift.com/container-platform/4.4/cli_reference/openshift_cli/getting-started-cli.html#installing-the-cli)
+The following table link listed common big data cluster tools and how to install them:
 
+https://docs.microsoft.com/en-us/sql/big-data-cluster/deploy-big-data-tools?view=sql-server-ver15
 
 
 ## Instructions

samples/features/sql-big-data-cluster/deployment/private-aks/scripts/deploy-private-aks-udr.sh

@@ -4,14 +4,13 @@
 while true; do
     read -s -p "Your Azure Subscription: " subscription
     echo
-    read -s -p "Your service principles ID: " sp_id
-    echo
-    read -s -p "Your service principles Password: " sp_pwd
-    echo
     read -s -p "Your Resource Group Name: " resourcegroup
     echo
     read -s -p "In which region you're deploying " region
-
+    echo
+    read -s -p "Your service principles ID: " sp_id
+    echo
+    read -s -p "Your service principles Password: " sp_pwd
 done
 
 #Define a set of environment variables to be used in resource creations.

samples/features/sql-big-data-cluster/deployment/private-aks/scripts/deploy-private-aks.sh

@@ -1,12 +1,30 @@
 #!/bin/bash
 #Define a set of environment variables to be used in resource creations.
 #
-export REGION_NAME=northeurope
-export RESOURCE_GROUP=private-bdc-aks-rg
+
+#!/bin/bash
+#Get Subscription ID and service principles as input. It is used as default for controller, SQL Server Master instance (sa account) and Knox.
+#
+while true; do
+    read -s -p "Your Azure Subscription: " subscription
+    echo
+    read -s -p "Your Resource Group Name: " resourcegroup
+    echo
+    read -s -p "In which region you're deploying " region
+    echo
+done
+
+#Define a set of environment variables to be used in resource creations.
+export SUBID=$subscription
+
+export REGION_NAME=$region
+export RESOURCE_GROUP=$resourcegroup
 export SUBNET_NAME=aks-subnet
 export VNET_NAME=bdc-vnet
 export AKS_NAME=bdcaksprivatecluster
 
+#Set Azure subscription current in use
+az account set --subscription $subscription
 
 #Create Azure Resource Group
 az group create -n $RESOURCE_GROUP -l $REGION_NAME