Skip to content

Commit e01914f

Browse files
authored
Fix incorrectly uploaded RetroKNN weights (#91)
As noticed by @panpiort8, the default USPTO50K-trained RetroKNN weights did not reproduce the USPTO50K accuracy reported in our paper, only getting to ~50% instead of ~55%. It turns out that the weights got mixed up when uploading from our internal storage to figshare. In short, the RetroKNN weights consist of LocalRetro weights and an activation store for retrieval, but the store present in the checkpoint was generated using a _different_ checkpoint of LocalRetro than the one it was uploaded with. After fixing this, the accuracy is back to its expected ~55% range.
1 parent e7097bf commit e01914f

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ and the project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.
77

88
## [Unreleased]
99

10+
### Fixed
11+
12+
- Fix incorrectly uploaded RetroKNN weights ([#91](https://github.com/microsoft/syntheseus/pull/91)) ([@kmaziarz])
13+
1014
## [0.4.0] - 2024-04-10
1115

1216
### Changed

docs/single_step.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ See table below for the links to the default checkpoints.
1313
| [LocalRetro](https://figshare.com/ndownloader/files/42287319) | trained by us |
1414
| [MEGAN](https://figshare.com/ndownloader/files/42012732) | trained by us |
1515
| [MHNreact](https://figshare.com/ndownloader/files/42012777) | trained by us |
16-
| [RetroKNN](https://figshare.com/ndownloader/files/43636584) | trained by us |
16+
| [RetroKNN](https://figshare.com/ndownloader/files/45662430) | trained by us |
1717
| [RootAligned](https://figshare.com/ndownloader/files/42012792) | released by authors |
1818

1919
??? note "More advanced datasets"

syntheseus/reaction_prediction/inference/default_checkpoint_links.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ backward:
55
LocalRetro: https://figshare.com/ndownloader/files/42287319
66
MEGAN: https://figshare.com/ndownloader/files/42012732
77
MHNreact: https://figshare.com/ndownloader/files/42012777
8-
RetroKNN: https://figshare.com/ndownloader/files/43636584
8+
RetroKNN: https://figshare.com/ndownloader/files/45662430
99
RootAligned: https://figshare.com/ndownloader/files/42012792
1010
forward:
1111
Chemformer: https://figshare.com/ndownloader/files/42012708

0 commit comments

Comments
 (0)