Commit 2618cd7
Fix critical GUID parsing bugs to prevent crashes
Added proper error handling for invalid GUID inputs in:
1. focus-tab --session option parsing
2. new-tab --sessionId option parsing
Both now silently ignore invalid GUIDs instead of crashing, consistent
with how invalid tab colors are handled. Added test case for invalid GUID.
Co-authored-by: shanselman <2892+shanselman@users.noreply.github.com>1 parent e6c12c8 commit 2618cd7
File tree
2 files changed
+47
-15
lines changed- src/cascadia
- LocalTests_TerminalApp
- TerminalApp
2 files changed
+47
-15
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1180 | 1180 | | |
1181 | 1181 | | |
1182 | 1182 | | |
| 1183 | + | |
| 1184 | + | |
| 1185 | + | |
| 1186 | + | |
| 1187 | + | |
| 1188 | + | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
1183 | 1193 | | |
1184 | 1194 | | |
1185 | 1195 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
393 | 393 | | |
394 | 394 | | |
395 | 395 | | |
396 | | - | |
397 | | - | |
398 | 396 | | |
399 | 397 | | |
400 | 398 | | |
401 | 399 | | |
402 | 400 | | |
| 401 | + | |
403 | 402 | | |
404 | 403 | | |
405 | | - | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
406 | 413 | | |
407 | 414 | | |
408 | 415 | | |
409 | | - | |
| 416 | + | |
| 417 | + | |
410 | 418 | | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | | - | |
417 | | - | |
418 | | - | |
| 419 | + | |
| 420 | + | |
419 | 421 | | |
420 | | - | |
| 422 | + | |
| 423 | + | |
| 424 | + | |
| 425 | + | |
| 426 | + | |
| 427 | + | |
| 428 | + | |
| 429 | + | |
| 430 | + | |
| 431 | + | |
| 432 | + | |
| 433 | + | |
| 434 | + | |
421 | 435 | | |
422 | 436 | | |
423 | 437 | | |
| |||
736 | 750 | | |
737 | 751 | | |
738 | 752 | | |
739 | | - | |
740 | | - | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
741 | 763 | | |
742 | 764 | | |
743 | 765 | | |
| |||
0 commit comments