Skip to content

Commit 3ab2acc

Browse files
sagarbhure-msftSagar Bhure
andauthored
Fix Settings tab color mismatch with Settings page background (#19999)
## Summary The Settings tab color (`SettingsUiTabBrush`) was out of sync with the Settings page background (`SettingsPageBackground`), causing a visible mismatch - the tab appeared black while the page was dark gray. ## Changes Aligned `SettingsUiTabBrush` in `App.xaml` to match `SettingsPageBackground` from `MainPage.xaml`: ## Validation - Built and deployed locally as Windows Terminal Dev - Verified Settings tab and page backgrounds match in Dark and Light themes - No impact on other tab colors or theming Closes #19873 Co-authored-by: Sagar Bhure <sagarbhure@microsoft.com>
1 parent eea035c commit 3ab2acc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/cascadia/TerminalApp/App.xaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@
192192
ResourceKey="TabViewBackground" />
193193

194194
<SolidColorBrush x:Key="SettingsUiTabBrush"
195-
Color="#0c0c0c" />
195+
Color="#282828" />
196196

197197
<SolidColorBrush x:Key="BroadcastPaneBorderColor"
198198
Color="{StaticResource SystemAccentColorDark2}" />
@@ -211,7 +211,7 @@
211211
ResourceKey="TabViewBackground" />
212212

213213
<SolidColorBrush x:Key="SettingsUiTabBrush"
214-
Color="#ffffff" />
214+
Color="#F9F9F9" />
215215

216216
<SolidColorBrush x:Key="BroadcastPaneBorderColor"
217217
Color="{StaticResource SystemAccentColorLight2}" />
@@ -234,7 +234,7 @@
234234
ResourceKey="SystemColorButtonFaceColorBrush" />
235235

236236
<StaticResource x:Key="SettingsUiTabBrush"
237-
ResourceKey="SystemControlBackgroundBaseLowBrush" />
237+
ResourceKey="SystemColorWindowBrush" />
238238

239239
<SolidColorBrush x:Key="BroadcastPaneBorderColor"
240240
Color="{StaticResource SystemColorHighlightColor}" />

0 commit comments

Comments
 (0)