split size template

Author: PankajBhojwani

src/cascadia/TerminalSettingsEditor/ActionsViewModel.idl

@@ -16,6 +16,7 @@ namespace Microsoft.Terminal.Settings.Editor
         Windows.UI.Xaml.DataTemplate UInt32Template;
         Windows.UI.Xaml.DataTemplate UInt32OptionalTemplate;
         Windows.UI.Xaml.DataTemplate FloatTemplate;
+        Windows.UI.Xaml.DataTemplate SplitSizeTemplate;
         Windows.UI.Xaml.DataTemplate StringTemplate;
         Windows.UI.Xaml.DataTemplate ColorSchemeTemplate;
         Windows.UI.Xaml.DataTemplate FilePickerTemplate;

src/cascadia/TerminalSettingsEditor/ArgsTemplateSelectors.cpp

@@ -24,7 +24,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
             lut[] = {
                 { L"int32_t", &ArgsTemplateSelectors::Int32Template },
                 { L"uint32_t", &ArgsTemplateSelectors::UInt32Template },
-                { L"float", &ArgsTemplateSelectors::FloatTemplate },
                 { L"bool", &ArgsTemplateSelectors::BoolTemplate },
                 { L"Windows::Foundation::IReference<bool>", &ArgsTemplateSelectors::BoolOptionalTemplate },
                 { L"Windows::Foundation::IReference<int32_t>", &ArgsTemplateSelectors::Int32OptionalTemplate },
@@ -69,6 +68,17 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
                     return StringTemplate();
                 }
             }
+            else if (argType == L"float")
+            {
+                const auto argTag = argWrapper.TypeHint();
+                switch (argTag)
+                {
+                case Model::ArgTypeHint::SplitSize:
+                    return SplitSizeTemplate();
+                default:
+                    return FloatTemplate();
+                }
+            }
 
             for (const auto& [type, member] : lut)
             {

src/cascadia/TerminalSettingsEditor/ArgsTemplateSelectors.h

@@ -18,6 +18,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         til::property<winrt::Windows::UI::Xaml::DataTemplate> UInt32Template;
         til::property<winrt::Windows::UI::Xaml::DataTemplate> UInt32OptionalTemplate;
         til::property<winrt::Windows::UI::Xaml::DataTemplate> FloatTemplate;
+        til::property<winrt::Windows::UI::Xaml::DataTemplate> SplitSizeTemplate;
         til::property<winrt::Windows::UI::Xaml::DataTemplate> StringTemplate;
         til::property<winrt::Windows::UI::Xaml::DataTemplate> ColorSchemeTemplate;
         til::property<winrt::Windows::UI::Xaml::DataTemplate> FilePickerTemplate;

src/cascadia/TerminalSettingsEditor/EditAction.xaml

@@ -356,6 +356,30 @@
                 </Grid>
             </DataTemplate>
 
+            <!--  Example shortcut action to test this template: Split Pane  -->
+            <DataTemplate x:Key="SplitSizeTemplate"
+                          x:DataType="local:ArgWrapper">
+                <Grid Margin="0,4,0,4"
+                      ColumnSpacing="8">
+                    <Grid.ColumnDefinitions>
+                        <ColumnDefinition Width="{StaticResource ArgumentNameWidth}" />
+                        <ColumnDefinition Width="Auto" />
+                    </Grid.ColumnDefinitions>
+                    <TextBlock Grid.Column="0"
+                               VerticalAlignment="Center"
+                               Text="{x:Bind Name}"
+                               TextWrapping="WrapWholeWords" />
+                    <muxc:NumberBox Grid.Column="1"
+                                    AutomationProperties.Name="{x:Bind Name}"
+                                    LargeChange="0.2"
+                                    Maximum="1"
+                                    Minimum="0"
+                                    SmallChange="0.1"
+                                    Style="{StaticResource NumberBoxSettingStyle}"
+                                    Value="{x:Bind UnboxFloat(Value), Mode=TwoWay, BindBack=FloatBindBack}" />
+                </Grid>
+            </DataTemplate>
+
             <!--  Example shortcut action to test this template: Send Input  -->
             <DataTemplate x:Key="StringTemplate"
                           x:DataType="local:ArgWrapper">
@@ -610,6 +634,7 @@
                                          FolderPickerTemplate="{StaticResource FolderPickerTemplate}"
                                          Int32OptionalTemplate="{StaticResource Int32OptionalTemplate}"
                                          Int32Template="{StaticResource Int32Template}"
+                                         SplitSizeTemplate="{StaticResource SplitSizeTemplate}"
                                          StringTemplate="{StaticResource StringTemplate}"
                                          TerminalCoreColorOptionalTemplate="{StaticResource TerminalCoreColorOptionalTemplate}"
                                          UInt32OptionalTemplate="{StaticResource UInt32OptionalTemplate}"

src/cascadia/TerminalSettingsModel/ActionArgs.h

@@ -307,7 +307,7 @@ protected:                                                                  \
 #define SPLIT_PANE_ARGS(X)                                                                                 \
     X(Model::SplitDirection, SplitDirection, "split", false, ArgTypeHint::None, SplitDirection::Automatic) \
     X(SplitType, SplitMode, "splitMode", false, ArgTypeHint::None, SplitType::Manual)                      \
-    X(float, SplitSize, "size", false, ArgTypeHint::None, 0.5f)
+    X(float, SplitSize, "size", false, ArgTypeHint::SplitSize, 0.5f)
 
 ////////////////////////////////////////////////////////////////////////////////
 

src/cascadia/TerminalSettingsModel/ActionArgs.idl

@@ -10,7 +10,8 @@ namespace Microsoft.Terminal.Settings.Model
         None = 0,
         FilePath,
         FolderPath,
-        ColorScheme
+        ColorScheme,
+        SplitSize
     };
 
     struct ArgDescriptor