DesktopNotification -> UrxvtAction; add _api.UnknownSequence() call

Author: carlos-zamora

src/terminal/adapter/ITermDispatch.hpp

@@ -166,7 +166,7 @@ class Microsoft::Console::VirtualTerminal::ITermDispatch
 
     virtual void DoWTAction(const std::wstring_view string) = 0;
 
-    virtual void DoDesktopNotification(const std::wstring_view string) = 0;
+    virtual void DoUrxvtAction(const std::wstring_view string) = 0;
 
     virtual StringHandler DefineSixelImage(const VTInt macroParameter,
                                            const DispatchTypes::SixelBackground backgroundSelect,

src/terminal/adapter/adaptDispatch.cpp

@@ -3845,11 +3845,11 @@ void AdaptDispatch::DoWTAction(const std::wstring_view string)
 }
 
 // Method Description:
-// - OSC 777 - Handles desktop notification requests.
+// - OSC 777 - Handles uxrvt requests. Currently, the only supported request is for desktop notifications.
 //   The format is: OSC 777;notify;title;body ST
 // Arguments:
 // - string: contains the parameters that define the notification
-void AdaptDispatch::DoDesktopNotification(const std::wstring_view string)
+void AdaptDispatch::DoUrxvtAction(const std::wstring_view string)
 {
     if (!_optionalFeatures.test(OptionalFeature::DesktopNotification))
     {
@@ -3871,6 +3871,10 @@ void AdaptDispatch::DoDesktopNotification(const std::wstring_view string)
         const auto body = parts.size() >= 3 ? til::at(parts, 2) : std::wstring_view{};
         _api.ShowNotification(title, body);
     }
+    else
+    {
+        _api.UnknownSequence();
+    }
 }
 
 // Method Description:

src/terminal/adapter/adaptDispatch.hpp

@@ -162,7 +162,7 @@ namespace Microsoft::Console::VirtualTerminal
 
         void DoWTAction(const std::wstring_view string) override;
 
-        void DoDesktopNotification(const std::wstring_view string) override;
+        void DoUrxvtAction(const std::wstring_view string) override;
 
         StringHandler DefineSixelImage(const VTInt macroParameter,
                                        const DispatchTypes::SixelBackground backgroundSelect,

src/terminal/adapter/termDispatch.hpp

@@ -152,7 +152,7 @@ class Microsoft::Console::VirtualTerminal::TermDispatch : public Microsoft::Cons
 
     void DoWTAction(const std::wstring_view /*string*/) override {}
 
-    void DoDesktopNotification(const std::wstring_view /*string*/) override {}
+    void DoUrxvtAction(const std::wstring_view /*string*/) override {}
 
     StringHandler DefineSixelImage(const VTInt /*macroParameter*/,
                                    const DispatchTypes::SixelBackground /*backgroundSelect*/,

src/terminal/parser/OutputStateMachineEngine.cpp

@@ -910,9 +910,9 @@ bool OutputStateMachineEngine::ActionOscDispatch(const size_t parameter, const s
         _dispatch->DoWTAction(string);
         break;
     }
-    case OscActionCodes::DesktopNotification:
+    case OscActionCodes::UrxvtAction:
     {
-        _dispatch->DoDesktopNotification(string);
+        _dispatch->DoUrxvtAction(string);
         break;
     }
     default:

src/terminal/parser/OutputStateMachineEngine.hpp

@@ -227,7 +227,7 @@ namespace Microsoft::Console::VirtualTerminal
             ResetHighlightColor = 117,
             FinalTermAction = 133,
             VsCodeAction = 633,
-            DesktopNotification = 777,
+            UrxvtAction = 777,
             ITerm2Action = 1337,
             WTAction = 9001,
         };