Skip to content

Commit aeb531f

Browse files
committed
spell; prefer AppDisplayName; use C++20 designated init
1 parent c23e507 commit aeb531f

File tree

3 files changed

+7
-12
lines changed

3 files changed

+7
-12
lines changed

.github/actions/spelling/expect/expect.txt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1135,9 +1135,7 @@ NOSIZE
11351135
NOSNAPSHOT
11361136
NOTHOUSANDS
11371137
NOTICKS
1138-
notifArgs
1139-
notifBody
1140-
notifTitle
1138+
notif
11411139
NOTIMEOUTIFNOTHUNG
11421140
NOTIMPL
11431141
NOTOPMOST

src/cascadia/TerminalApp/Resources/en-US/Resources.resw

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -739,10 +739,6 @@
739739
<value>Windows</value>
740740
<comment>This is displayed as a label for the context menu item that holds the submenu of available windows.</comment>
741741
</data>
742-
<data name="NotificationTitle" xml:space="preserve">
743-
<value>Windows Terminal</value>
744-
<comment>Title shown in desktop toast notifications sent by the terminal.</comment>
745-
</data>
746742
<data name="NotificationMessage_TabActivity" xml:space="preserve">
747743
<value>Activity in tab "{0}"</value>
748744
<comment>{0} is the tab title. Shown as the body of a desktop notification when tab activity is detected.</comment>

src/cascadia/TerminalApp/TabManagement.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1230,13 +1230,14 @@ namespace winrt::TerminalApp::implementation
12301230
{
12311231
message = RS_fmt(L"NotificationMessage_TabActivity", std::wstring_view{ tabTitle });
12321232
}
1233-
notificationTitle = RS_(L"NotificationTitle");
1233+
notificationTitle = CascadiaSettings::ApplicationDisplayName();
12341234
}
12351235

1236-
implementation::DesktopNotificationArgs args;
1237-
args.Title = notificationTitle;
1238-
args.Message = message;
1239-
args.TabIndex = tabIndex;
1236+
const implementation::DesktopNotificationArgs args{
1237+
.Title = notificationTitle,
1238+
.Message = message,
1239+
.TabIndex = tabIndex,
1240+
};
12401241

12411242
implementation::DesktopNotification::SendNotification(args, [weakThis{ get_weak() }](uint32_t idx) {
12421243
if (const auto page{ weakThis.get() })

0 commit comments

Comments
 (0)