Skip to content

Commit e4eb338

Browse files
committed
version: fix the LCID in our VERSIONINFO, add descriptions to each file (#19114)
Closes #19106 (cherry picked from commit f14718f) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgcbOIs Service-Version: 1.22
1 parent e1a1b80 commit e4eb338

File tree

15 files changed

+17
-0
lines changed

15 files changed

+17
-0
lines changed

custom.props

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,8 @@
77
<VersionMajor>1</VersionMajor>
88
<VersionMinor>22</VersionMinor>
99
<VersionInfoProductName>Windows Terminal</VersionInfoProductName>
10+
<VersionInfoCulture>1033</VersionInfoCulture>
11+
<!-- The default has a spacing problem -->
12+
<VersionInfoCopyRight>\xa9 Microsoft Corporation. All rights reserved.</VersionInfoCopyRight>
1013
</PropertyGroup>
1114
</Project>

src/cascadia/ElevateShim/elevate-shim.vcxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<ProjectName>elevate-shim</ProjectName>
88
<TargetName>elevate-shim</TargetName>
99
<ConfigurationType>Application</ConfigurationType>
10+
<VersionInfoFileDescription>Windows Terminal Administrator Launch Helper</VersionInfoFileDescription>
1011
</PropertyGroup>
1112

1213
<Import Project="..\..\..\common.openconsole.props" Condition="'$(OpenConsoleDir)'==''" />

src/cascadia/ShellExtension/WindowsTerminalShellExt.vcxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
<SubSystem>Console</SubSystem>
1111
<!-- suppress a bunch of Windows Universal properties from cppwinrt.props -->
1212
<OpenConsoleUniversalApp>false</OpenConsoleUniversalApp>
13+
<VersionInfoFileDescription>Windows Terminal Open Here Shell Extension</VersionInfoFileDescription>
1314
</PropertyGroup>
1415
<PropertyGroup Label="NuGet Dependencies">
1516
<TerminalCppWinrt>true</TerminalCppWinrt>

src/cascadia/TerminalApp/dll/TerminalApp.vcxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<!-- sets a bunch of Windows Universal properties -->
1212
<OpenConsoleUniversalApp>true</OpenConsoleUniversalApp>
1313
<PgoTarget>true</PgoTarget>
14+
<VersionInfoFileDescription>Windows Terminal Main UI Library</VersionInfoFileDescription>
1415
</PropertyGroup>
1516
<PropertyGroup Label="NuGet Dependencies">
1617
<TerminalCppWinrt>true</TerminalCppWinrt>

src/cascadia/TerminalAzBridge/TerminalAzBridge.vcxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<OpenConsoleUniversalApp>false</OpenConsoleUniversalApp>
1212
<ApplicationType>Windows Store</ApplicationType>
1313
<TargetPlatformIdentifier>Windows</TargetPlatformIdentifier>
14+
<VersionInfoFileDescription>Windows Terminal Azure Cloud Shell Connector</VersionInfoFileDescription>
1415
</PropertyGroup>
1516

1617
<PropertyGroup Label="NuGet Dependencies">

src/cascadia/TerminalConnection/TerminalConnection.vcxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<SubSystem>Console</SubSystem>
99
<OpenConsoleUniversalApp>true</OpenConsoleUniversalApp>
1010
<PgoTarget>true</PgoTarget>
11+
<VersionInfoFileDescription>Windows Terminal Connection Library</VersionInfoFileDescription>
1112
</PropertyGroup>
1213
<PropertyGroup Label="NuGet Dependencies">
1314
<TerminalCppWinrt>true</TerminalCppWinrt>

src/cascadia/TerminalControl/dll/TerminalControl.vcxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
projects compile properly when they depend on this "Microsoft.winmd."
2222
-->
2323
<CppWinRTNamespaceMergeDepth>3</CppWinRTNamespaceMergeDepth>
24+
<VersionInfoFileDescription>Windows Terminal Control Library</VersionInfoFileDescription>
2425
</PropertyGroup>
2526

2627
<PropertyGroup Label="NuGet Dependencies">

src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
-->
3232
<CppWinRTNamespaceMergeDepth>4</CppWinRTNamespaceMergeDepth>
3333
<XamlComponentResourceLocation>nested</XamlComponentResourceLocation>
34+
<VersionInfoFileDescription>Windows Terminal Settings UI Library</VersionInfoFileDescription>
3435
</PropertyGroup>
3536
<PropertyGroup Label="NuGet Dependencies">
3637
<TerminalCppWinrt>true</TerminalCppWinrt>

src/cascadia/TerminalSettingsModel/dll/Microsoft.Terminal.Settings.Model.vcxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
<!-- sets a bunch of Windows Universal properties -->
1212
<OpenConsoleUniversalApp>true</OpenConsoleUniversalApp>
1313
<PgoTarget>true</PgoTarget>
14+
<VersionInfoFileDescription>Windows Terminal Settings Model Library</VersionInfoFileDescription>
1415
</PropertyGroup>
1516
<PropertyGroup Label="NuGet Dependencies">
1617
<TerminalCppWinrt>true</TerminalCppWinrt>

src/cascadia/UIHelpers/UIHelpers.vcxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
<ConfigurationType>DynamicLibrary</ConfigurationType>
88
<SubSystem>Console</SubSystem>
99
<OpenConsoleUniversalApp>true</OpenConsoleUniversalApp>
10+
<VersionInfoFileDescription>Windows Terminal UI Support Library</VersionInfoFileDescription>
1011
</PropertyGroup>
1112
<PropertyGroup Label="NuGet Dependencies">
1213
<TerminalCppWinrt>true</TerminalCppWinrt>

0 commit comments

Comments
 (0)