Skip to content

Profile.Defaults should not allow Name or Source to be defined #19202

@carlos-zamora

Description

@carlos-zamora

Found as a part of this investigation: https://github.com/microsoft/terminal/pull/19156/files#r2248959745

We should probably not let users do this as it lets them apply the same name and source across all their profiles unless specifically overridden.

The fix would be pretty simple. Just add a ClearName() and ClearSource() here:

settings.baseLayerProfile = Profile::FromJson(json.profileDefaults);
// Remove the `guid` member from the default settings.
// That will hyper-explode, so just don't let them do that.
settings.baseLayerProfile->ClearGuid();
settings.baseLayerProfile->Origin(OriginTag::ProfilesDefaults);

Metadata

Metadata

Assignees

Labels

Area-SettingsIssues related to settings and customizability, for console or terminalIssue-BugIt either shouldn't be doing this or needs an investigation.Product-TerminalThe new Windows Terminal.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions