review changes

Author: Realtyxxx

CMakeLists.txt

@@ -17,12 +17,11 @@ add_subdirectory(tools/triton-shared-opt)
 if(TRITON_SHARED_BUILD_CPU_BACKEND)
     add_triton_plugin(TritonShared ${CMAKE_CURRENT_SOURCE_DIR}/triton_shared.cc LINK_LIBS TritonSharedAnalysis TritonToLinalg TritonTilingExtIR)
     target_link_libraries(TritonShared
-        PUBLIC
+        PRIVATE
         MLIRAffineToStandard
         MLIRReconcileUnrealizedCasts
         MLIRSCFToControlFlow
 
-        # ! transforms
         MLIRBufferizationTransforms
         MLIRArithTransforms
         MLIRMemRefTransforms
@@ -43,10 +42,7 @@ if(TRITON_SHARED_BUILD_CPU_BACKEND)
         MLIRVectorToSCF
         TPtrToLLVM
         MLIRUBToLLVM
-        # MLIRMathToLibm
-
 
-        PRIVATE
         Python3::Module
         pybind11::headers
         ${Python3_LIBRARIES}

include/triton-shared/Conversion/TPtrToLLVM/Passes.td

@@ -5,16 +5,6 @@ include "mlir/Pass/PassBase.td"
 
 def TPtrToLLVM : Pass<"tptr-to-llvm", "mlir::ModuleOp"> {
   let summary = "Convert Tptr operations into LLVM";
-  let options = [
-//       Option<"addptrToLLVM", "ptradd-to-llvm", "bool", /*default*/"true",
-//              "Convert tptr.ptradd on tensors to llvm">,
-//       Option<"fromMemrefToLLVM", "from-memref-to-llvm", "bool", /*default*/"true",
-//              "Convert tptr.from_memref on tensors to llvm">,
-//       Option<"toMemrefToLLVM", "to-memref-to-llvm", "bool", /*default*/"true",
-//              "Convert tptr.to_memref on tensors to llvm">,
-//       Option<"typeoffsetToConst", "typeoffset-to-const", "bool", /*default*/"true",
-//              "Convert tptr.typeoffset to llvm.mlir.const">,
-  ];
   let dependentDialects = ["mlir::tptr::TPtrDialect", "mlir::LLVM::LLVMDialect"];
 }
 #endif

include/triton-shared/Conversion/TPtrToLLVM/TPtrToLLVM.h

@@ -10,13 +10,7 @@ namespace mlir {
 namespace tptr {
 
 #define GEN_PASS_DECL
-// #define GEN_PASS_CLASSES
-// #define GEN_PASS_DECL_TPTRTOLLVM
-// #define GEN_PASS_DEF_TPTRTOLLVM
 #include "triton-shared/Conversion/TPtrToLLVM/Passes.h.inc"
-
-// void populateTPtrToLLVMCanonicalizationPatterns(RewritePatternSet &patterns);
-
 void populateTPtrToLLVMConversionPatterns(RewritePatternSet &patterns,
                                           TypeConverter &typeconverter);