Skip to content

Commit 6b5b4aa

Browse files
authored
Harden HTTP proxy tests (#289)
1 parent 7878207 commit 6b5b4aa

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cli/integrationtest/httpproxy_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ func TestHttpProxy(t *testing.T) {
101101
t.Log("stdErr", stdErr)
102102
}
103103
require.Error(t, err, "curl should fail because the proxy is not used")
104-
s.ShellExecSucceeds("tyger-proxy", fmt.Sprintf("curl --retry 5 --proxy %s --fail %s/metadata", squidProxy, tygerUrl))
104+
s.ShellExecSucceeds("tyger-proxy", fmt.Sprintf("curl --retry 5 --retry-connrefused --retry-delay 1 --proxy %s --fail %s/metadata", squidProxy, tygerUrl))
105105

106106
// Specify the proxy via environment variable
107107
s.ShellExecSucceeds("tyger-proxy", fmt.Sprintf("export HTTPS_PROXY=%s && tyger login -f /creds.yml --log-level trace && tyger buffer read %s > /dev/null", squidProxy, bufferId))
@@ -149,7 +149,7 @@ func TestHttpProxy(t *testing.T) {
149149

150150
_, _, err = s.ShellExec("tyger-proxy", fmt.Sprintf("curl --proxy %s --fail %s/metadata", squidProxy, tygerUrl))
151151
require.Error(t, err, "curl should fail because the root CA certificates have been removed")
152-
s.ShellExecSucceeds("tyger-proxy", fmt.Sprintf("curl --retry 5 --proxy %s --insecure --fail %s/metadata", squidProxy, tygerUrl))
152+
s.ShellExecSucceeds("tyger-proxy", fmt.Sprintf("curl --retry 5 --retry-connrefused --retry-delay 1 --proxy %s --insecure --fail %s/metadata", squidProxy, tygerUrl))
153153

154154
// Use CA certificates that are embedded in the tyger binary
155155
s.ShellExecSucceeds("tyger-proxy", "echo 'tlsCaCertificates: embedded' >> /creds.yml")

0 commit comments

Comments
 (0)