Skip to content

Commit 33cc07e

Browse files
Update documentation: PR #62549 was pre-emptively ported in PR #1828
Co-authored-by: RyanCavanaugh <[email protected]>
1 parent 9addde4 commit 33cc07e

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

PR_62549_PORT_STATUS.md

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,16 @@ The testdata contains `.diff` files showing differences between the Go implement
3838
2. The TypeScript submodule baselines haven't been regenerated yet (shallow clone)
3939
3. The test framework correctly handles these differences
4040

41+
## History
42+
The change from PR #62549 was actually ported **before** it was merged into TypeScript!
43+
44+
- **Oct 5, 2025**: @Andarist opened PR #1828 to port microsoft/TypeScript#48172 which added the `ignoreArrowFunctions` parameter
45+
- **In PR #1828**: The Go implementation was already passing `true` for `ignoreArrowFunctions` in the arguments check
46+
- **Oct 5, 2025**: @Andarist opened microsoft/TypeScript#62549 to make TypeScript match the Go behavior
47+
- **Oct 5, 2025**: PR #62549 was merged into TypeScript
48+
49+
As noted in the [PR #1828 review](https://github.com/microsoft/typescript-go/pull/1828#discussion_r2404688959):
50+
> "this has some seemingly unwanted diffs but I think this is basically desired and I opened a PR to Strada to close this gap: microsoft/TypeScript#62549"
51+
4152
## Conclusion
42-
No action needed. The change has been correctly ported and is functioning as expected.
53+
No action needed. The change has been correctly ported and is functioning as expected. In fact, the Go port led the way, and TypeScript followed!

0 commit comments

Comments
 (0)