Fix instability

Author: jakebailey

internal/checker/nodebuilderimpl.go

@@ -2129,7 +2129,17 @@ func (b *nodeBuilderImpl) getPropertyNameNodeForSymbol(symbol *ast.Symbol) *ast.
 	if fromNameType != nil {
 		return fromNameType
 	}
-	return b.createPropertyNameNodeForIdentifierOrLiteral(symbol.Name, singleQuote, stringNamed, isMethod)
+
+	name := symbol.Name
+	const privateNamePrefix = ast.InternalSymbolNamePrefix + "#"
+	if strings.HasPrefix(name, privateNamePrefix) {
+		// symbol IDs are unstable - replace #nnn# with #private#
+		name = name[len(privateNamePrefix):]
+		name = strings.TrimLeftFunc(name, stringutil.IsDigit)
+		name = "__#private" + name
+	}
+
+	return b.createPropertyNameNodeForIdentifierOrLiteral(name, singleQuote, stringNamed, isMethod)
 }
 
 // See getNameForSymbolFromNameType for a stringy equivalent

testdata/baselines/reference/submodule/compiler/privateFieldsInClassExpressionDeclaration.js

@@ -31,15 +31,15 @@ export const ClassExpressionStatic = class {
 //// [privateFieldsInClassExpressionDeclaration.d.ts]
 export declare const ClassExpression: {
     new (): {
-        "\uFFFD#124907@#context": number;
-        "\uFFFD#124907@#method"(): number;
+        "__#private@#context": number;
+        "__#private@#method"(): number;
         value: number;
     };
 };
 export declare const ClassExpressionStatic: {
     new (): {
-        "\uFFFD#124908@#instancePrivate": boolean;
+        "__#private@#instancePrivate": boolean;
         exposed: string;
     };
-    "\uFFFD#124908@#staticPrivate": string;
+    "__#private@#staticPrivate": string;
 };

testdata/baselines/reference/submodule/compiler/privateFieldsInClassExpressionDeclaration.js.diff

@@ -42,22 +42,4 @@
 +};
 
 
- //// [privateFieldsInClassExpressionDeclaration.d.ts]
- export declare const ClassExpression: {
-     new (): {
--        "__#private@#context": number;
--        "__#private@#method"(): number;
-+        "\uFFFD#124907@#context": number;
-+        "\uFFFD#124907@#method"(): number;
-         value: number;
-     };
- };
- export declare const ClassExpressionStatic: {
-     new (): {
--        "__#private@#instancePrivate": boolean;
-+        "\uFFFD#124908@#instancePrivate": boolean;
-         exposed: string;
-     };
--    "__#private@#staticPrivate": string;
-+    "\uFFFD#124908@#staticPrivate": string;
- };
+ //// [privateFieldsInClassExpressionDeclaration.d.ts]