more

Author: jakebailey

internal/ls/changetrackerimpl.go

@@ -302,7 +302,7 @@ func (ct *changeTracker) getAdjustedEndPosition(sourceFile *ast.SourceFile, node
 // ============= utilities =============
 
 func hasCommentsBeforeLineBreak(text string, start int) bool {
-	for _, ch := range []rune(text[start:]) {
+	for _, ch := range text[start:] {
 		if !stringutil.IsWhiteSpaceSingleLine(ch) {
 			return ch == '/'
 		}

internal/ls/completions.go

@@ -3347,7 +3347,7 @@ func charactersFuzzyMatchInString(identifierString string, lowercaseCharacters s
 	lowerCaseRunes := []rune(lowercaseCharacters)
 	testChar := lowerCaseRunes[characterIndex]
 
-	for _, strChar := range []rune(identifierString) {
+	for _, strChar := range identifierString {
 		if strChar == testChar || strChar == unicode.ToUpper(testChar) {
 			willMatchFirstChar := prevChar == 0 || // Beginning of word
 				'a' <= prevChar && prevChar <= 'z' && 'A' <= strChar && strChar <= 'Z' || // camelCase transition

internal/project/refcounting_test.go

@@ -99,7 +99,7 @@ func TestRefCountingCaches(t *testing.T) {
 			assert.NilError(t, err)
 			assert.Equal(t, utilsEntry.refCount, 1)
 			assert.Equal(t, mainEntry.refCount, 0)
-			mainEntry, ok := session.parseCache.entries.Load(newParseCacheKey(main.ParseOptions(), main.ScriptKind))
+			_, ok := session.parseCache.entries.Load(newParseCacheKey(main.ParseOptions(), main.ScriptKind))
 			assert.Equal(t, ok, false)
 		})
 	})

internal/tsoptions/tsconfigparsing.go

@@ -1606,7 +1606,7 @@ func getFileNamesFromConfigSpecs(
 	host vfs.FS,
 	extraFileExtensions []FileExtensionInfo,
 ) ([]string, int) {
-	extraFileExtensions = []FileExtensionInfo{}
+	extraFileExtensions = []FileExtensionInfo{} //nolint:staticcheck
 	basePath = tspath.NormalizePath(basePath)
 	keyMappper := func(value string) string { return tspath.GetCanonicalFileName(value, host.UseCaseSensitiveFileNames()) }
 	// Literal file names (provided via the "files" array in tsconfig.json) are stored in a