Merge branch 'main' into fix/1374

Author: a-tarasyuk

.github/agents/strada-corsa-port.md

@@ -0,0 +1,22 @@
+---
+name: Strada to Corsa Port Expert
+description: A Go and TypeScript expert who can easily figure out how to port PRs from one language to another
+---
+
+This repository is a port of `microsoft/TypeScript` from TypeScript to Go. Since the port began, the following pull request was applied to microsoft/TypeScript. An equivalent change now needs to be applied here. The user will give you a link to the PR and you will need to try to port it to this repo.
+
+Instructions
+- Use `curl` to fetch e.g. `https://api.github.com/repos/microsoft/typescript/pulls/59767` to view the merge commit SHA
+- Then use `curl` to fetch e.g. `https://github.com/microsoft/TypeScript/commit/bd3d70058c30253209199cc9dfeb85e72330d79b.patch` to download the diff patch
+- Use Playwright MCP if you have other information from github you need, since you won't have MCP access to the TypeScript repo
+- Apply the edits made in that PR to this codebase, translating them from TypeScript to Go.
+- The change may or may not be applicable. It may have already been ported. Do not make any significant changes outside the scope of the diff. If the change cannot be applied without significant out-of-scope changes, explain why and stop working.
+  - Tip: search for functions and identifiers from the diff to find the right location to apply edits. Some files in microsoft/TypeScript have been split into multiple.
+  - Tip: some changes have already been ported, like changes to diagnostic message text. Tests do not need to be ported as they are imported from the submodule.
+- Check that the code builds by running npx hereby build in the terminal.
+- Run tests. It is expected that tests will fail due to baseline changes.
+  - Run `npx hereby test` in a terminal. They should fail with messages about baseline changes.
+  - Tip: to run a single baseline test from the submodule, run go test ./internal/testrunner -run '^TestSubmodule/NAME_OF_TEST_FILE'
+  - Run npx hereby baseline-accept to adopt the baseline changes.
+  - Run git diff 'testdata/**/*.diff'. If your change is correct, these diff files will be reduced or completely deleted.
+- Iterate until you are satisfied with your change. Commit everything, including the baseline changes in testdata, and open a PR.

_submodules/TypeScript

@@ -1,27 +1,12 @@
-error TS2209: The project root is ambiguous, but is required to resolve export map entry '.' in file 'package.json'. Supply the `rootDir` compiler option to disambiguate.
-index.cjs(2,22): error TS2307: Cannot find module 'package/cjs' or its corresponding type declarations.
-index.cjs(3,22): error TS2307: Cannot find module 'package/mjs' or its corresponding type declarations.
-index.cjs(4,23): error TS2307: Cannot find module 'package' or its corresponding type declarations.
-index.js(2,22): error TS2307: Cannot find module 'package/cjs' or its corresponding type declarations.
-index.js(3,22): error TS2307: Cannot find module 'package/mjs' or its corresponding type declarations.
-index.js(4,23): error TS2307: Cannot find module 'package' or its corresponding type declarations.
-index.mjs(2,22): error TS2307: Cannot find module 'package/cjs' or its corresponding type declarations.
-index.mjs(3,22): error TS2307: Cannot find module 'package/mjs' or its corresponding type declarations.
-index.mjs(4,23): error TS2307: Cannot find module 'package' or its corresponding type declarations.
+index.cjs(3,22): error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("package/mjs")' call instead.
+index.cjs(4,23): error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("package")' call instead.
 
 
-!!! error TS2209: The project root is ambiguous, but is required to resolve export map entry '.' in file 'package.json'. Supply the `rootDir` compiler option to disambiguate.
-==== index.js (3 errors) ====
+==== index.js (0 errors) ====
     // esm format file
     import * as cjs from "package/cjs";
-                         ~~~~~~~~~~~~~
-!!! error TS2307: Cannot find module 'package/cjs' or its corresponding type declarations.
     import * as mjs from "package/mjs";
-                         ~~~~~~~~~~~~~
-!!! error TS2307: Cannot find module 'package/mjs' or its corresponding type declarations.
     import * as type from "package";
-                          ~~~~~~~~~
-!!! error TS2307: Cannot find module 'package' or its corresponding type declarations.
     cjs;
     mjs;
     type;
@@ -33,17 +18,11 @@ index.mjs(4,23): error TS2307: Cannot find module 'package' or its corresponding
     mjsi.mjsSource;
     typei.mjsSource;
     ts.mjsSource;
-==== index.mjs (3 errors) ====
+==== index.mjs (0 errors) ====
     // esm format file
     import * as cjs from "package/cjs";
-                         ~~~~~~~~~~~~~
-!!! error TS2307: Cannot find module 'package/cjs' or its corresponding type declarations.
     import * as mjs from "package/mjs";
-                         ~~~~~~~~~~~~~
-!!! error TS2307: Cannot find module 'package/mjs' or its corresponding type declarations.
     import * as type from "package";
-                          ~~~~~~~~~
-!!! error TS2307: Cannot find module 'package' or its corresponding type declarations.
     cjs;
     mjs;
     type;
@@ -55,17 +34,15 @@ index.mjs(4,23): error TS2307: Cannot find module 'package' or its corresponding
     mjsi.mjsSource;
     typei.mjsSource;
     ts.mjsSource;
-==== index.cjs (3 errors) ====
+==== index.cjs (2 errors) ====
     // cjs format file
     import * as cjs from "package/cjs";
-                         ~~~~~~~~~~~~~
-!!! error TS2307: Cannot find module 'package/cjs' or its corresponding type declarations.
     import * as mjs from "package/mjs";
                          ~~~~~~~~~~~~~
-!!! error TS2307: Cannot find module 'package/mjs' or its corresponding type declarations.
+!!! error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("package/mjs")' call instead.
     import * as type from "package";
                           ~~~~~~~~~
-!!! error TS2307: Cannot find module 'package' or its corresponding type declarations.
+!!! error TS1479: The current file is a CommonJS module whose imports will produce 'require' calls; however, the referenced file is an ECMAScript module and cannot be imported with 'require'. Consider writing a dynamic 'import("package")' call instead.
     cjs;
     mjs;
     type;
@@ -78,6 +55,9 @@ index.mjs(4,23): error TS2307: Cannot find module 'package' or its corresponding
     typei.implicitCjsSource;
     ts.cjsSource;
 ==== node_modules/inner/index.d.ts (0 errors) ====
+    // cjs format file
+    export const implicitCjsSource = true;
+==== node_modules/inner/test.d.ts (0 errors) ====
     // cjs format file
     import * as cjs from "inner/a";
     import * as mjs from "inner/b";
@@ -87,8 +67,10 @@ index.mjs(4,23): error TS2307: Cannot find module 'package' or its corresponding
     export { mjs };
     export { type };
     export { ts };
-    export const implicitCjsSource = true;
 ==== node_modules/inner/index.d.mts (0 errors) ====
+    // esm format file
+    export const mjsSource = true;
+==== node_modules/inner/test.d.mts (0 errors) ====
     // esm format file
     import * as cjs from "inner/a";
     import * as mjs from "inner/b";
@@ -98,8 +80,10 @@ index.mjs(4,23): error TS2307: Cannot find module 'package' or its corresponding
     export { mjs };
     export { type };
     export { ts };
-    export const mjsSource = true;
 ==== node_modules/inner/index.d.cts (0 errors) ====
+    // cjs format file
+    export const cjsSource = true;
+==== node_modules/inner/test.d.cts (0 errors) ====
     // cjs format file
     import * as cjs from "inner/a";
     import * as mjs from "inner/b";
@@ -109,7 +93,6 @@ index.mjs(4,23): error TS2307: Cannot find module 'package' or its corresponding
     export { mjs };
     export { type };
     export { ts };
-    export const cjsSource = true;
 ==== package.json (0 errors) ====
     {
         "name": "package",

testdata/baselines/reference/submodule/conformance/nodeModulesAllowJsConditionalPackageExports(module=node16).errors.txt

@@ -50,37 +50,43 @@ typei.implicitCjsSource;
 ts.cjsSource;
 //// [index.d.ts]
 // cjs format file
+export const implicitCjsSource = true;
+//// [test.d.ts]
+// cjs format file
 import * as cjs from "inner/a";
 import * as mjs from "inner/b";
 import * as type from "inner";
 import * as ts from "inner/types";
 export { cjs };
 export { mjs };
 export { type };
-export { ts };
-export const implicitCjsSource = true;
+export { ts };
 //// [index.d.mts]
 // esm format file
+export const mjsSource = true;
+//// [test.d.mts]
+// esm format file
 import * as cjs from "inner/a";
 import * as mjs from "inner/b";
 import * as type from "inner";
 import * as ts from "inner/types";
 export { cjs };
 export { mjs };
 export { type };
-export { ts };
-export const mjsSource = true;
+export { ts };
 //// [index.d.cts]
 // cjs format file
+export const cjsSource = true;
+//// [test.d.cts]
+// cjs format file
 import * as cjs from "inner/a";
 import * as mjs from "inner/b";
 import * as type from "inner";
 import * as ts from "inner/types";
 export { cjs };
 export { mjs };
 export { type };
-export { ts };
-export const cjsSource = true;
+export { ts };
 //// [package.json]
 {
     "name": "package",
@@ -123,22 +129,6 @@ export const cjsSource = true;
 }
 
 
-//// [index.js]
-// esm format file
-import * as cjs from "package/cjs";
-import * as mjs from "package/mjs";
-import * as type from "package";
-cjs;
-mjs;
-type;
-import * as cjsi from "inner/a";
-import * as mjsi from "inner/b";
-import * as typei from "inner";
-import * as ts from "inner/types";
-cjsi.mjsSource;
-mjsi.mjsSource;
-typei.mjsSource;
-ts.mjsSource;
 //// [index.mjs]
 // esm format file
 import * as cjs from "package/cjs";
@@ -206,11 +196,27 @@ cjsi.cjsSource;
 mjsi.cjsSource;
 typei.implicitCjsSource;
 ts.cjsSource;
+//// [index.js]
+// esm format file
+import * as cjs from "package/cjs";
+import * as mjs from "package/mjs";
+import * as type from "package";
+cjs;
+mjs;
+type;
+import * as cjsi from "inner/a";
+import * as mjsi from "inner/b";
+import * as typei from "inner";
+import * as ts from "inner/types";
+cjsi.mjsSource;
+mjsi.mjsSource;
+typei.mjsSource;
+ts.mjsSource;
 
 
-//// [index.d.ts]
-export {};
 //// [index.d.mts]
 export {};
 //// [index.d.cts]
 export {};
+//// [index.d.ts]
+export {};