Fix typo in isRequiredInitializedParameter (#1598)

Author: weswigham

internal/checker/checker.go

@@ -17776,7 +17776,7 @@ func (c *Checker) addOptionalityEx(t *Type, isProperty bool, isOptional bool) *T
 }
 
 func (c *Checker) getOptionalType(t *Type, isProperty bool) *Type {
-	// debug.Assert(c.strictNullChecks) // TODO: fix bug in isRequiredInitializedParameter
+	debug.Assert(c.strictNullChecks)
 	missingOrUndefined := core.IfElse(isProperty, c.undefinedOrMissingType, c.undefinedType)
 	if t == missingOrUndefined || t.flags&TypeFlagsUnion != 0 && t.Types()[0] == missingOrUndefined {
 		return t

internal/checker/emitresolver.go

@@ -552,7 +552,7 @@ func (r *emitResolver) isOptionalUninitializedParameterProperty(parameter *ast.N
 }
 
 func (r *emitResolver) isRequiredInitializedParameter(parameter *ast.Node, enclosingDeclaration *ast.Node) bool {
-	if r.checker.strictNullChecks || r.isOptionalParameter(parameter) || /*isJSDocParameterTag(parameter) ||*/ parameter.Initializer() == nil { // !!! TODO: JSDoc Support
+	if !r.checker.strictNullChecks || r.isOptionalParameter(parameter) || /*isJSDocParameterTag(parameter) ||*/ parameter.Initializer() == nil { // !!! TODO: JSDoc Support
 		return false
 	}
 	if ast.HasSyntacticModifier(parameter, ast.ModifierFlagsParameterPropertyModifier) {

testdata/baselines/reference/submodule/compiler/declarationEmitCastReusesTypeNode1(strictnullchecks=false).js

@@ -31,6 +31,9 @@ export function fnWithPartialAnnotationOnDefaultparam(x: P = null! as P, b: numb
 
 
 //// [declarationEmitCastReusesTypeNode1.d.ts]
+type P = {} & {
+    name: string;
+};
 export declare let vLet: {
     name: string;
 };
@@ -77,6 +80,4 @@ declare const _default: {
 };
 export default _default;
 // allows `undefined` on the input side, thanks to the initializer
-export declare function fnWithPartialAnnotationOnDefaultparam(x: {
-    name: string;
-}, b: number): void;
+export declare function fnWithPartialAnnotationOnDefaultparam(x: P, b: number): void;

testdata/baselines/reference/submodule/compiler/declarationEmitCastReusesTypeNode1(strictnullchecks=false).js.diff

@@ -1,12 +1,9 @@
 --- old.declarationEmitCastReusesTypeNode1(strictnullchecks=false).js
 +++ new.declarationEmitCastReusesTypeNode1(strictnullchecks=false).js
-@@= skipped -30, +30 lines =@@
-
-
- //// [declarationEmitCastReusesTypeNode1.d.ts]
--type P = {} & {
--    name: string;
--};
+@@= skipped -33, +33 lines =@@
+ type P = {} & {
+     name: string;
+ };
 -export declare let vLet: P;
 -export declare const vConst: P;
 -export declare function fn(p?: P): void;
@@ -66,8 +63,5 @@
 +    name: string;
 +};
  export default _default;
--export declare function fnWithPartialAnnotationOnDefaultparam(x: P, b: number): void;
 +// allows `undefined` on the input side, thanks to the initializer
-+export declare function fnWithPartialAnnotationOnDefaultparam(x: {
-+    name: string;
-+}, b: number): void;
+ export declare function fnWithPartialAnnotationOnDefaultparam(x: P, b: number): void;

testdata/baselines/reference/submodule/compiler/declarationEmitCastReusesTypeNode1(strictnullchecks=true).js

@@ -31,9 +31,6 @@ export function fnWithPartialAnnotationOnDefaultparam(x: P = null! as P, b: numb
 
 
 //// [declarationEmitCastReusesTypeNode1.d.ts]
-type P = {} & {
-    name: string;
-};
 export declare let vLet: {
     name: string;
 };
@@ -45,7 +42,7 @@ export declare function fn(p?: {
 }): void;
 export declare function fnWithRequiredDefaultParam(p: {
     name: string;
-}, req: number): void;
+} | undefined, req: number): void;
 export declare class C {
     ctorField: {
         name: string;
@@ -64,7 +61,7 @@ export declare class C {
     }): void;
     methodWithRequiredDefault(p: {
         name: string;
-    }, req: number): void;
+    } | undefined, req: number): void;
     constructor(ctorField?: {
         name: string;
     });
@@ -80,4 +77,6 @@ declare const _default: {
 };
 export default _default;
 // allows `undefined` on the input side, thanks to the initializer
-export declare function fnWithPartialAnnotationOnDefaultparam(x: P, b: number): void;
+export declare function fnWithPartialAnnotationOnDefaultparam(x: {
+    name: string;
+} | undefined, b: number): void;

testdata/baselines/reference/submodule/compiler/declarationEmitCastReusesTypeNode1(strictnullchecks=true).js.diff

@@ -1,9 +1,12 @@
 --- old.declarationEmitCastReusesTypeNode1(strictnullchecks=true).js
 +++ new.declarationEmitCastReusesTypeNode1(strictnullchecks=true).js
-@@= skipped -33, +33 lines =@@
- type P = {} & {
-     name: string;
- };
+@@= skipped -30, +30 lines =@@
+
+
+ //// [declarationEmitCastReusesTypeNode1.d.ts]
+-type P = {} & {
+-    name: string;
+-};
 -export declare let vLet: P;
 -export declare const vConst: P;
 -export declare function fn(p?: P): void;
@@ -19,7 +22,7 @@
 +}): void;
 +export declare function fnWithRequiredDefaultParam(p: {
 +    name: string;
-+}, req: number): void;
++} | undefined, req: number): void;
  export declare class C {
 -    ctorField: P;
 -    field: P;
@@ -47,7 +50,7 @@
 +    }): void;
 +    methodWithRequiredDefault(p: {
 +        name: string;
-+    }, req: number): void;
++    } | undefined, req: number): void;
 +    constructor(ctorField?: {
 +        name: string;
 +    });
@@ -65,4 +68,6 @@
  export default _default;
 -export declare function fnWithPartialAnnotationOnDefaultparam(x: P | undefined, b: number): void;
 +// allows `undefined` on the input side, thanks to the initializer
-+export declare function fnWithPartialAnnotationOnDefaultparam(x: P, b: number): void;
++export declare function fnWithPartialAnnotationOnDefaultparam(x: {
++    name: string;
++} | undefined, b: number): void;

testdata/baselines/reference/submodule/compiler/declarationEmitCastReusesTypeNode2(strictnullchecks=false).js

@@ -75,6 +75,6 @@ declare const _default: {
 };
 export default _default;
 // allows `undefined` on the input side, thanks to the initializer
-export declare function fnWithPartialAnnotationOnDefaultparam(x: {
+export declare function fnWithPartialAnnotationOnDefaultparam(x: {} & {
     name: string;
 }, b: number): void;

testdata/baselines/reference/submodule/compiler/declarationEmitCastReusesTypeNode2(strictnullchecks=false).js.diff

@@ -75,8 +75,7 @@
      name: string;
  };
  export default _default;
--export declare function fnWithPartialAnnotationOnDefaultparam(x: {} & {
 +// allows `undefined` on the input side, thanks to the initializer
-+export declare function fnWithPartialAnnotationOnDefaultparam(x: {
+ export declare function fnWithPartialAnnotationOnDefaultparam(x: {} & {
      name: string;
  }, b: number): void;

testdata/baselines/reference/submodule/compiler/declarationEmitCastReusesTypeNode2(strictnullchecks=true).js

@@ -40,7 +40,7 @@ export declare function fn(p?: {
 }): void;
 export declare function fnWithRequiredDefaultParam(p: {
     name: string;
-}, req: number): void;
+} | undefined, req: number): void;
 export declare class C {
     ctorField: {
         name: string;
@@ -59,7 +59,7 @@ export declare class C {
     }): void;
     methodWithRequiredDefault(p: {
         name: string;
-    }, req: number): void;
+    } | undefined, req: number): void;
     constructor(ctorField?: {
         name: string;
     });
@@ -75,6 +75,6 @@ declare const _default: {
 };
 export default _default;
 // allows `undefined` on the input side, thanks to the initializer
-export declare function fnWithPartialAnnotationOnDefaultparam(x: {} & {
+export declare function fnWithPartialAnnotationOnDefaultparam(x: {
     name: string;
-}, b: number): void;
+} | undefined, b: number): void;

testdata/baselines/reference/submodule/compiler/declarationEmitCastReusesTypeNode2(strictnullchecks=true).js.diff

@@ -24,7 +24,7 @@
 +export declare function fnWithRequiredDefaultParam(p: {
      name: string;
 -}) | undefined, req: number): void;
-+}, req: number): void;
++} | undefined, req: number): void;
  export declare class C {
 -    ctorField: {} & {
 -        name: string;
@@ -59,7 +59,7 @@
          name: string;
 -    }) | undefined, req: number): void;
 -    constructor(ctorField?: {} & {
-+    }, req: number): void;
++    } | undefined, req: number): void;
 +    constructor(ctorField?: {
          name: string;
      });
@@ -79,7 +79,7 @@
  export default _default;
 -export declare function fnWithPartialAnnotationOnDefaultparam(x: ({} & {
 +// allows `undefined` on the input side, thanks to the initializer
-+export declare function fnWithPartialAnnotationOnDefaultparam(x: {} & {
++export declare function fnWithPartialAnnotationOnDefaultparam(x: {
      name: string;
 -}) | undefined, b: number): void;
-+}, b: number): void;
++} | undefined, b: number): void;