Fix bogus "no jsdoc types" error in jsdoc (#1524)

sandersn · web-flow · commit 6d4ae18c9f31 · 2025-08-06T16:21:19.000Z
diff --git a/internal/checker/checker.go b/internal/checker/checker.go
@@ -2784,7 +2784,7 @@ func (c *Checker) checkAccessorDeclaration(node *ast.Node) {
 
 func (c *Checker) checkTypeReferenceNode(node *ast.Node) {
 	c.checkGrammarTypeArguments(node, node.TypeArgumentList())
-	if ast.IsTypeReferenceNode(node) {
+	if ast.IsTypeReferenceNode(node) && node.Flags&ast.NodeFlagsJSDoc == 0 {
 		data := node.AsTypeReferenceNode()
 		if data.TypeArguments != nil && data.TypeName.End() != data.TypeArguments.Pos() {
 			// If there was a token between the type name and the type arguments, check if it was a DotToken
diff --git a/testdata/baselines/reference/submodule/conformance/checkJsdocSatisfiesTag12.errors.txt b/testdata/baselines/reference/submodule/conformance/checkJsdocSatisfiesTag12.errors.txt
@@ -1,11 +1,10 @@
 /a.js(24,20): error TS2353: Object literal may only specify known properties, and 'b' does not exist in type 'T1'.
 /a.js(29,14): error TS2741: Property 'a' is missing in type '{}' but required in type 'T1'.
-/a.js(32,21): error TS8020: JSDoc types can only be used inside documentation comments.
 /a.js(44,25): error TS2353: Object literal may only specify known properties, and 'b' does not exist in type 'T2'.
 /a.js(51,42): error TS1360: Type 'number' does not satisfy the expected type 'string'.
 
 
-==== /a.js (5 errors) ====
+==== /a.js (4 errors) ====
     /**
      * @typedef {Object} T1
      * @property {number} a
@@ -43,8 +42,6 @@
     
     /**
      * @satisfies {Array.<number, number>}
-                        ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
      */
     const t4 = [1, 2];
     
diff --git a/testdata/baselines/reference/submodule/conformance/checkJsdocSatisfiesTag2.errors.txt b/testdata/baselines/reference/submodule/conformance/checkJsdocSatisfiesTag2.errors.txt
@@ -1,13 +1,10 @@
 /a.js(1,15): error TS2315: Type 'Object' is not generic.
-/a.js(1,21): error TS8020: JSDoc types can only be used inside documentation comments.
 
 
-==== /a.js (2 errors) ====
+==== /a.js (1 errors) ====
     /** @typedef {Object.<string, (n: number) => boolean>} Predicates */
                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2315: Type 'Object' is not generic.
-                        ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
     
     const p = /** @satisfies {Predicates} */ ({
         isEven: n => n % 2 === 0,
diff --git a/testdata/baselines/reference/submodule/conformance/checkJsdocSatisfiesTag8.errors.txt b/testdata/baselines/reference/submodule/conformance/checkJsdocSatisfiesTag8.errors.txt
@@ -1,13 +1,10 @@
 /a.js(1,15): error TS2315: Type 'Object' is not generic.
-/a.js(1,21): error TS8020: JSDoc types can only be used inside documentation comments.
 
 
-==== /a.js (2 errors) ====
+==== /a.js (1 errors) ====
     /** @typedef {Object.<string, boolean>} Facts */
                   ~~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2315: Type 'Object' is not generic.
-                        ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
     
     // Should be able to detect a failure here
     const x = /** @satisfies {Facts} */ ({
diff --git a/testdata/baselines/reference/submodule/conformance/classCanExtendConstructorFunction.errors.txt b/testdata/baselines/reference/submodule/conformance/classCanExtendConstructorFunction.errors.txt
@@ -1,5 +1,4 @@
 first.js(21,19): error TS2507: Type '{ (numberOxen: number): void; circle: (wagons: any) => any; }' is not a constructor function type.
-first.js(27,21): error TS8020: JSDoc types can only be used inside documentation comments.
 first.js(44,4): error TS2339: Property 'numberOxen' does not exist on type 'Sql'.
 first.js(47,24): error TS2507: Type '(numberEaten: number) => void' is not a constructor function type.
 generic.js(9,23): error TS2507: Type '<T>(flavour: T) => void' is not a constructor function type.
@@ -12,7 +11,7 @@ second.ts(14,25): error TS2507: Type '{ (numberOxen: number): void; circle: (wag
 second.ts(26,3): error TS2339: Property 'numberOxen' does not exist on type 'Conestoga'.
 
 
-==== first.js (4 errors) ====
+==== first.js (3 errors) ====
     /**
      * @constructor
      * @param {number} numberOxen
@@ -42,8 +41,6 @@ second.ts(26,3): error TS2339: Property 'numberOxen' does not exist on type 'Con
         }
         /**
          * @param {Array.<string>} files
-                        ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
          * @param {"csv" | "json" | "xmlolololol"} format
          * This is not assignable, so should have a type error
          */
diff --git a/testdata/baselines/reference/submodule/conformance/jsDeclarationsMissingTypeParameters.errors.txt b/testdata/baselines/reference/submodule/conformance/jsDeclarationsMissingTypeParameters.errors.txt
@@ -1,8 +1,7 @@
-file.js(12,19): error TS8020: JSDoc types can only be used inside documentation comments.
 file.js(12,20): error TS1099: Type argument list cannot be empty.
 
 
-==== file.js (2 errors) ====
+==== file.js (1 errors) ====
     /**
       * @param {Array=} y desc
       */
@@ -15,8 +14,6 @@ file.js(12,20): error TS1099: Type argument list cannot be empty.
     
     /**
      * @return {(Array.<> | null)} list of devices
-                      ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
                        ~~
 !!! error TS1099: Type argument list cannot be empty.
      */
diff --git a/testdata/baselines/reference/submodule/conformance/jsDeclarationsNestedParams.errors.txt b/testdata/baselines/reference/submodule/conformance/jsDeclarationsNestedParams.errors.txt
diff --git a/testdata/baselines/reference/submodule/conformance/jsDeclarationsReusesExistingNodesMappingJSDocTypes.errors.txt b/testdata/baselines/reference/submodule/conformance/jsDeclarationsReusesExistingNodesMappingJSDocTypes.errors.txt
@@ -1,10 +1,9 @@
 index.js(16,12): error TS2552: Cannot find name 'function'. Did you mean 'Function'?
 index.js(19,12): error TS2552: Cannot find name 'function'. Did you mean 'Function'?
 index.js(22,12): error TS2315: Type 'Object' is not generic.
-index.js(22,18): error TS8020: JSDoc types can only be used inside documentation comments.
 
 
-==== index.js (4 errors) ====
+==== index.js (3 errors) ====
     /** @type {?} */
     export const a = null;
     
@@ -35,7 +34,5 @@ index.js(22,18): error TS8020: JSDoc types can only be used inside documentation
     /** @type {Object.<string, number>} */
                ~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2315: Type 'Object' is not generic.
-                     ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
     export const h = null;
     
diff --git a/testdata/baselines/reference/submodule/conformance/jsdocIndexSignature.errors.txt b/testdata/baselines/reference/submodule/conformance/jsdocIndexSignature.errors.txt
@@ -1,37 +1,25 @@
 indices.js(1,12): error TS2315: Type 'Object' is not generic.
-indices.js(1,18): error TS8020: JSDoc types can only be used inside documentation comments.
 indices.js(3,12): error TS2315: Type 'Object' is not generic.
-indices.js(3,18): error TS8020: JSDoc types can only be used inside documentation comments.
 indices.js(5,12): error TS2315: Type 'Object' is not generic.
-indices.js(5,18): error TS8020: JSDoc types can only be used inside documentation comments.
 indices.js(7,13): error TS2315: Type 'Object' is not generic.
-indices.js(7,19): error TS8020: JSDoc types can only be used inside documentation comments.
 
 
-==== indices.js (8 errors) ====
+==== indices.js (4 errors) ====
     /** @type {Object.<string, number>} */
                ~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2315: Type 'Object' is not generic.
-                     ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
     var o1;
     /** @type {Object.<number, boolean>} */
                ~~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2315: Type 'Object' is not generic.
-                     ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
     var o2;
     /** @type {Object.<boolean, string>} */
                ~~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2315: Type 'Object' is not generic.
-                     ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
     var o3;
     /** @param {Object.<string, boolean>} o */
                 ~~~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2315: Type 'Object' is not generic.
-                      ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
     function f(o) {
         o.foo = 1; // error
         o.bar = false; // ok
diff --git a/testdata/baselines/reference/submodule/conformance/typedefTagExtraneousProperty.errors.txt b/testdata/baselines/reference/submodule/conformance/typedefTagExtraneousProperty.errors.txt
@@ -1,13 +1,10 @@
 typedefTagExtraneousProperty.js(1,15): error TS2315: Type 'Object' is not generic.
-typedefTagExtraneousProperty.js(1,21): error TS8020: JSDoc types can only be used inside documentation comments.
 
 
-==== typedefTagExtraneousProperty.js (2 errors) ====
+==== typedefTagExtraneousProperty.js (1 errors) ====
     /** @typedef {Object.<string,string>} Mmap
                   ~~~~~~~~~~~~~~~~~~~~~~
 !!! error TS2315: Type 'Object' is not generic.
-                        ~
-!!! error TS8020: JSDoc types can only be used inside documentation comments.
      * @property {string} ignoreMe - should be ignored
      */
     
diff --git a/testdata/baselines/reference/submoduleAccepted/conformance/checkJsdocSatisfiesTag12.errors.txt.diff b/testdata/baselines/reference/submoduleAccepted/conformance/checkJsdocSatisfiesTag12.errors.txt.diff
@@ -3,7 +3,6 @@
 @@= skipped -0, +0 lines =@@
  /a.js(24,20): error TS2353: Object literal may only specify known properties, and 'b' does not exist in type 'T1'.
 +/a.js(29,14): error TS2741: Property 'a' is missing in type '{}' but required in type 'T1'.
-+/a.js(32,21): error TS8020: JSDoc types can only be used inside documentation comments.
  /a.js(44,25): error TS2353: Object literal may only specify known properties, and 'b' does not exist in type 'T2'.
 -/a.js(51,6): error TS1360: Type 'number' does not satisfy the expected type 'string'.
 -
@@ -12,11 +11,11 @@
 +/a.js(51,42): error TS1360: Type 'number' does not satisfy the expected type 'string'.
 +
 +
-+==== /a.js (5 errors) ====
++==== /a.js (4 errors) ====
      /**
       * @typedef {Object} T1
       * @property {number} a
-@@= skipped -34, +36 lines =@@
+@@= skipped -34, +35 lines =@@
       * @satisfies {T1}
       */
      const t3 = {};
@@ -26,12 +25,7 @@
      
      /**
       * @satisfies {Array.<number, number>}
-+                        ~
-+!!! error TS8020: JSDoc types can only be used inside documentation comments.
-      */
-     const t4 = [1, 2];
-     
-@@= skipped -24, +29 lines =@@
+@@= skipped -24, +27 lines =@@
      const t7 = { a: "a" };
      
      /** @satisfies {string} */ const t8 = (1);
diff --git a/testdata/baselines/reference/submoduleAccepted/conformance/checkJsdocSatisfiesTag2.errors.txt.diff b/testdata/baselines/reference/submoduleAccepted/conformance/checkJsdocSatisfiesTag2.errors.txt.diff
@@ -3,15 +3,12 @@
 @@= skipped -0, +0 lines =@@
 -<no content>
 +/a.js(1,15): error TS2315: Type 'Object' is not generic.
-+/a.js(1,21): error TS8020: JSDoc types can only be used inside documentation comments.
 +
 +
-+==== /a.js (2 errors) ====
++==== /a.js (1 errors) ====
 +    /** @typedef {Object.<string, (n: number) => boolean>} Predicates */
 +                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 +!!! error TS2315: Type 'Object' is not generic.
-+                        ~
-+!!! error TS8020: JSDoc types can only be used inside documentation comments.
 +    
 +    const p = /** @satisfies {Predicates} */ ({
 +        isEven: n => n % 2 === 0,
diff --git a/testdata/baselines/reference/submoduleAccepted/conformance/checkJsdocSatisfiesTag8.errors.txt.diff b/testdata/baselines/reference/submoduleAccepted/conformance/checkJsdocSatisfiesTag8.errors.txt.diff
@@ -2,19 +2,13 @@
 +++ new.checkJsdocSatisfiesTag8.errors.txt
 @@= skipped -0, +0 lines =@@
 -/a.js(6,5): error TS2322: Type 'string' is not assignable to type 'boolean'.
--
--
--==== /a.js (1 errors) ====
 +/a.js(1,15): error TS2315: Type 'Object' is not generic.
-+/a.js(1,21): error TS8020: JSDoc types can only be used inside documentation comments.
-+
-+
-+==== /a.js (2 errors) ====
+
+
+ ==== /a.js (1 errors) ====
      /** @typedef {Object.<string, boolean>} Facts */
 +                  ~~~~~~~~~~~~~~~~~~~~~~~~
 +!!! error TS2315: Type 'Object' is not generic.
-+                        ~
-+!!! error TS8020: JSDoc types can only be used inside documentation comments.
      
      // Should be able to detect a failure here
      const x = /** @satisfies {Facts} */ ({
diff --git a/testdata/baselines/reference/submoduleAccepted/conformance/classCanExtendConstructorFunction.errors.txt.diff b/testdata/baselines/reference/submoduleAccepted/conformance/classCanExtendConstructorFunction.errors.txt.diff
@@ -6,7 +6,6 @@
 -  Type '(files: string[], format: "csv" | "json" | "xmlolololol") => void' is not assignable to type '(supplies?: any[]) => void'.
 -    Target signature provides too few arguments. Expected 2 or more, but got 1.
 +first.js(21,19): error TS2507: Type '{ (numberOxen: number): void; circle: (wagons: any) => any; }' is not a constructor function type.
-+first.js(27,21): error TS8020: JSDoc types can only be used inside documentation comments.
 +first.js(44,4): error TS2339: Property 'numberOxen' does not exist on type 'Sql'.
  first.js(47,24): error TS2507: Type '(numberEaten: number) => void' is not a constructor function type.
 -generic.js(19,19): error TS2554: Expected 1 arguments, but got 0.
@@ -24,18 +23,12 @@
 -        Type 'Wagon[]' is not assignable to type '(typeof Wagon)[]'.
 -          Property 'circle' is missing in type 'Wagon' but required in type 'typeof Wagon'.
 -second.ts(17,15): error TS2345: Argument of type 'string' is not assignable to parameter of type 'number'.
--
--
--==== first.js (3 errors) ====
 +second.ts(14,25): error TS2507: Type '{ (numberOxen: number): void; circle: (wagons: any) => any; }' is not a constructor function type.
 +second.ts(26,3): error TS2339: Property 'numberOxen' does not exist on type 'Conestoga'.
-+
-+
-+==== first.js (4 errors) ====
-     /**
-      * @constructor
-      * @param {number} numberOxen
-@@= skipped -36, +33 lines =@@
+
+
+ ==== first.js (3 errors) ====
+@@= skipped -36, +32 lines =@@
      }
      // ok
      class Sql extends Wagon {
@@ -49,10 +42,7 @@
              this.foonly = 12
          }
          /**
-          * @param {Array.<string>} files
-+                        ~
-+!!! error TS8020: JSDoc types can only be used inside documentation comments.
-          * @param {"csv" | "json" | "xmlolololol"} format
+@@= skipped -13, +12 lines =@@
           * This is not assignable, so should have a type error
           */
          load(files, format) {
@@ -63,7 +53,7 @@
              if (format === "xmlolololol") {
                  throw new Error("please do not use XML. It was a joke.");
              }
-@@= skipped -30, +27 lines =@@
+@@= skipped -17, +13 lines =@@
      }
      var db = new Sql();
      db.numberOxen = db.foonly
diff --git a/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsMissingTypeParameters.errors.txt.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsMissingTypeParameters.errors.txt.diff
@@ -2,11 +2,10 @@
 +++ new.jsDeclarationsMissingTypeParameters.errors.txt
 @@= skipped -0, +0 lines =@@
 -<no content>
-+file.js(12,19): error TS8020: JSDoc types can only be used inside documentation comments.
 +file.js(12,20): error TS1099: Type argument list cannot be empty.
 +
 +
-+==== file.js (2 errors) ====
++==== file.js (1 errors) ====
 +    /**
 +      * @param {Array=} y desc
 +      */
@@ -19,8 +18,6 @@
 +    
 +    /**
 +     * @return {(Array.<> | null)} list of devices
-+                      ~
-+!!! error TS8020: JSDoc types can only be used inside documentation comments.
 +                       ~~
 +!!! error TS1099: Type argument list cannot be empty.
 +     */
diff --git a/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsNestedParams.errors.txt.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsNestedParams.errors.txt.diff
diff --git a/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsReusesExistingNodesMappingJSDocTypes.errors.txt.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsDeclarationsReusesExistingNodesMappingJSDocTypes.errors.txt.diff
diff --git a/testdata/baselines/reference/submoduleAccepted/conformance/jsdocIndexSignature.errors.txt.diff b/testdata/baselines/reference/submoduleAccepted/conformance/jsdocIndexSignature.errors.txt.diff
diff --git a/testdata/baselines/reference/submoduleAccepted/conformance/typedefTagExtraneousProperty.errors.txt.diff b/testdata/baselines/reference/submoduleAccepted/conformance/typedefTagExtraneousProperty.errors.txt.diff
