Fix incorrecrty ignored dts source file from project reference

Author: sheetalkamat

internal/compiler/fileloader.go

@@ -356,7 +356,7 @@ func (p *fileLoader) addProjectReferenceTasks(singleThreaded bool) {
 					})
 				}
 			} else {
-				for outputDts := range resolved.GetOutputDeclarationFileNames() {
+				for outputDts := range resolved.GetOutputDeclarationAndSourceFileNames() {
 					if outputDts != "" {
 						p.rootTasks = append(p.rootTasks, &parseTask{
 							normalizedFilePath: outputDts,

internal/tsoptions/parsedcommandline.go

@@ -87,7 +87,7 @@ func (p *ParsedCommandLine) ParseInputOutputNames() {
 		sourceToOutput := map[tspath.Path]*SourceOutputAndProjectReference{}
 		outputDtsToSource := map[tspath.Path]*SourceOutputAndProjectReference{}
 
-		for outputDts, source := range p.GetOutputDeclarationFileNames() {
+		for outputDts, source := range p.GetOutputDeclarationAndSourceFileNames() {
 			path := tspath.ToPath(source, p.GetCurrentDirectory(), p.UseCaseSensitiveFileNames())
 			projectReference := &SourceOutputAndProjectReference{
 				Source:    source,
@@ -131,14 +131,11 @@ func (p *ParsedCommandLine) UseCaseSensitiveFileNames() bool {
 	return p.comparePathsOptions.UseCaseSensitiveFileNames
 }
 
-func (p *ParsedCommandLine) GetOutputDeclarationFileNames() iter.Seq2[string, string] {
+func (p *ParsedCommandLine) GetOutputDeclarationAndSourceFileNames() iter.Seq2[string, string] {
 	return func(yield func(dtsName string, inputName string) bool) {
 		for _, fileName := range p.ParsedConfig.FileNames {
-			if tspath.IsDeclarationFileName(fileName) {
-				continue
-			}
 			var outputDts string
-			if !tspath.FileExtensionIs(fileName, tspath.ExtensionJson) {
+			if !tspath.IsDeclarationFileName(fileName) && !tspath.FileExtensionIs(fileName, tspath.ExtensionJson) {
 				outputDts = outputpaths.GetOutputDeclarationFileNameWorker(fileName, p.CompilerOptions(), p)
 			}
 			if !yield(outputDts, fileName) {

testdata/baselines/reference/tsbuild/moduleResolution/resolution-from-d.ts-of-referenced-project.js

@@ -52,7 +52,7 @@ export interface ValueProducerFromTs {
 }
 
 tsgo --b consumer --traceResolution -v
-ExitStatus:: DiagnosticsPresent_OutputsGenerated
+ExitStatus:: Success
 Output::
 [HH:MM:SS AM] Projects in this build: 
     * producer/tsconfig.json
@@ -118,54 +118,14 @@ Trying substitution '../common.d.ts', candidate module location: '../common.d.ts
 File '/home/src/workspaces/project/common.d.ts' exists - use it as a name resolution result.
 ======== Module name '@common' was successfully resolved to '/home/src/workspaces/project/common.d.ts'. ========
 ======== Resolving module '@common' from '/home/src/workspaces/project/producer/in-js.d.ts'. ========
+Using compiler options of project reference redirect '/home/src/workspaces/project/producer/tsconfig.json'.
 Explicitly specified module resolution kind: 'NodeNext'.
 Resolving in CJS mode with conditions 'require', 'types', 'node'.
 'paths' option is specified, looking for a pattern to match module name '@common'.
-File '/home/src/workspaces/project/producer/package.json' does not exist.
-File '/home/src/workspaces/project/package.json' does not exist.
-File '/home/src/workspaces/package.json' does not exist.
-File '/home/src/package.json' does not exist.
-File '/home/package.json' does not exist.
-File '/package.json' does not exist.
-Loading module '@common' from 'node_modules' folder, target file types: TypeScript, JavaScript, Declaration.
-Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.
-Directory '/home/src/workspaces/project/producer/node_modules' does not exist, skipping all lookups in it.
-Directory '/home/src/workspaces/project/producer/node_modules/@types' does not exist, skipping all lookups in it.
-Directory '/home/src/workspaces/project/node_modules' does not exist, skipping all lookups in it.
-Directory '/home/src/workspaces/project/node_modules/@types' does not exist, skipping all lookups in it.
-Directory '/home/src/workspaces/node_modules' does not exist, skipping all lookups in it.
-Directory '/home/src/workspaces/node_modules/@types' does not exist, skipping all lookups in it.
-Directory '/home/src/node_modules' does not exist, skipping all lookups in it.
-Directory '/home/src/node_modules/@types' does not exist, skipping all lookups in it.
-Directory '/home/node_modules' does not exist, skipping all lookups in it.
-Directory '/home/node_modules/@types' does not exist, skipping all lookups in it.
-Directory '/node_modules' does not exist, skipping all lookups in it.
-Directory '/node_modules/@types' does not exist, skipping all lookups in it.
-Searching all ancestor node_modules directories for fallback extensions: JavaScript.
-Directory '/home/src/workspaces/project/producer/node_modules' does not exist, skipping all lookups in it.
-Directory '/home/src/workspaces/project/node_modules' does not exist, skipping all lookups in it.
-Directory '/home/src/workspaces/node_modules' does not exist, skipping all lookups in it.
-Directory '/home/src/node_modules' does not exist, skipping all lookups in it.
-Directory '/home/node_modules' does not exist, skipping all lookups in it.
-Directory '/node_modules' does not exist, skipping all lookups in it.
-======== Module name '@common' was not resolved. ========
-consumer/index.ts:4:14 - error TS7006: Parameter 'n' implicitly has an 'any' type.
-
-4 v.onValue = (n) => {
-               ~
-
-producer/in-js.d.ts:1:25 - error TS2307: Cannot find module '@common' or its corresponding type declarations.
-
-1 import { OnValue } from "@common"
-                          ~~~~~~~~~
-
-
-Found 2 errors in 2 files.
-
-Errors  Files
-     1  consumer/index.ts:4
-     1  producer/in-js.d.ts:1
-
+Module name '@common', matched pattern '@common'.
+Trying substitution '../common.d.ts', candidate module location: '../common.d.ts'.
+File '/home/src/workspaces/project/common.d.ts' exists - use it as a name resolution result.
+======== Module name '@common' was successfully resolved to '/home/src/workspaces/project/common.d.ts'. ========
 //// [/home/src/tslibs/TS/Lib/lib.esnext.full.d.ts] *Lib*
 /// <reference no-default-lib="true"/>
 interface Boolean {}
@@ -199,7 +159,7 @@ v2.onValue = (n) => {
 };
 
 //// [/home/src/workspaces/project/consumer/tsconfig.tsbuildinfo] *new* 
-{"version":"FakeTSVersion","root":["./index.ts"],"semanticErrors":true}
+{"version":"FakeTSVersion","root":["./index.ts"]}
 //// [/home/src/workspaces/project/consumer/tsconfig.tsbuildinfo.readable.baseline.txt] *new* 
 {
   "version": "FakeTSVersion",
@@ -211,8 +171,7 @@ v2.onValue = (n) => {
       "original": "./index.ts"
     }
   ],
-  "size": 71,
-  "semanticErrors": true
+  "size": 49
 }
 //// [/home/src/workspaces/project/producer/index.d.ts] *new* 
 export { ValueProducerDeclaration } from "./in-js";
@@ -324,8 +283,8 @@ Signatures::
 consumer/tsconfig.json::
 SemanticDiagnostics::
 *refresh*    /home/src/tslibs/TS/Lib/lib.esnext.full.d.ts
-*refresh*    /home/src/workspaces/project/producer/in-js.d.ts
 *refresh*    /home/src/workspaces/project/common.d.ts
+*refresh*    /home/src/workspaces/project/producer/in-js.d.ts
 *refresh*    /home/src/workspaces/project/producer/index.d.ts
 *refresh*    /home/src/workspaces/project/consumer/index.ts
 Signatures::