Merge branch 'main' into jabaile/staticcheck

Author: jakebailey

.custom-gcl.yml

@@ -1,6 +1,6 @@
 # yaml-language-server: $schema=https://golangci-lint.run/jsonschema/custom-gcl.jsonschema.json
 
-version: v2.0.2
+version: v2.3.0
 
 destination: ./_tools
 

.dprint.jsonc

@@ -59,7 +59,7 @@
     // Note: if adding new languages, make sure settings.template.json is updated too.
     // Also, if updating typescript, update the one in package.json.
     "plugins": [
-        "https://plugins.dprint.dev/typescript-0.95.7.wasm",
+        "https://plugins.dprint.dev/typescript-0.95.8.wasm",
         "https://plugins.dprint.dev/json-0.20.0.wasm",
         "https://plugins.dprint.dev/g-plane/pretty_yaml-v0.5.1.wasm",
         "https://plugins.dprint.dev/exec-0.5.1.json@492414e39dea4dccc07b4af796d2f4efdb89e84bae2bd4e1e924c0cc050855bf"

.github/ISSUE_TEMPLATE/01-crash.md

@@ -0,0 +1,18 @@
+---
+name: Crash
+about: Using tsgo or the language server caused a panic
+title: ''
+labels: Crash
+assignees: ''
+
+---
+
+## Stack trace
+
+```
+[paste stack trace here]
+```
+
+## Steps to reproduce
+
+1.

.github/ISSUE_TEMPLATE/02-behavior-difference.md

@@ -0,0 +1,16 @@
+---
+name: Behavior Difference
+about: tsgo produces different results than TypeScript 5.8
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+## Steps to reproduce
+
+<!-- Share a repository link or a code sample -->
+
+## Behavior with `[email protected]`
+
+## Behavior with `tsgo`

.github/ISSUE_TEMPLATE/03-other.md

@@ -0,0 +1,10 @@
+---
+name: Other
+about: Something else
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+

.github/ISSUE_TEMPLATE/04-copilot-pr-porting.md

@@ -0,0 +1,26 @@
+---
+name: '[TypeScript Team Use] Copilot PR porting'
+about: Instructions for Copilot to port a PR from microsoft/TypeScript
+title: 'Port TypeScript PR #[NNNNN]'
+labels: Porting PR
+assignees: ''
+
+---
+
+This repository is a port of microsoft/TypeScript from TypeScript to Go. Since the port began, the following pull request was applied to microsoft/TypeScript. An equivalent change now needs to be applied here.
+
+## PR to port
+
+- PR link: <!-- https://github.com/microsoft/TypeScript/pull/NNNNN -->
+- Squash commit diff: <!-- Copy the squash commit link and append ".patch", e.g. https://github.com/microsoft/TypeScript/commit/a271797c1a95494e5f7aa8075c01941ad25cad08.patch -->
+
+## Instructions
+
+1. Use `playwright` to view the PR listed above
+2. Apply the edits made in that PR to this codebase, translating them from TypeScript to Go.
+   - The change may or may not be applicable. It may have already been ported. Do not make any significant changes outside the scope of the diff. If the change cannot be applied without significant out-of-scope changes, explain why and stop working.
+   - Tip: search for functions and identifiers from the diff to find the right location to apply edits. Some files in microsoft/TypeScript have been split into multiple.
+   - Tip: some changes have already been ported, like changes to diagnostic message text. Tests do not need to be ported as they are imported from the submodule.
+3. Refer to your copilot_instructions.md for guidance on how to build and test your change. Note the following differences to the typical development workflow:
+   - Since you are porting the implementation for a behavior that already has tests in the submodule, you don't need to add new tests. Instead, your change should change existing baselines.
+   - If done correctly, you should see removals in `.diff` baselines. These `.diff` removals are your ultimate source of truth: your change is not correct unless diffs are reduced.

.github/actions/setup-go/action.yml

@@ -19,15 +19,16 @@ runs:
         go-version: ${{ inputs.go-version }}
         cache: false
 
+    # There is more code downloaded and built than is covered by '**/go.sum',
+    # so give each job its own cache to try and not end up sharing the wrong
+    # cache between jobs, and hash the Herebyfile and golancgi-lint version.
+
     - name: Go cache
       uses: actions/cache@5a3ec84eff668545956fd18022155c47e93e2684 # v4.2.3
       with:
-        # There is more code downloaded and built than is covered by '**/go.sum',
-        # so give each job its own cache to try and not end up sharing the wrong
-        # cache between jobs.
         key: ts-setup-go-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/Herebyfile.mjs', '**/.custom-gcl.yml') }}-${{ github.workflow }}-${{ inputs.cache-name }}
         restore-keys: |
-          ts-setup-go-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/Herebyfile.mjs', '**/.custom-gcl.yml') }}
+          ts-setup-go-${{ runner.os }}-${{ steps.install-go.outputs.go-version }}-${{ hashFiles('**/go.sum', '**/Herebyfile.mjs', '**/.custom-gcl.yml') }}-${{ github.workflow }}-
         path: |
           ~/go/pkg/mod
           ~/.cache/go-build

.github/codeql/codeql-configuration.yml

@@ -9,3 +9,6 @@ query-filters:
   # This query takes too long on complicated string manipulations
   - exclude:
       id: go/unsafe-quoting
+  # Times out in our code.
+  - exclude:
+      id: go/allocation-size-overflow

.github/workflows/ci.yml

@@ -247,14 +247,11 @@ jobs:
 
       - run: npx hereby generate
 
-      - run: node ./internal/lsp/lsproto/_generate/fetchModel.mjs
-      - run: node ./internal/lsp/lsproto/_generate/generate.mjs
+      - run: node --experimental-strip-types ./internal/lsp/lsproto/_generate/fetchModel.mts
+      - run: node --experimental-strip-types ./internal/lsp/lsproto/_generate/generate.mts
 
-      - name: Remove all converted fourslash tests
-        run: rm -rf internal/fourslash/tests/gen
-
-      - name: Regenerate fourslash tests
-        run: npm run convertfourslash
+      - name: Regenerate fourslash tests and update failing test list
+        run: npm run updatefailing
 
       - run: git add .
       - run: git diff --staged --exit-code --stat

.golangci.yml

@@ -78,6 +78,10 @@ linters:
         - -ST1022
 
   exclusions:
+    rules:
+      - path: internal/fourslash/tests/gen/
+        linters: misspell
+
     presets:
       - comments
       - std-error-handling