Merge branch 'main' into jabaile/symbol-tweaks

Author: jakebailey

.github/actions/setup-go/action.yml

@@ -14,7 +14,7 @@ runs:
   steps:
     - name: Install Go
       id: install-go
-      uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
+      uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5.5.0
       with:
         go-version: ${{ inputs.go-version }}
         cache: false

_build/azure-pipelines.compliance.yml

@@ -11,7 +11,7 @@ resources:
       ref: refs/tags/release
 
 extends:
-  template: v1/1ES.Unofficial.PipelineTemplate.yml@1esPipelines
+  template: v1/1ES.Official.PipelineTemplate.yml@1esPipelines
   parameters:
     pool:
       name: TypeScript-AzurePipelines-EO
@@ -24,7 +24,6 @@ extends:
         fetchDepth: 1
         fetchTags: false
         retryCount: 3
-      enableProductionSDL: true
       sourceAnalysisPool:
         name: TypeScript-AzurePipelines-EO
         image: 1ESPT-Windows2022

cmd/tsgo/lsp.go

@@ -1,10 +1,8 @@
 package main
 
 import (
-	"errors"
 	"flag"
 	"fmt"
-	"io"
 	"os"
 
 	"github.com/microsoft/typescript-go/internal/bundled"
@@ -49,7 +47,7 @@ func runLSP(args []string) int {
 		DefaultLibraryPath: defaultLibraryPath,
 	})
 
-	if err := s.Run(); err != nil && !errors.Is(err, io.EOF) {
+	if err := s.Run(); err != nil {
 		return 1
 	}
 	return 0

internal/ast/ast.go

@@ -1448,6 +1448,10 @@ func (n *Node) AsNotEmittedStatement() *NotEmittedStatement {
 	return n.data.(*NotEmittedStatement)
 }
 
+func (n *Node) AsNotEmittedTypeElement() *NotEmittedTypeElement {
+	return n.data.(*NotEmittedTypeElement)
+}
+
 func (n *Node) AsJSDoc() *JSDoc {
 	return n.data.(*JSDoc)
 }
@@ -4035,6 +4039,28 @@ func IsNotEmittedStatement(node *Node) bool {
 	return node.Kind == KindNotEmittedStatement
 }
 
+// NotEmittedTypeElement
+
+// Represents a type element that is elided as part of a transformation to emit comments on a
+// not-emitted node.
+type NotEmittedTypeElement struct {
+	NodeBase
+	TypeElementBase
+}
+
+func (f *NodeFactory) NewNotEmittedTypeElement() *Node {
+	data := &NotEmittedTypeElement{}
+	return newNode(KindNotEmittedTypeElement, data, f.hooks)
+}
+
+func (node *NotEmittedTypeElement) Clone(f NodeFactoryCoercible) *Node {
+	return cloneNode(f.AsNodeFactory().NewNotEmittedTypeElement(), node.AsNode(), f.AsNodeFactory().hooks)
+}
+
+func IsNotEmittedTypeElement(node *Node) bool {
+	return node.Kind == KindNotEmittedTypeElement
+}
+
 // ImportEqualsDeclaration
 
 type ImportEqualsDeclaration struct {
@@ -9925,7 +9951,7 @@ type SourceFile struct {
 	UsesUriStyleNodeCoreModules core.Tristate
 	Identifiers                 map[string]string
 	IdentifierCount             int
-	Imports                     []*LiteralLikeNode // []LiteralLikeNode
+	imports                     []*LiteralLikeNode // []LiteralLikeNode
 	ModuleAugmentations         []*ModuleName      // []ModuleName
 	AmbientModuleNames          []string
 	CommentDirectives           []CommentDirective
@@ -9996,6 +10022,14 @@ func (node *SourceFile) Path() tspath.Path {
 	return node.path
 }
 
+func (node *SourceFile) OriginalFileName() string {
+	return node.FileName() // !!! redirect source files
+}
+
+func (node *SourceFile) Imports() []*LiteralLikeNode {
+	return node.imports
+}
+
 func (node *SourceFile) Diagnostics() []*Diagnostic {
 	return node.diagnostics
 }
@@ -10036,6 +10070,10 @@ func (node *SourceFile) VisitEachChild(v *NodeVisitor) *Node {
 	return v.Factory.UpdateSourceFile(node, v.visitTopLevelStatements(node.Statements))
 }
 
+func (node *SourceFile) IsJS() bool {
+	return IsSourceFileJS(node)
+}
+
 func (node *SourceFile) copyFrom(other *SourceFile) {
 	// Do not copy fields set by NewSourceFile (Text, FileName, Path, or Statements)
 	node.LanguageVersion = other.LanguageVersion
@@ -10045,7 +10083,7 @@ func (node *SourceFile) copyFrom(other *SourceFile) {
 	node.HasNoDefaultLib = other.HasNoDefaultLib
 	node.UsesUriStyleNodeCoreModules = other.UsesUriStyleNodeCoreModules
 	node.Identifiers = other.Identifiers
-	node.Imports = other.Imports
+	node.imports = other.imports
 	node.ModuleAugmentations = other.ModuleAugmentations
 	node.AmbientModuleNames = other.AmbientModuleNames
 	node.CommentDirectives = other.CommentDirectives

internal/ast/diagnostic.go

@@ -19,6 +19,8 @@ type Diagnostic struct {
 	message            string
 	messageChain       []*Diagnostic
 	relatedInformation []*Diagnostic
+	reportsUnnecessary bool
+	reportsDeprecated  bool
 }
 
 func (d *Diagnostic) File() *SourceFile                 { return d.file }
@@ -31,6 +33,8 @@ func (d *Diagnostic) Category() diagnostics.Category    { return d.category }
 func (d *Diagnostic) Message() string                   { return d.message }
 func (d *Diagnostic) MessageChain() []*Diagnostic       { return d.messageChain }
 func (d *Diagnostic) RelatedInformation() []*Diagnostic { return d.relatedInformation }
+func (d *Diagnostic) ReportsUnnecessary() bool          { return d.reportsUnnecessary }
+func (d *Diagnostic) ReportsDeprecated() bool           { return d.reportsDeprecated }
 
 func (d *Diagnostic) SetFile(file *SourceFile)                  { d.file = file }
 func (d *Diagnostic) SetLocation(loc core.TextRange)            { d.loc = loc }
@@ -67,11 +71,13 @@ func (d *Diagnostic) Clone() *Diagnostic {
 
 func NewDiagnostic(file *SourceFile, loc core.TextRange, message *diagnostics.Message, args ...any) *Diagnostic {
 	return &Diagnostic{
-		file:     file,
-		loc:      loc,
-		code:     message.Code(),
-		category: message.Category(),
-		message:  message.Format(args...),
+		file:               file,
+		loc:                loc,
+		code:               message.Code(),
+		category:           message.Category(),
+		message:            message.Format(args...),
+		reportsUnnecessary: message.ReportsUnnecessary(),
+		reportsDeprecated:  message.ReportsDeprecated(),
 	}
 }
 

internal/ast/kind.go

@@ -387,6 +387,7 @@ const (
 	KindPartiallyEmittedExpression
 	KindCommaListExpression
 	KindSyntheticReferenceExpression
+	KindNotEmittedTypeElement
 	// Enum value count
 	KindCount
 	// Markers