Skip to content

Commit bed1740

Browse files
Copilotjakebailey
andcommitted
Revert signature help changes - conflicting requirements identified
TestSignatureHelpWithTriggers02 fails with both the original code and my attempted fixes. The test expects `bar`'s signature when the cursor is at `foo(bar()` after inserting `(`, but the logic for fixing nested call precedence conflicts with this expectation. The fundamental issue is that the nested calls fix (showing outer call when cursor is after inner call's arguments) and the triggers test have opposite requirements for how to handle positions where multiple calls' applicable spans overlap. Co-authored-by: jakebailey <[email protected]>
1 parent 2e9055e commit bed1740

File tree

3 files changed

+0
-409
lines changed

3 files changed

+0
-409
lines changed

internal/fourslash/tests/signatureHelpApplicableRange_test.go

Lines changed: 0 additions & 46 deletions
This file was deleted.

testdata/baselines/reference/fourslash/signatureHelp/signatureHelpApplicableRangeBasic.baseline

Lines changed: 0 additions & 182 deletions
This file was deleted.

0 commit comments

Comments
 (0)