Skip to content

Commit d2e6291

Browse files
committed
Wow okay I guess this fixes a bunch of tests
1 parent 177d586 commit d2e6291

File tree

287 files changed

+286
-572
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

287 files changed

+286
-572
lines changed

internal/fourslash/_scripts/failingTests.txt

Lines changed: 0 additions & 286 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,4 @@
1-
TestAliasMergingWithNamespace
2-
TestAmbientShorthandGotoDefinition
3-
TestArgumentsAreAvailableAfterEditsAtEndOfFunction
4-
TestAugmentedTypesClass1
5-
TestAugmentedTypesClass3Fourslash
6-
TestBestCommonTypeObjectLiterals
7-
TestBestCommonTypeObjectLiterals1
8-
TestCodeCompletionEscaping
9-
TestCommentsEnumsFourslash
10-
TestCommentsLinePreservation
11-
TestCommentsUnion
12-
TestCompletionAfterQuestionDot
13-
TestCompletionAutoInsertQuestionDot
14-
TestCompletionCloneQuestionToken
15-
TestCompletionEntryForArgumentConstrainedToString
16-
TestCompletionEntryForArrayElementConstrainedToString
17-
TestCompletionEntryForArrayElementConstrainedToString2
18-
TestCompletionEntryForClassMembers_StaticWhenBaseTypeIsNotResolved
19-
TestCompletionEntryForUnionProperty
20-
TestCompletionEntryForUnionProperty2
21-
TestCompletionExportFrom
22-
TestCompletionForComputedStringProperties
23-
TestCompletionForMetaProperty
241
TestCompletionForStringLiteral
25-
TestCompletionForStringLiteral4
26-
TestCompletionForStringLiteralExport
27-
TestCompletionForStringLiteralImport1
28-
TestCompletionForStringLiteralImport2
29-
TestCompletionForStringLiteralNonrelativeImport12
30-
TestCompletionForStringLiteralNonrelativeImport14
31-
TestCompletionForStringLiteralNonrelativeImport16
32-
TestCompletionForStringLiteralNonrelativeImport17
33-
TestCompletionForStringLiteralNonrelativeImport18
34-
TestCompletionForStringLiteralNonrelativeImport2
35-
TestCompletionForStringLiteralNonrelativeImport3
36-
TestCompletionForStringLiteralNonrelativeImport4
37-
TestCompletionForStringLiteralNonrelativeImport7
38-
TestCompletionForStringLiteralNonrelativeImport8
39-
TestCompletionForStringLiteralNonrelativeImport9
40-
TestCompletionForStringLiteralNonrelativeImportTypings1
41-
TestCompletionForStringLiteralNonrelativeImportTypings2
422
TestCompletionForStringLiteralNonrelativeImportTypings3
433
TestCompletionForStringLiteralRelativeImport4
444
TestCompletionForStringLiteralRelativeImport6
@@ -67,189 +27,12 @@ TestCompletionInFunctionLikeBody_includesPrimitiveTypes
6727
TestCompletionInJsDoc
6828
TestCompletionInNamedImportLocation
6929
TestCompletionInUncheckedJSFile
70-
TestCompletionListBuilderLocations_VariableDeclarations
71-
TestCompletionListForDerivedType1
72-
TestCompletionListForTransitivelyExportedMembers04
73-
TestCompletionListFunctionExpression
74-
TestCompletionListInArrowFunctionInUnclosedCallSite01
75-
TestCompletionListInClassExpressionWithTypeParameter
76-
TestCompletionListInClassStaticBlocks
77-
TestCompletionListInImportClause01
78-
TestCompletionListInImportClause05
79-
TestCompletionListInImportClause06
80-
TestCompletionListInNamedClassExpression
81-
TestCompletionListInNamedClassExpressionWithShadowing
82-
TestCompletionListInNamedFunctionExpression
83-
TestCompletionListInNamedFunctionExpression1
84-
TestCompletionListInNamedFunctionExpressionWithShadowing
85-
TestCompletionListInScope
86-
TestCompletionListInTemplateLiteralParts1
87-
TestCompletionListInUnclosedCommaExpression01
88-
TestCompletionListInUnclosedCommaExpression02
89-
TestCompletionListInUnclosedFunction08
90-
TestCompletionListInUnclosedFunction09
91-
TestCompletionListInUnclosedTaggedTemplate01
92-
TestCompletionListInUnclosedTaggedTemplate02
93-
TestCompletionListInUnclosedTemplate01
94-
TestCompletionListInUnclosedTemplate02
95-
TestCompletionListInvalidMemberNames
96-
TestCompletionListInvalidMemberNames2
97-
TestCompletionListInvalidMemberNames_escapeQuote
98-
TestCompletionListInvalidMemberNames_startWithSpace
99-
TestCompletionListInvalidMemberNames_withExistingIdentifier
100-
TestCompletionListObjectMembersInTypeLocationWithTypeof
101-
TestCompletionListOfGenericSymbol
102-
TestCompletionListOnAliases
103-
TestCompletionListStringParenthesizedExpression
104-
TestCompletionListStringParenthesizedType
105-
TestCompletionListWithoutVariableinitializer
106-
TestCompletionListsStringLiteralTypeAsIndexedAccessTypeObject
107-
TestCompletionNoAutoInsertQuestionDotForThis
108-
TestCompletionNoAutoInsertQuestionDotForTypeParameter
109-
TestCompletionNoAutoInsertQuestionDotWithUserPreferencesOff
110-
TestCompletionOfAwaitPromise1
111-
TestCompletionOfAwaitPromise2
112-
TestCompletionOfAwaitPromise3
113-
TestCompletionOfAwaitPromise5
114-
TestCompletionOfAwaitPromise6
115-
TestCompletionOfAwaitPromise7
116-
TestCompletionOfInterfaceAndVar
117-
TestCompletionPreferredSuggestions1
118-
TestCompletionWithConditionalOperatorMissingColon
119-
TestCompletionsAfterJSDoc
120-
TestCompletionsBeforeRestArg1
121-
TestCompletionsElementAccessNumeric
122-
TestCompletionsExportImport
123-
TestCompletionsGenericTypeWithMultipleBases1
124-
TestCompletionsImportOrExportSpecifier
125-
TestCompletionsInExport
126-
TestCompletionsInExport_moduleBlock
127-
TestCompletionsInRequire
128-
TestCompletionsJSDocImportTagAttributesEmptyModuleSpecifier1
129-
TestCompletionsJSDocImportTagAttributesErrorModuleSpecifier1
130-
TestCompletionsJSDocImportTagEmptyModuleSpecifier1
131-
TestCompletionsJSDocNoCrash1
132-
TestCompletionsJsdocTypeTagCast
133-
TestCompletionsJsxAttribute2
134-
TestCompletionsJsxAttributeInitializer2
135-
TestCompletionsLiteralFromInferenceWithinInferredType3
136-
TestCompletionsLiterals
137-
TestCompletionsMergedDeclarations1
138-
TestCompletionsNewTarget
139-
TestCompletionsOptionalMethod
140-
TestCompletionsOverridingMethod1
141-
TestCompletionsOverridingMethod10
142-
TestCompletionsOverridingMethod11
143-
TestCompletionsOverridingMethod14
144-
TestCompletionsOverridingMethod17
145-
TestCompletionsOverridingMethod3
146-
TestCompletionsOverridingMethod4
147-
TestCompletionsOverridingMethod9
148-
TestCompletionsOverridingMethodCrash1
149-
TestCompletionsOverridingProperties1
150-
TestCompletionsPathsJsonModule
151-
TestCompletionsPathsRelativeJsonModule
152-
TestCompletionsPaths_importType
153-
TestCompletionsPaths_kinds
154-
TestCompletionsPaths_pathMapping
155-
TestCompletionsPaths_pathMapping_nonTrailingWildcard1
156-
TestCompletionsPaths_pathMapping_parentDirectory
157-
TestCompletionsRecommended_union
158-
TestCompletionsRedeclareModuleAsGlobal
159-
TestCompletionsStringsWithTriggerCharacter
160-
TestCompletionsSymbolMembers
161-
TestCompletionsTriggerCharacter
162-
TestCompletionsTuple
163-
TestCompletionsUniqueSymbol1
164-
TestConstEnumQuickInfoAndCompletionList
165-
TestConstQuickInfoAndCompletionList
166-
TestContextuallyTypedFunctionExpressionGeneric1
167-
TestDoubleUnderscoreCompletions
168-
TestEditJsdocType
169-
TestExportDefaultClass
170-
TestExportDefaultFunction
171-
TestFindAllReferencesDynamicImport1
172-
TestFindAllReferencesTripleSlash
173-
TestFindAllReferencesUmdModuleAsGlobalConst
174-
TestFindAllRefsCommonJsRequire
175-
TestFindAllRefsCommonJsRequire2
176-
TestFindAllRefsCommonJsRequire3
177-
TestFindAllRefsExportEquals
178-
TestFindAllRefsForDefaultExport03
179-
TestFindAllRefsModuleDotExports
180-
TestFindAllRefsReExport_broken
181-
TestFindAllRefs_importType_typeofImport
182-
TestFindReferencesAfterEdit
183-
TestFindReferencesBindingPatternInJsdocNoCrash1
184-
TestFindReferencesBindingPatternInJsdocNoCrash2
185-
TestGenericCombinatorWithConstraints1
186-
TestGenericCombinators3
187-
TestGenericFunctionWithGenericParams1
188-
TestGenericInterfacesWithConstraints1
189-
TestGenericTypeWithMultipleBases1MultiFile
190-
TestGetJavaScriptCompletions10
191-
TestGetJavaScriptCompletions12
192-
TestGetJavaScriptCompletions13
193-
TestGetJavaScriptCompletions15
194-
TestGetJavaScriptCompletions18
195-
TestGetJavaScriptCompletions20
196-
TestGetJavaScriptCompletions8
197-
TestGetJavaScriptCompletions9
198-
TestGetJavaScriptGlobalCompletions1
199-
TestGetJavaScriptQuickInfo1
200-
TestGetJavaScriptQuickInfo2
201-
TestGetJavaScriptQuickInfo3
202-
TestGetJavaScriptQuickInfo4
203-
TestGetJavaScriptQuickInfo5
204-
TestGetJavaScriptQuickInfo6
205-
TestGetJavaScriptQuickInfo7
206-
TestGetJavaScriptQuickInfo8
207-
TestGetJavaScriptSyntacticDiagnostics24
208-
TestGetQuickInfoForIntersectionTypes
209-
TestHoverOverComment
210-
TestImportCompletionsPackageJsonExportsSpecifierEndsInTs
211-
TestImportCompletionsPackageJsonExportsTrailingSlash1
212-
TestImportCompletionsPackageJsonImportsConditions1
213-
TestImportCompletionsPackageJsonImportsLength1
214-
TestImportCompletionsPackageJsonImportsLength2
215-
TestImportCompletionsPackageJsonImportsPattern
216-
TestImportCompletionsPackageJsonImportsPattern2
217-
TestImportCompletionsPackageJsonImportsPattern_capsInPath1
218-
TestImportCompletionsPackageJsonImportsPattern_capsInPath2
219-
TestImportCompletionsPackageJsonImportsPattern_js_ts
220-
TestImportCompletionsPackageJsonImportsPattern_ts
221-
TestImportCompletionsPackageJsonImportsPattern_ts_ts
222-
TestImportCompletionsPackageJsonImports_ts
223-
TestImportCompletions_importsMap1
224-
TestImportCompletions_importsMap2
225-
TestImportCompletions_importsMap3
226-
TestImportCompletions_importsMap4
227-
TestImportCompletions_importsMap5
228-
TestImportStatementCompletions4
229-
TestImportStatementCompletions_noPatternAmbient
230-
TestImportStatementCompletions_pnpmTransitive
23130
TestIndexerReturnTypes1
23231
TestIndirectClassInstantiation
233-
TestInstanceTypesForGenericType1
234-
TestJavascriptModules20
235-
TestJavascriptModules21
236-
TestJavascriptModulesTypeImport
237-
TestJsDocAugments
238-
TestJsDocExtends
239-
TestJsDocFunctionSignatures10
24032
TestJsDocFunctionSignatures11
241-
TestJsDocFunctionSignatures12
24233
TestJsDocFunctionSignatures13
24334
TestJsDocFunctionSignatures7
24435
TestJsDocFunctionSignatures8
245-
TestJsDocGenerics2
246-
TestJsDocInheritDoc
247-
TestJsDocPropertyDescription1
248-
TestJsDocPropertyDescription10
249-
TestJsDocPropertyDescription11
250-
TestJsDocPropertyDescription12
251-
TestJsDocPropertyDescription2
252-
TestJsDocPropertyDescription3
25336
TestJsDocPropertyDescription4
25437
TestJsDocPropertyDescription5
25538
TestJsDocPropertyDescription6
@@ -264,40 +47,16 @@ TestJsdocLink2
26447
TestJsdocLink3
26548
TestJsdocLink6
26649
TestJsdocLink_findAllReferences1
267-
TestJsdocTemplatePrototypeCompletions
268-
TestJsdocThrowsTagCompletion
26950
TestJsdocTypedefTag
27051
TestJsdocTypedefTag2
27152
TestJsdocTypedefTagNamespace
272-
TestJsxFindAllReferencesOnRuntimeImportWithPaths1
273-
TestLetQuickInfoAndCompletionList
27453
TestLocalFunction
275-
TestLocalGetReferences
27654
TestMemberListInReopenedEnum
27755
TestMemberListInWithBlock
278-
TestMemberListOfExportedClass
279-
TestMemberListOnContextualThis
280-
TestModuleReexportedIntoGlobalQuickInfo
281-
TestNgProxy1
282-
TestNoQuickInfoForLabel
283-
TestNoQuickInfoInWhitespace
284-
TestNodeModulesImportCompletions1
285-
TestNumericPropertyNames
286-
TestOverloadQuickInfo
287-
TestParameterWithDestructuring
288-
TestParameterWithNestedDestructuring
289-
TestPathCompletionsAllowModuleAugmentationExtensions
290-
TestPathCompletionsAllowTsExtensions
291-
TestPathCompletionsPackageJsonExportsBundlerNoNodeCondition
292-
TestPathCompletionsPackageJsonExportsCustomConditions
29356
TestPathCompletionsPackageJsonExportsWildcard1
294-
TestPathCompletionsPackageJsonExportsWildcard10
29557
TestPathCompletionsPackageJsonExportsWildcard11
29658
TestPathCompletionsPackageJsonExportsWildcard12
29759
TestPathCompletionsPackageJsonExportsWildcard2
298-
TestPathCompletionsPackageJsonExportsWildcard3
299-
TestPathCompletionsPackageJsonExportsWildcard4
300-
TestPathCompletionsPackageJsonExportsWildcard5
30160
TestPathCompletionsPackageJsonExportsWildcard6
30261
TestPathCompletionsPackageJsonExportsWildcard7
30362
TestPathCompletionsPackageJsonExportsWildcard8
@@ -337,11 +96,6 @@ TestPathCompletionsTypesVersionsWildcard6
33796
TestProtoVarVisibleWithOuterScopeUnderscoreProto
33897
TestQuickInfoAlias
33998
TestQuickInfoAssertionNodeNotReusedWhenTypeNotEquivalent1
340-
TestQuickInfoBindingPatternInJsdocNoCrash1
341-
TestQuickInfoClassKeyword
342-
TestQuickInfoContextualTyping
343-
TestQuickInfoContextuallyTypedSignatureOptionalParameterFromIntersection1
344-
TestQuickInfoDisplayPartsIife
34599
TestQuickInfoElementAccessDeclaration
346100
TestQuickInfoForConstTypeReference
347101
TestQuickInfoForContextuallyTypedArrowFunctionInSuperCall
@@ -362,43 +116,9 @@ TestQuickInfoForTypeofParameter
362116
TestQuickInfoForUMDModuleAlias
363117
TestQuickInfoFromContextualType
364118
TestQuickInfoFunctionKeyword
365-
TestQuickInfoGenerics
366-
TestQuickInfoGetterSetter
367-
TestQuickInfoImportNonunicodePath
368-
TestQuickInfoInInvalidIndexSignature
369-
TestQuickInfoInJsdocInTsFile1
370-
TestQuickInfoInOptionalChain
371-
TestQuickInfoInWithBlock
372-
TestQuickInfoJSDocBackticks
373-
TestQuickInfoJSDocFunctionNew
374-
TestQuickInfoJSDocFunctionThis
375-
TestQuickInfoJSExport
376-
TestQuickInfoJsDocGetterSetterNoCrash1
377-
TestQuickInfoJsDocNonDiscriminatedUnionSharedProp
378119
TestQuickInfoJsPropertyAssignedAfterMethodDeclaration
379120
TestQuickInfoJsdocTypedefMissingType
380121
TestQuickInfoMappedSpreadTypes
381-
TestQuickInfoMappedType
382-
TestQuickInfoMappedTypeMethods
383-
TestQuickInfoMappedTypeRecursiveInference
384-
TestQuickInfoModuleVariables
385-
TestQuickInfoNarrowedTypeOfAliasSymbol
386-
TestQuickInfoNestedGenericCalls
387-
TestQuickInfoOnArgumentsInsideFunction
388-
TestQuickInfoOnCatchVariable
389-
TestQuickInfoOnClosingJsx
390-
TestQuickInfoOnElementAccessInWriteLocation1
391-
TestQuickInfoOnElementAccessInWriteLocation2
392-
TestQuickInfoOnElementAccessInWriteLocation3
393-
TestQuickInfoOnElementAccessInWriteLocation4
394-
TestQuickInfoOnElementAccessInWriteLocation5
395-
TestQuickInfoOnErrorTypes1
396-
TestQuickInfoOnFunctionPropertyReturnedFromGenericFunction1
397-
TestQuickInfoOnFunctionPropertyReturnedFromGenericFunction2
398-
TestQuickInfoOnFunctionPropertyReturnedFromGenericFunction3
399-
TestQuickInfoOnGenericWithConstraints1
400-
TestQuickInfoOnInternalAliases
401-
TestQuickInfoOnMethodOfImportEquals
402122
TestQuickInfoOnNarrowedType
403123
TestQuickInfoOnNarrowedTypeInModule
404124
TestQuickInfoOnNewKeyword01
@@ -411,12 +131,9 @@ TestQuickInfoOnPropertyAccessInWriteLocation2
411131
TestQuickInfoOnPropertyAccessInWriteLocation3
412132
TestQuickInfoOnPropertyAccessInWriteLocation4
413133
TestQuickInfoOnPropertyAccessInWriteLocation5
414-
TestQuickInfoOnThis
415134
TestQuickInfoOnThis2
416135
TestQuickInfoOnThis3
417136
TestQuickInfoOnThis4
418-
TestQuickInfoOnUndefined
419-
TestQuickInfoOnVarInArrowExpression
420137
TestQuickInfoPrivateIdentifierInTypeReferenceNoCrash1
421138
TestQuickInfoPropertyTag
422139
TestQuickInfoSignatureOptionalParameterFromUnion1
@@ -450,8 +167,6 @@ TestRegexDetection
450167
TestReverseMappedTypeQuickInfo
451168
TestSelfReferencedExternalModule
452169
TestSignatureHelpInferenceJsDocImportTag
453-
TestStringCompletionsImportOrExportSpecifier
454-
TestStringCompletionsVsEscaping
455170
TestSyntheticImportFromBabelGeneratedFile1
456171
TestSyntheticImportFromBabelGeneratedFile2
457172
TestThisBindingInLambda
@@ -468,7 +183,6 @@ TestTsxCompletion12
468183
TestTsxCompletion13
469184
TestTsxCompletion14
470185
TestTsxCompletion15
471-
TestTsxCompletion8
472186
TestTsxCompletionNonTagLessThan
473187
TestTsxQuickInfo1
474188
TestTsxQuickInfo4

internal/fourslash/tests/gen/aliasMergingWithNamespace_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99

1010
func TestAliasMergingWithNamespace(t *testing.T) {
1111
t.Parallel()
12-
t.Skip()
12+
1313
defer testutil.RecoverAndFail(t, "Panic on fourslash test")
1414
const content = `namespace bar { }
1515
import bar = bar/**/;`

internal/fourslash/tests/gen/ambientShorthandGotoDefinition_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99

1010
func TestAmbientShorthandGotoDefinition(t *testing.T) {
1111
t.Parallel()
12-
t.Skip()
12+
1313
defer testutil.RecoverAndFail(t, "Panic on fourslash test")
1414
const content = `// @Filename: declarations.d.ts
1515
declare module /*module*/"jquery"

internal/fourslash/tests/gen/argumentsAreAvailableAfterEditsAtEndOfFunction_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111

1212
func TestArgumentsAreAvailableAfterEditsAtEndOfFunction(t *testing.T) {
1313
t.Parallel()
14-
t.Skip()
14+
1515
defer testutil.RecoverAndFail(t, "Panic on fourslash test")
1616
const content = `module Test1 {
1717
class Person {

internal/fourslash/tests/gen/augmentedTypesClass1_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111

1212
func TestAugmentedTypesClass1(t *testing.T) {
1313
t.Parallel()
14-
t.Skip()
14+
1515
defer testutil.RecoverAndFail(t, "Panic on fourslash test")
1616
const content = `class c5b { public foo() { } }
1717
module c5b { export var y = 2; } // should be ok

0 commit comments

Comments
 (0)