Feedback

Author: sheetalkamat

internal/execute/build/orchestrator.go

@@ -294,8 +294,7 @@ func (o *Orchestrator) DoCycle() {
 }
 
 func (o *Orchestrator) buildOrClean() tsc.CommandLineResult {
-	build := !o.opts.Command.BuildOptions.Clean.IsTrue()
-	if build && o.opts.Command.BuildOptions.Verbose.IsTrue() {
+	if !o.opts.Command.BuildOptions.Clean.IsTrue() && o.opts.Command.BuildOptions.Verbose.IsTrue() {
 		o.createBuilderStatusReporter(nil)(ast.NewCompilerDiagnostic(
 			diagnostics.Projects_in_this_build_Colon_0,
 			strings.Join(core.Map(o.Order(), func(p string) string {
@@ -307,22 +306,12 @@ func (o *Orchestrator) buildOrClean() tsc.CommandLineResult {
 	if len(o.errors) == 0 {
 		buildResult.statistics.Projects = len(o.Order())
 		if o.opts.Command.CompilerOptions.SingleThreaded.IsTrue() {
-			for _, config := range o.Order() {
-				path := o.toPath(config)
-				task := o.getTask(path)
-				o.buildOrCleanProject(task, path, &buildResult)
-			}
+			o.singleThreadedBuildOrClean(&buildResult)
 		} else {
-			wg := core.NewWorkGroup(false)
-			o.tasks.Range(func(path tspath.Path, task *buildTask) bool {
-				wg.Queue(func() {
-					o.buildOrCleanProject(task, path, &buildResult)
-				})
-				return true
-			})
-			wg.RunAndWait()
+			o.multiThreadedBuildOrClean(&buildResult)
 		}
 	} else {
+		// Circularity errors prevent any project from being built
 		buildResult.result.Status = tsc.ExitStatusProjectReferenceCycle_OutputsSkipped
 		reportDiagnostic := o.createDiagnosticReporter(nil)
 		for _, err := range o.errors {
@@ -334,6 +323,27 @@ func (o *Orchestrator) buildOrClean() tsc.CommandLineResult {
 	return buildResult.result
 }
 
+func (o *Orchestrator) singleThreadedBuildOrClean(buildResult *orchestratorResult) {
+	// Go in the order since only one project can be built at a time so that random order isnt picked by work group creating deadlock
+	for _, config := range o.Order() {
+		path := o.toPath(config)
+		task := o.getTask(path)
+		o.buildOrCleanProject(task, path, buildResult)
+	}
+}
+
+func (o *Orchestrator) multiThreadedBuildOrClean(buildResult *orchestratorResult) {
+	// Spin off the threads with waiting on upstream to build before actual project build
+	wg := core.NewWorkGroup(false)
+	o.tasks.Range(func(path tspath.Path, task *buildTask) bool {
+		wg.Queue(func() {
+			o.buildOrCleanProject(task, path, buildResult)
+		})
+		return true
+	})
+	wg.RunAndWait()
+}
+
 func (o *Orchestrator) buildOrCleanProject(task *buildTask, path tspath.Path, buildResult *orchestratorResult) {
 	task.result = &taskResult{}
 	task.result.reportStatus = o.createBuilderStatusReporter(task)

internal/execute/incremental/emitfileshandler.go

@@ -314,6 +314,7 @@ func (h *emitFilesHandler) updateSnapshot() []*compiler.EmitResult {
 func emitFiles(ctx context.Context, program *Program, options compiler.EmitOptions, isForDtsErrors bool) *compiler.EmitResult {
 	emitHandler := &emitFilesHandler{ctx: ctx, program: program, isForDtsErrors: isForDtsErrors}
 
+	// Single file emit - do direct from program
 	if !isForDtsErrors && options.TargetSourceFile != nil {
 		result := program.program.Emit(ctx, emitHandler.getEmitOptions(options))
 		if ctx.Err() != nil {