Ensure libs are traced in guaranteed order

sheetalkamat · sheetalkamat · commit efd10bfcf108 · 2025-08-07T15:25:39.000-07:00
diff --git a/internal/compiler/fileloader.go b/internal/compiler/fileloader.go
@@ -206,7 +206,10 @@ func processAllProgramFiles(
 		}
 	}
 
-	loader.pathForLibFileResolutions.Range(func(key tspath.Path, value *libResolution) bool {
+	keys := slices.Collect(loader.pathForLibFileResolutions.Keys())
+	slices.Sort(keys)
+	for _, key := range keys {
+		value, _ := loader.pathForLibFileResolutions.Load(key)
 		resolvedModules[key] = module.ModeAwareCache[*module.ResolvedModule]{
 			module.ModeAwareCacheKey{Name: value.libraryName, Mode: core.ModuleKindCommonJS}: value.resolution,
 		}
@@ -216,8 +219,7 @@ func processAllProgramFiles(
 		for _, diag := range value.resolution.ResolutionDiagnostics {
 			fileLoadDiagnostics.Add(diag)
 		}
-		return true
-	})
+	}
 
 	return processedFiles{
 		resolver:                             loader.resolver,

Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,10 @@ func processAllProgramFiles(`
`206`	`206`	`}`
`207`	`207`	`}`
`208`	`208`
`209`		`- loader.pathForLibFileResolutions.Range(func(key tspath.Path, value *libResolution) bool {`
	`209`	`+ keys := slices.Collect(loader.pathForLibFileResolutions.Keys())`
	`210`	`+ slices.Sort(keys)`
	`211`	`+ for _, key := range keys {`
	`212`	`+ value, _ := loader.pathForLibFileResolutions.Load(key)`
`210`	`213`	`resolvedModules[key] = module.ModeAwareCache[*module.ResolvedModule]{`
`211`	`214`	`module.ModeAwareCacheKey{Name: value.libraryName, Mode: core.ModuleKindCommonJS}: value.resolution,`
`212`	`215`	`}`
`@@ -216,8 +219,7 @@ func processAllProgramFiles(`
`216`	`219`	`for _, diag := range value.resolution.ResolutionDiagnostics {`
`217`	`220`	`fileLoadDiagnostics.Add(diag)`
`218`	`221`	`}`
`219`		`- return true`
`220`		`- })`
	`222`	`+ }`
`221`	`223`
`222`	`224`	`return processedFiles{`
`223`	`225`	`resolver: loader.resolver,`