Skip to content

Broken assignability and quick info due to erroneously deferring keyof T since #51621Β #2186

@LukeAbby

Description

@LukeAbby

Note: This is a refiling of #61728 due to being closed due to being related to quick info display (see #62827).

Version & Regression Information

This changed in PR microsoft/TypeScript#51621

Playground Link

https://www.typescriptlang.org/play/?ts=5.8.3#code/C4TwDgpgBAQghgZwJYGMDCB7AdgEycJbOAGwB4AVAPigF4oBrCEDAMynKggA9gJcEocLCABQUKAH4owAE4BXCGKgAuKCxIIIAbhEjQkKJiwskAc1pQA3lBkQAVhBTA0xDJtWyFUAL4790cggEYFolIxNzbl5+K28lcSlLePEU2wcnFzcIVXhkdGw8AiIycLNKHRSUuMrVLAgANwgZHT1waAAle0dnV00LQOCAbQAiNO7MzWGAXR0AelmUgD0pRmY2UsiePhwBIRBJaXloVXViTSA

Code:

Poor quick info:

type BasicConditional<T> = keyof T extends any
  ? true
  : false;

type Config = { rejectClose: true };
type Test =
  Config extends {}
    ? {
        rejectClose: BasicConditional<Config>;
      }
    : never;

type RejectClose = Test["rejectClose"];
//   ^? keyof Config extends any ? true : false

Broken assignability (found by @Andarist, see microsoft/TypeScript#61728 (comment))

type BasicConditional<T> = keyof T extends infer R ? R : never;

type Config = { rejectClose: true };

type Test = Config extends {}
  ? {
      rejectClose: BasicConditional<Config>;
    }
  : never;

const test: Test["rejectClose"] = "rejectClose";
//    ^ Type 'string' is not assignable to type 'BasicConditional<Config>'.

const ok: BasicConditional<Config> = "rejectClose"; // No error

Actual behavior

RejectClose's quick info is keyof Config extends any ? true : false which is un-simplified and rather ugly. In addition in the second snippet const test: Test["rejectClose"] = "rejectClose"; fails.

Expected behavior

The quick info should look nice and const test: Test["rejectClose"] = "rejectClose"; should succeed.

See microsoft/TypeScript#61999 for a TS-JS based fix.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions