Fix translation error in binding of binary expressions #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the binding of binary expressions, specifically for comma expressions. The fix corrects how control flow is handled during the binding process by ensuring the proper operands are passed to flow binding functions.
Key changes:
- Corrected function arguments in comma expression binding to pass operands instead of the parent node
- Fixed type inference behavior for variables after comma expressions with type assertions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
internal/binder/binder.go |
Fixed arguments to maybeBindExpressionFlowIfCall to pass expr.Left and expr.Right instead of node |
testdata/baselines/reference/submodule/compiler/controlFlowCommaExpressionAssertionMultiple.types |
Updated baseline showing corrected type inference after comma expressions |
testdata/baselines/reference/submodule/compiler/controlFlowCommaExpressionAssertionMultiple.types.diff |
Removed diff file indicating the port now matches TypeScript behavior |
jakebailey
approved these changes
Sep 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1766.