[http-client-java]mgmt, fix unix time mock #9111
Conversation
microsoft-github-policy-service
bot
added
the
emitter:client:java
| $tspOptions += " --option ""@typespec/http-client-java.uuid-as-string=false""" | ||
| } elseif ($tspFile -match "tsp[\\/]arm-stream-style-serialization.tsp") { | ||
| # for mgmt, do not generate tests due to random mock values | ||
| $tspOptions += " --option ""@typespec/http-client-java.generate-tests=false""" |
There was a problem hiding this comment.
Generate mock tests to at least ensure compilation pass. Generated tests will be git-ignored and won't be checked-in.
|
No changes needing a change description found. |
|
You can try these changes here
|
XiaofeiCao
changed the title
XiaofeiCao
requested review from
anuchandy,
haolingdong-msft,
srnagar and
weidongxu-microsoft
as code owners
| private static ExampleNode defaultNode(IType clientType, IType wireType, Object exampleValue) { | ||
| ExampleNode node; | ||
| LiteralNode literalNode = new LiteralNode(clientType, exampleValue); | ||
| LiteralNode literalNode = new LiteralNode(clientType, wireType, exampleValue); |
There was a problem hiding this comment.
Instead of add a wireType, is it solvable by adding a case in public static String convertLiteralToClientValue(IType wireType, String literalInWireType) ?
I think it kind of convert the objectValue to clientValue (e.g. in this case, convert the epoch to datetime string).
There was a problem hiding this comment.
The bug maybe there?
The code maybe need to be this
literalValue = Instant.ofEpochSecond(Long.parseLong(Integer.parseInt(literalValue)).atOffset(ZoneOffset.UTC).toString()
There was a problem hiding this comment.
Yeah, we could do this. Though seems we still need wireType here. Any better ways to pass in the information?
Original code is:
Which is buggy.
3 participants
wireTypeinformation forLiteralNodein assertions, since it contains encoding information.