Apply suggestions from code review

StephenHodgson · web-flow · commit 1cff3ea46446 · 2019-04-23T13:10:12.000-07:00
diff --git a/UnitySetup/UnitySetup.psm1 b/UnitySetup/UnitySetup.psm1
@@ -55,7 +55,7 @@ class UnitySetupInstance {
             $modules = (Get-Content "$path\modules.json" -Raw) | ConvertFrom-Json
 
             foreach ( $module in $modules ) {
-                $match = $module.DownloadUrl -match "(\d+)\.(\d+)\.(\d+)([fpb])(\d+)" | Out-Null
+                $match = $module.DownloadUrl -match "(\d+)\.(\d+)\.(\d+)([fpab])(\d+)" | Out-Null
 
                 if ( $null -ne $match ) {
                     $this.Version = [UnityVersion]$match
@@ -73,7 +73,7 @@ class UnitySetupInstance {
             }
         }
 
-        if ( -not $this.Version ) {
+        if ( $this.Version -ne $null ) {
             throw "Failed to find a valid version identifier for installation at $path!";
         }
 

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ class UnitySetupInstance {`
`55`	`55`	`$modules = (Get-Content "$path\modules.json" -Raw) \| ConvertFrom-Json`
`56`	`56`
`57`	`57`	`foreach ( $module in $modules ) {`
`58`		`- $match = $module.DownloadUrl -match "(\d+)\.(\d+)\.(\d+)([fpb])(\d+)" \| Out-Null`
	`58`	`+ $match = $module.DownloadUrl -match "(\d+)\.(\d+)\.(\d+)([fpab])(\d+)" \| Out-Null`
`59`	`59`
`60`	`60`	`if ( $null -ne $match ) {`
`61`	`61`	`$this.Version = [UnityVersion]$match`
`@@ -73,7 +73,7 @@ class UnitySetupInstance {`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`
`76`		`- if ( -not $this.Version ) {`
	`76`	`+ if ( $this.Version -ne $null ) {`
`77`	`77`	`throw "Failed to find a valid version identifier for installation at $path!";`
`78`	`78`	`}`
`79`	`79`