Merges in latest from the remote to resolve merge issues.

Author: Ziugy

UnitySetup/UnitySetup.psm1

@@ -344,7 +344,6 @@ function Find-UnitySetupInstaller {
 #>
 function Install-UnitySetupInstance {
     [CmdletBinding()]
-    [System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingWriteHost', '', Scope = 'Function')]
     param(
         [parameter(ValueFromPipeline = $true)]
         [UnitySetupInstaller[]] $Installers,
@@ -405,35 +404,32 @@ function Install-UnitySetupInstance {
 
             Start-BitsTransfer -Source $downloadSource -Destination $downloadDest
         }
-
-        $spins = @('|', '/', '-', '\')
+       
         for ($i = 0; $i -lt $localInstallers.Length; $i++) {
             $installer = $localInstallers[$i]
             $destination = $localDestinations[$i]
 
             $startProcessArgs = @{
                 'FilePath' = $installer;
-                'ArgumentList' = @("/S", "/D=$($localDestinations[$i])");
+                'ArgumentList' = @("/S", "/D=$destination");
                 'PassThru' = $true;
             }
 
             if ($Verb) {
                 $startProcessArgs['Verb'] = $Verb
             }
-
-            $spinnerIndex = 0
+            
+            Write-Verbose "$(Get-Date): Installing $installer to $destination."
             $process = Start-Process @startProcessArgs
-            while (!$process.HasExited) {
-                Write-Host "`rInstalling $installer to $destination - $($spins[$spinnerIndex++ % $spins.Length])" -NoNewline
-                Start-Sleep -Milliseconds 100
-            }
+            if( $process ) {
+                $process.WaitForExit()
 
-            if ( $process.ExitCode -ne 0) {
-                Write-Host "`bFailed."
-                Write-Error "Installing $installer failed with exit code: $($process.ExitCode)"
-            }
-            else {
-                Write-Host "`bSucceeded."
+                if ( $process.ExitCode -ne 0) {
+                    Write-Error "$(Get-Date): Failed with exit code: $($process.ExitCode)"
+                }
+                else { 
+                    Write-Verbose "$(Get-Date): Succeeded."
+                }
             }
         }
     }
@@ -832,12 +828,18 @@ function Start-UnityEditor {
             # clone the shared args list
             $unityArgs = $sharedArgs | ForEach-Object { $_ }
             if ( $instanceArgs[$i] ) { $unityArgs += $instanceArgs[$i] }
+
             $setProcessArgs = @{
                 'FilePath' = $editor;
                 'PassThru' = $true;
                 'ErrorAction' = 'Stop';
+                'RedirectStandardOutput' = New-TemporaryFile;
+                'RedirectStandardError' = New-TemporaryFile;
             }
 
+            Write-Verbose "Redirecting standard output to $($setProcessArgs['RedirectStandardOutput'])"
+            Write-Verbose "Redirecting standard error to $($setProcessArgs['RedirectStandardError'])"
+
             if ($unityArgs -and $unityArgs.Length -gt 0) {
                 $setProcessArgs['ArgumentList'] = $unityArgs
             }