Merge pull request #80 from jwittner/fix/lintFailure

Change helper to better name

Author: derekfreed

UnitySetup/DSCResources/xUnitySetup/xUnitySetup.psm1

@@ -79,7 +79,7 @@ function Set-TargetResource {
             foreach ($version in $splitVersions) {
                 $findArgs = @{ 
                     'Version'    = $version
-                    'Components' = New-UnitySetupComponent -Components $Components 
+                    'Components' = ConvertTo-UnitySetupComponent $Components 
                 }
 
                 $installArgs = @{ 'Cache' = "$env:TEMP\.unitysetup" }
@@ -156,7 +156,7 @@ function Test-TargetResource {
     $result = $true
     switch ( $Ensure ) {
         'Present' {
-            $setupComponents = New-UnitySetupComponent -Components $Components
+            $setupComponents = ConvertTo-UnitySetupComponent $Components
             foreach ($version in $splitVersions) {
                 Write-Verbose "Starting test for $version"
                 $setupInstances = Get-UnitySetupInstance | Select-UnitySetupInstance -Version $version
@@ -170,7 +170,7 @@ function Test-TargetResource {
 
                 $availableComponents = ($setupInstances[0].Components -band $setupComponents)
                 if ($availableComponents -ne $setupComponents) { 
-                    $missingComponents = New-UnitySetupComponent ($setupComponents -bxor $availableComponents)
+                    $missingComponents = ConvertTo-UnitySetupComponent ($setupComponents -bxor $availableComponents)
                     Write-Verbose "Found $version missing $($missingComponents)"
                     $result = $false 
                     break

UnitySetup/UnitySetup.psd1

@@ -82,7 +82,7 @@
         'Select-UnitySetupInstance',
         'Uninstall-UnitySetupInstance',
         'Start-UnityEditor',
-        'New-UnitySetupComponent'
+        'ConvertTo-UnitySetupComponent'
     )
 
     # Cmdlets to export from this module, for best performance, do not use wildcards and do not delete the entry, use an empty array if there are no cmdlets to export.

UnitySetup/UnitySetup.psm1

@@ -158,17 +158,16 @@ class UnityVersion : System.IComparable {
 .PARAMETER Components
    What components would you like included?
 .EXAMPLE
-   New-UnitySetupComponent -Components Setup,Metro
+   ConvertTo-UnitySetupComponent Setup,Metro
 #>
-function New-UnitySetupComponent {
+function ConvertTo-UnitySetupComponent {
     [CmdletBinding()]
-    [System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseShouldProcessForStateChangingFunctions', '', Scope = 'Function')]
     param(
-        [parameter(Mandatory = $true)]
-        [UnitySetupComponent] $Components
+        [parameter(Mandatory = $true, Position = 0)]
+        [UnitySetupComponent] $Component
     )
 
-    $Components
+    $Component
 }
 
 <#