Skip to content

Commit f93ba15

Browse files
authored
[nrf-ble-driver] Remove possible conflicting files (#25900)
* Fix possible conflicting license file * version * update license * format * version * UWP can't handle drivers * version
1 parent a84a843 commit f93ba15

File tree

5 files changed

+44
-26
lines changed

5 files changed

+44
-26
lines changed

ports/nrf-ble-driver/portfile.cmake

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -19,34 +19,39 @@ vcpkg_from_github(
1919
# Ensure that git is found within CMakeLists.txt by appending vcpkg's git executable dirpath to $PATH.
2020
# Git should always be available as it is downloaded during the bootstrap phase.
2121
# Append instead of prepend to $PATH to honor the user's git executable as a general rule.
22-
find_program(GIT NAMES git git.cmd)
23-
get_filename_component(GIT_EXE_DIRPATH "${GIT}" DIRECTORY)
24-
set(ENV{PATH} "$ENV{PATH};${GIT_EXE_DIRPATH}")
25-
26-
vcpkg_configure_cmake(
27-
SOURCE_PATH ${SOURCE_PATH}
28-
PREFER_NINJA
29-
OPTIONS -DDISABLE_EXAMPLES= -DDISABLE_TESTS= -DNRF_BLE_DRIVER_VERSION=4.1.2 -DCONNECTIVITY_VERSION=4.1.2
22+
vcpkg_find_acquire_program(GIT)
23+
get_filename_component(GIT_EXE_PATH "${GIT}" DIRECTORY)
24+
vcpkg_add_to_path("${GIT_EXE_PATH}")
25+
26+
vcpkg_cmake_configure(
27+
SOURCE_PATH "${SOURCE_PATH}"
28+
OPTIONS
29+
-DDISABLE_EXAMPLES=ON
30+
-DDISABLE_TESTS=ON
31+
-DNRF_BLE_DRIVER_VERSION=4.1.2
32+
-DCONNECTIVITY_VERSION=4.1.2
33+
MAYBE_UNUSED_VARIABLES
34+
DISABLE_EXAMPLES
35+
DISABLE_TESTS
3036
)
3137

32-
vcpkg_install_cmake()
38+
vcpkg_cmake_install()
3339
vcpkg_copy_pdbs()
34-
vcpkg_fixup_cmake_targets()
40+
vcpkg_cmake_config_fixup()
3541

3642
# Copy hex files into shared folder for package
3743
foreach(HEX_DIR IN ITEMS "sd_api_v2" "sd_api_v3" "sd_api_v5" "sd_api_v6")
3844
set(TARGET_DIRECTORY "${CURRENT_PACKAGES_DIR}/share/${PORT}/hex/${HEX_DIR}")
39-
file(MAKE_DIRECTORY ${TARGET_DIRECTORY})
40-
file(INSTALL "${SOURCE_PATH}/hex/${HEX_DIR}" DESTINATION ${TARGET_DIRECTORY}/..)
45+
file(MAKE_DIRECTORY "${TARGET_DIRECTORY}")
46+
file(INSTALL "${SOURCE_PATH}/hex/${HEX_DIR}" DESTINATION "${TARGET_DIRECTORY}/..")
4147
endforeach()
4248

43-
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include)
44-
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/share)
45-
file(REMOVE ${CURRENT_PACKAGES_DIR}/debug/LICENSE)
46-
file(REMOVE ${CURRENT_PACKAGES_DIR}/LICENSE)
49+
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")
50+
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/share")
4751

48-
if(VCPKG_LIBRARY_LINKAGE STREQUAL static)
49-
file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/bin ${CURRENT_PACKAGES_DIR}/debug/bin)
52+
53+
if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
54+
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin")
5055
endif()
5156

52-
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)
57+
file(INSTALL "${SOURCE_PATH}/LICENSE" DESTINATION "${CURRENT_PACKAGES_DIR}/share/${PORT}" RENAME copyright)

ports/nrf-ble-driver/vcpkg.json

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,22 @@
11
{
22
"name": "nrf-ble-driver",
3-
"version-string": "4.1.2",
4-
"port-version": 1,
3+
"version": "4.1.2",
4+
"port-version": 2,
55
"description": "BLE driver is a library for Bluetooth Low Energy communication using Nordic Semiconductor development kits.",
6+
"homepage": "https://github.com/NordicSemiconductor/pc-ble-driver",
7+
"license": "BSD-3-Clause",
8+
"supports": "!uwp",
69
"dependencies": [
710
"asio",
8-
"catch2",
911
"cli11",
10-
"spdlog"
12+
"spdlog",
13+
{
14+
"name": "vcpkg-cmake",
15+
"host": true
16+
},
17+
{
18+
"name": "vcpkg-cmake-config",
19+
"host": true
20+
}
1121
]
1222
}

scripts/ci.baseline.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -698,8 +698,6 @@ nativefiledialog:x64-uwp=fail
698698
ngspice:x64-windows-static=fail
699699
nng:arm-uwp=fail
700700
nng:x64-uwp=fail
701-
nrf-ble-driver:arm-uwp=fail
702-
nrf-ble-driver:x64-uwp=fail
703701
numactl:arm64-windows=fail
704702
numactl:arm-uwp=fail
705703
numactl:x64-osx=fail

versions/baseline.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4966,7 +4966,7 @@
49664966
},
49674967
"nrf-ble-driver": {
49684968
"baseline": "4.1.2",
4969-
"port-version": 1
4969+
"port-version": 2
49704970
},
49714971
"nspr": {
49724972
"baseline": "4.33",

versions/n-/nrf-ble-driver.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
{
22
"versions": [
3+
{
4+
"git-tree": "82619c9f6f7860cb053b79c1091a39e0483b7d85",
5+
"version": "4.1.2",
6+
"port-version": 2
7+
},
38
{
49
"git-tree": "f0f55511374a869316d374399923f94dc25c4150",
510
"version-string": "4.1.2",

0 commit comments

Comments
 (0)