Merge pull request #1169 from microsoft/dropThreadingAnalyzers

Drop threading analyzers from package dependencies

Author: AArnott

Directory.Packages.props

@@ -6,7 +6,7 @@
     <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
     <MessagePackVersion>2.5.192</MessagePackVersion>
     <MicroBuildVersion>2.0.187</MicroBuildVersion>
-    <VisualStudioThreadingVersion>17.13.2</VisualStudioThreadingVersion>
+    <VisualStudioThreadingVersion>17.13.61</VisualStudioThreadingVersion>
     <CodeAnalysisAnalyzerVersion>3.11.0-beta1.24629.2</CodeAnalysisAnalyzerVersion>
   </PropertyGroup>
   <ItemGroup>
@@ -18,9 +18,10 @@
     <PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" />
     <PackageVersion Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" Version="$(CodeAnalysisAnalyzerVersion)" />
     <PackageVersion Include="Microsoft.VisualStudio.Threading.Analyzers" Version="$(VisualStudioThreadingVersion)" />
+    <PackageVersion Include="Microsoft.VisualStudio.Threading.Only" Version="$(VisualStudioThreadingVersion)" />
     <PackageVersion Include="Microsoft.VisualStudio.Threading" Version="$(VisualStudioThreadingVersion)" />
     <PackageVersion Include="Microsoft.VisualStudio.Validation" Version="17.8.8" />
-    <PackageVersion Include="Nerdbank.Streams" Version="2.11.79" />
+    <PackageVersion Include="Nerdbank.Streams" Version="2.11.90" />
     <PackageVersion Include="Newtonsoft.Json" Version="13.0.3" />
     <PackageVersion Include="System.Collections.Immutable" Version="8.0.0" />
     <PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="8.0.1" />

src/StreamJsonRpc/StreamJsonRpc.csproj

@@ -15,7 +15,8 @@
   <ItemGroup>
     <PackageReference Include="MessagePack" />
     <PackageReference Include="MessagePackAnalyzer" PrivateAssets="all" />
-    <PackageReference Include="Microsoft.VisualStudio.Threading" />
+    <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" PrivateAssets="all"/>
+    <PackageReference Include="Microsoft.VisualStudio.Threading.Only" />
     <PackageReference Include="Nerdbank.Streams" />
     <PackageReference Include="Newtonsoft.Json" />
     <PackageReference Include="Microsoft.CodeAnalysis.PublicApiAnalyzers" PrivateAssets="all" />

test/StreamJsonRpc.Tests/DuplexPipeMarshalingTests.cs

@@ -644,12 +644,14 @@ public async Task StreamClosesDeterministically()
             writing = true;
             this.Logger.WriteLine("Writing {0} bytes.", e.Length);
         };
+#pragma warning disable CS0618 // Type or member is obsolete
         monitoredStream.DidWrite += (s, e) =>
         {
             Assert.True(writing);
             writing = false;
             this.Logger.WriteLine("Wrote {0} bytes.", e.Count);
         };
+#pragma warning restore CS0618 // Type or member is obsolete
         monitoredStream.DidWriteByte += (s, e) =>
         {
             Assert.True(writing);