Merge pull request #1016 from AArnott/cleanup

Code cleanup

Author: AArnott

Directory.Packages.props

@@ -45,6 +45,7 @@
     <GlobalPackageReference Include="CSharpIsNullAnalyzer" Version="0.1.495" />
     <GlobalPackageReference Include="DotNetAnalyzers.DocumentationAnalyzers" Version="1.0.0-beta.59" />
     <GlobalPackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.4" />
+    <GlobalPackageReference Include="Microsoft.CodeAnalysis.ResxSourceGenerator" Version="3.11.0-beta1.24122.1" />
     <GlobalPackageReference Include="Microsoft.VisualStudio.Internal.MicroBuild.VisualStudio" Version="$(MicroBuildVersion)" />
     <GlobalPackageReference Include="Nerdbank.GitVersioning" Version="3.6.133" />
     <GlobalPackageReference Include="Nullable" Version="1.3.1" />

src/StreamJsonRpc/AwaitExtensions.cs

@@ -23,8 +23,6 @@ internal static SynchronizationContextAwaiter GetAwaiter(this SynchronizationCon
         return new SynchronizationContextAwaiter(synchronizationContext);
     }
 
-#pragma warning disable CA1822 // Mark members as static
-
     /// <summary>
     /// The awaiter for <see cref="SynchronizationContext"/>.
     /// </summary>
@@ -74,5 +72,4 @@ public void OnCompleted(Action continuation)
 #pragma warning restore VSTHRD001 // Avoid legacy threading switching APIs
         }
     }
-#pragma warning restore CA1822 // Mark members as static
 }

src/StreamJsonRpc/CommonMethodNameTransforms.cs

@@ -20,9 +20,7 @@ public static Func<string, string> CamelCase
             {
                 if (name is null)
                 {
-#pragma warning disable CA1065 // Do not raise exceptions in unexpected locations
                     throw new ArgumentNullException();
-#pragma warning restore CA1065 // Do not raise exceptions in unexpected locations
                 }
 
                 return Utilities.ToCamelCase(name);

src/StreamJsonRpc/Exceptions/BadRpcHeaderException.cs

@@ -8,9 +8,7 @@ namespace StreamJsonRpc;
 /// </summary>
 /// <seealso cref="RemoteRpcException" />
 [Serializable]
-#pragma warning disable CA1032 // Implement standard exception constructors
 public class BadRpcHeaderException : RemoteRpcException
-#pragma warning restore CA1032 // Implement standard exception constructors
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="BadRpcHeaderException"/> class.

src/StreamJsonRpc/Exceptions/RemoteInvocationException.cs

@@ -14,9 +14,7 @@ namespace StreamJsonRpc;
 /// The details of the target method exception can be found on the <see cref="ErrorCode"/> and <see cref="ErrorData"/> properties.
 /// </remarks>
 [Serializable]
-#pragma warning disable CA1032 // Implement standard exception constructors
 public class RemoteInvocationException : RemoteRpcException
-#pragma warning restore CA1032 // Implement standard exception constructors
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="RemoteInvocationException"/> class.

src/StreamJsonRpc/Exceptions/RemoteMethodNotFoundException.cs

@@ -15,9 +15,7 @@ namespace StreamJsonRpc;
 /// its arguments were incompatible with the arguments supplied by the client.
 /// </remarks>
 [Serializable]
-#pragma warning disable CA1032 // Implement standard exception constructors
 public class RemoteMethodNotFoundException : RemoteRpcException
-#pragma warning restore CA1032 // Implement standard exception constructors
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="RemoteMethodNotFoundException"/> class

src/StreamJsonRpc/Exceptions/RemoteRpcException.cs

@@ -11,9 +11,7 @@ namespace StreamJsonRpc;
 /// Base exception class for any exception that happens while receiving an JSON-RPC communication.
 /// </summary>
 [System.Serializable]
-#pragma warning disable CA1032 // Implement standard exception constructors
 public abstract class RemoteRpcException : Exception
-#pragma warning restore CA1032 // Implement standard exception constructors
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="RemoteRpcException"/> class.

src/StreamJsonRpc/Exceptions/RemoteSerializationException.cs

@@ -12,9 +12,7 @@ namespace StreamJsonRpc;
 /// This exception comes from the <see cref="JsonRpcErrorCode.ResponseSerializationFailure"/> error code.
 /// </remarks>
 [Serializable]
-#pragma warning disable CA1032 // Implement standard exception constructors
 public class RemoteSerializationException : RemoteRpcException
-#pragma warning restore CA1032 // Implement standard exception constructors
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="RemoteSerializationException"/> class.

src/StreamJsonRpc/Exceptions/RpcArgumentDeserializationException.cs

@@ -12,9 +12,7 @@ namespace StreamJsonRpc;
 /// when the argument cannot be deserialized to the requested type, typically due to an incompatibility or exception thrown from the deserializer.
 /// </summary>
 [Serializable]
-#pragma warning disable CA1032 // Implement standard exception constructors
 public class RpcArgumentDeserializationException : RemoteRpcException
-#pragma warning restore CA1032 // Implement standard exception constructors
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="RpcArgumentDeserializationException"/> class.

src/StreamJsonRpc/Exceptions/UnexpectedEmptyEnumerableResponseException.cs

@@ -3,9 +3,7 @@
 
 namespace StreamJsonRpc;
 
-#pragma warning disable CA1032 // Implement standard exception constructors
 internal class UnexpectedEmptyEnumerableResponseException : RemoteRpcException
-#pragma warning restore CA1032 // Implement standard exception constructors
 {
     /// <summary>
     /// Initializes a new instance of the <see cref="UnexpectedEmptyEnumerableResponseException"/> class.