Skip to content

Commit 0563f5a

Browse files
author
Lifeng Lu
committed
Delete unused method
The original version of the unit test uses weak-reference, which turns out to be unnecessary.
1 parent 294add8 commit 0563f5a

File tree

1 file changed

+0
-42
lines changed

1 file changed

+0
-42
lines changed

test/Microsoft.VisualStudio.Threading.Tests/JoinableTaskTests.cs

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -4239,48 +4239,6 @@ await this.context.Factory.RunAsync(() =>
42394239
return task2;
42404240
}
42414241

4242-
[MethodImpl(MethodImplOptions.NoInlining)] // We need locals to surely be popped off the stack for a reliable test
4243-
private async Task<(Task SpinOffTask, WeakReference WeakJoinableTask)> SpinOffMainThreadTaskForJoinableTaskDependenciesHandledAfterTaskCompletionInnerTask(
4244-
JoinableTaskFactory joinableTaskFactory,
4245-
JoinableTaskCollection joinableTaskCollection)
4246-
{
4247-
var unblockTask1 = new AsyncManualResetEvent();
4248-
var spinOffIsReady = new AsyncManualResetEvent();
4249-
var spinOffIsDone = new AsyncManualResetEvent();
4250-
Task? spinOffTask = null;
4251-
4252-
JoinableTask joinableTask = joinableTaskFactory.RunAsync(async () =>
4253-
{
4254-
spinOffTask = Task.Run(async () =>
4255-
{
4256-
JoinableTaskFactory.MainThreadAwaiter awaiter = this.context.Factory.SwitchToMainThreadAsync().GetAwaiter();
4257-
awaiter.OnCompleted(() =>
4258-
{
4259-
spinOffIsDone.Set();
4260-
});
4261-
4262-
spinOffIsReady.Set();
4263-
4264-
await spinOffIsDone.WaitAsync();
4265-
4266-
// Add loop dependency
4267-
joinableTaskCollection.Join();
4268-
});
4269-
4270-
await spinOffIsReady.WaitAsync();
4271-
await unblockTask1.WaitAsync();
4272-
});
4273-
4274-
// Increase refcount
4275-
joinableTaskCollection.Add(joinableTask);
4276-
4277-
unblockTask1.Set();
4278-
4279-
await joinableTask.Task;
4280-
4281-
return (spinOffTask!, new WeakReference(joinableTask.Task));
4282-
}
4283-
42844242
private async Task SomeOperationThatMayBeOnMainThreadAsync()
42854243
{
42864244
await Task.Yield();

0 commit comments

Comments
 (0)