Skip to content

Commit 156d9eb

Browse files
CopilotAArnott
andcommitted
Address PR feedback: SDK version to 9.0.300, remove JTF test, clean up mock file
Co-authored-by: AArnott <[email protected]>
1 parent b2f644e commit 156d9eb

File tree

3 files changed

+2
-22
lines changed

3 files changed

+2
-22
lines changed

global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"sdk": {
3-
"version": "8.0.116",
3+
"version": "9.0.300",
44
"rollForward": "patch",
55
"allowPrerelease": false
66
},
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,2 @@
11
# Test exclusions for VSTHRD103 analyzer
2-
[System.Data.SqlClient.SqlDataReader]::Read
3-
[TestNamespace.TestClass]::SlowSyncMethod
4-
[Microsoft.VisualStudio.Threading.JoinableTaskFactory]::Run
2+
[TestNamespace.TestClass]::SlowSyncMethod

test/Microsoft.VisualStudio.Threading.Analyzers.Tests/VSTHRD103UseAsyncOptionAnalyzerTests.cs

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1386,24 +1386,6 @@ public static void NotExcludedMethod() { }
13861386
await CSVerify.VerifyAnalyzerAsync(test);
13871387
}
13881388

1389-
[Fact]
1390-
public async Task JTFRun_ExcludedViaAdditionalFiles_GeneratesNoWarning()
1391-
{
1392-
var test = @"
1393-
using System.Threading.Tasks;
1394-
using Microsoft.VisualStudio.Threading;
1395-
1396-
class Test {
1397-
async Task T() {
1398-
JoinableTaskFactory jtf = null;
1399-
jtf.Run(() => Task.CompletedTask);
1400-
}
1401-
}
1402-
";
1403-
1404-
// No diagnostic expected because JoinableTaskFactory.Run is excluded via AdditionalFiles
1405-
await CSVerify.VerifyAnalyzerAsync(test);
1406-
}
14071389

14081390
private DiagnosticResult CreateDiagnostic(int line, int column, int length, string methodName)
14091391
=> CSVerify.Diagnostic(DescriptorNoAlternativeMethod).WithSpan(line, column, line, column + length).WithArguments(methodName);

0 commit comments

Comments
 (0)