Merge pull request #778 from microsoft/dev/lifengl/reuseWeakRef

lifengl · web-flow · commit c79ca8300b2f · 2021-02-22T13:22:37.000-08:00
Minor: reuse existing WeakReference of the JoinableTask
diff --git a/src/Microsoft.VisualStudio.Threading/JoinableTask.cs b/src/Microsoft.VisualStudio.Threading/JoinableTask.cs
@@ -1014,7 +1014,7 @@ internal int GetPendingEventCountForSynchronousTask(JoinableTask synchronousTask
 
             if (this.pendingEventSource is null || taskHasPendingMessages == this)
             {
-                this.pendingEventSource = new WeakReference<JoinableTask>(taskHasPendingMessages);
+                this.pendingEventSource = taskHasPendingMessages.WeakSelf;
             }
 
             this.pendingEventCount += newPendingMessagesCount;

Original file line number	Diff line number	Diff line change
`@@ -1014,7 +1014,7 @@ internal int GetPendingEventCountForSynchronousTask(JoinableTask synchronousTask`
`1014`	`1014`
`1015`	`1015`	`if (this.pendingEventSource is null \|\| taskHasPendingMessages == this)`
`1016`	`1016`	`{`
`1017`		`- this.pendingEventSource = new WeakReference<JoinableTask>(taskHasPendingMessages);`
	`1017`	`+ this.pendingEventSource = taskHasPendingMessages.WeakSelf;`
`1018`	`1018`	`}`
`1019`	`1019`
`1020`	`1020`	`this.pendingEventCount += newPendingMessagesCount;`