Skip to content

Commit 46114df

Browse files
authored
Merge pull request #303 from AArnott/optprof_fixes
Add OptProf.targets and comments to help onboarding
2 parents 3427406 + 1d50f65 commit 46114df

File tree

3 files changed

+23
-1
lines changed

3 files changed

+23
-1
lines changed

azure-pipelines/build.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ parameters:
44
##### Feel free to adjust their default value as needed.
55

66
# Whether this repo uses OptProf to optimize the built binaries.
7+
# When enabling this, be sure to update these files:
8+
# - OptProf.targets: InstallationPath and match TestCase selection with what's in the VS repo.
9+
# - The project file(s) for the libraries to optimize must import OptProf.targets (for multi-targeted projects, only import it for ONE target).
10+
# - OptProf.yml: Search for LibraryName (or your library's name) and verify that those names are appropriate.
11+
# - OptProf_part2.yml: Search for LibraryName (or your library's name) and verify that those names are appropriate.
12+
# and create pipelines for OptProf.yml, OptProf_part2.yml
713
- name: EnableOptProf
814
type: boolean
915
default: false

azure-pipelines/microbuild.after.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ steps:
2929
usePat: true
3030
displayName: 📢 Publish to Artifact Services - ProfilingInputs
3131
condition: and(succeeded(), ne(variables['Build.Reason'], 'PullRequest'))
32-
continueOnError: true
3332

3433
- task: PublishBuildArtifacts@1
3534
inputs:

src/OptProf.targets

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
<Project>
2+
<ItemGroup>
3+
<OptProf Include="$(TargetPath)">
4+
<Technology>IBC</Technology>
5+
<InstallationPath>Common7\IDE\PrivateAssemblies\$(TargetFileName)</InstallationPath>
6+
<InstrumentationArguments>/ExeConfig:"%VisualStudio.InstallationUnderTest.Path%\Common7\IDE\vsn.exe"</InstrumentationArguments>
7+
<Scenarios>
8+
<TestContainer Name="VSPE" Repository="VS">
9+
<!-- When adding to this list, be sure to also add to VS repo too (e.g. https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/196226) -->
10+
<TestCase FullyQualifiedName="VSPE.OptProfTests.vs_env_startup_devenv" />
11+
<TestCase FullyQualifiedName="VSPE.OptProfTests.vs_perf_DesignTime_solution_loadclose_cs_picasso" />
12+
<TestCase FullyQualifiedName="VSPE.OptProfTests.vs_ddbvtqa_vbwin" />
13+
</TestContainer>
14+
</Scenarios>
15+
</OptProf>
16+
</ItemGroup>
17+
</Project>

0 commit comments

Comments
 (0)