Skip to content
This repository was archived by the owner on Oct 1, 2024. It is now read-only.

Commit 4e753e6

Browse files
committed
suppress sending telemetry of error details
1 parent 21ad8ca commit 4e753e6

File tree

3 files changed

+74
-20
lines changed

3 files changed

+74
-20
lines changed

package-lock.json

Lines changed: 67 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -583,7 +583,7 @@
583583
"node-usb-native": "^0.0.13",
584584
"properties": "^1.2.1",
585585
"uuid": "^3.0.1",
586-
"vscode-extension-telemetry": "0.0.18",
586+
"vscode-extension-telemetry": "0.1.6",
587587
"winreg": "^1.2.3",
588588
"winston": "^2.3.1"
589589
}

src/logger/telemetry-transport.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class TelemetryTransport extends winston.Transport {
3939
winston.error("Failed to initialize telemetry due to no aiKey in package.json.");
4040
return;
4141
}
42-
this.reporter = new TelemetryReporter(packageInfo.name, packageInfo.version, packageInfo.aiKey);
42+
this.reporter = new TelemetryReporter(packageInfo.name, packageInfo.version, packageInfo.aiKey, true);
4343
}
4444

4545
protected log(level: string, message: string, metadata?: any, callback?: (arg1, arg2) => void) {
@@ -60,7 +60,11 @@ export class TelemetryTransport extends winston.Transport {
6060
}
6161
}
6262
}
63-
this.reporter.sendTelemetryEvent(message, properties, measures);
63+
if (level === "info") {
64+
this.reporter.sendTelemetryEvent(message, properties, measures);
65+
} else {
66+
this.reporter.sendTelemetryErrorEvent(message, properties, measures, ["message", "notification", "errorLine"]);
67+
}
6468
} catch (telemetryErr) {
6569
// If sending telemetry event fails ignore it so it won"t break the extension
6670
winston.error("Failed to send telemetry event. error: " + telemetryErr);

0 commit comments

Comments
 (0)