add dispose calls

Author: gcampbell-msft

src/serialmonitor/outputBuffer.ts

@@ -5,15 +5,13 @@ import * as vscode from "vscode";
 import { performance } from "perf_hooks";
 
 export class BufferedOutputChannel implements vscode.Disposable {
-    private TIMING_BUFFER: number = 300;
-
     private _buffer: string[];
     private timer:  NodeJS.Timer;
     private _lastFlushTime: number;
 
-    public constructor(private outputCallback: (value: string) => void) {
+    public constructor(private outputCallback: (value: string) => void, private flushIntervalMs: number) {
         this._buffer = [];
-        this.timer = setInterval(() => this.tryFlush(), this.TIMING_BUFFER);
+        this.timer = setInterval(() => this.tryFlush(), this.flushIntervalMs);
         this._lastFlushTime = Number.NEGATIVE_INFINITY;
     }
 
@@ -24,7 +22,7 @@ export class BufferedOutputChannel implements vscode.Disposable {
 
     private tryFlush() {
         const currentTime = performance.now();
-        if (this._buffer && this._buffer.length > 0 && currentTime-this._lastFlushTime > this.TIMING_BUFFER) {
+        if (this._buffer.length > 0 && currentTime-this._lastFlushTime > this.flushIntervalMs) {
             this.outputCallback(this._buffer.join(''));
             this._lastFlushTime = currentTime;
             this._buffer = [];

src/serialmonitor/serialMonitor.ts

@@ -60,7 +60,7 @@ export class SerialMonitor implements vscode.Disposable {
             defaultBaudRate = SerialMonitor.DEFAULT_BAUD_RATE;
         }
         this._outputChannel = vscode.window.createOutputChannel(SerialMonitor.SERIAL_MONITOR);
-        this._bufferedOutputChannel = new BufferedOutputChannel(this._outputChannel.append);
+        this._bufferedOutputChannel = new BufferedOutputChannel(this._outputChannel.append, 300);
         this._currentBaudRate = defaultBaudRate;
         this._portsStatusBar = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Right, constants.statusBarPriority.PORT);
         this._portsStatusBar.command = "arduino.selectSerialPort";
@@ -85,13 +85,15 @@ export class SerialMonitor implements vscode.Disposable {
         });
     }
     public get initialized(): boolean {
-        return !!this._bufferedOutputChannel;
+        return !!this._outputChannel;
     }
 
     public dispose() {
         if (this._serialPortCtrl && this._serialPortCtrl.isActive) {
             return this._serialPortCtrl.stop();
         }
+        this._outputChannel.dispose();
+        this._bufferedOutputChannel.dispose();
     }
 
     public async selectSerialPort(vid: string, pid: string) {