Hide status bar item by default (#1020)

Author: alexweininger

package.json

@@ -102,6 +102,11 @@
             "type": "object",
             "title": "Azure configuration",
             "properties": {
+                "azure.azure-account.showStatusBar": {
+                    "type": "boolean",
+                    "default": false,
+                    "description": "Whether to show the Azure Account status bar item. For use with extensions that aren't updated to use the new built in authentication APIs."
+                },
                 "azure.resourceFilter": {
                     "type": "array",
                     "default": null,

src/extension.ts

@@ -120,6 +120,13 @@ function createStatusBarItem(context: ExtensionContext, api: AzureAccountExtensi
 	statusBarItem.name = localize('azure-account.status', 'Azure Account Status');
 	statusBarItem.command = "azure-account.manageAccount";
 	function updateStatusBar() {
+		// Since Azure Account is deprecated, we only show the status bar item when the user has explicitly enabled it
+		const showStatusBar = getSettingValue<boolean>('azure-account.showStatusBar');
+		if (!showStatusBar) {
+			statusBarItem.hide();
+			return;
+		}
+
 		switch (api.status) {
 			case 'LoggingIn':
 				statusBarItem.text = localize('azure-account.loggingIn', "Azure: Signing in...");