Fix create and deploy tests (#4369)

* CHANGELOG and bump version

* Make fixes for flex being the basic create exp.

* Point to our shared template

* Add additionalStep to right parameters

* Use whatever alias for python, not just 3.9

* Some more test fixes

* ffffff

* Shorten app name in testing

* Must start with an alphabet

* Install .NET 9

* Remove staging location

* Convert paths to linux

* Some fixup/cleanup

* Add link to issue

Author: nturinski

.azure-pipelines/1esmain.yml

@@ -49,7 +49,7 @@ extends:
   parameters:
     sdl:
       credscan:
-        suppressionsFile: $(Build.SourcesDirectory)\.azure-pipelines\compliance\CredScanSuppressions.json
+        suppressionsFile: $(Build.SourcesDirectory)/.azure-pipelines/compliance/CredScanSuppressions.json
       codeql:
         language: javascript # only build a codeql database for javascript, since the jsoncli pipeline handles csharp
       #   enabled: true # TODO: would like to enable only on scheduled builds but CodeQL cannot currently be disabled per https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/codeql/1es-codeql
@@ -62,3 +62,10 @@ extends:
       - template: azure-pipelines/1esstages.yml@azExtTemplates
         parameters:
           useAzureFederatedCredentials: ${{ parameters.enableLongRunningTests }}
+          additionalSetupSteps:
+          - script: |
+              wget https://dot.net/v1/dotnet-install.sh -O dotnet-install.sh
+              chmod +x ./dotnet-install.sh
+              ./dotnet-install.sh --channel 9.0
+            displayName: Install .NET 9.0
+            name: Install_dotnet

.azure-pipelines/compliance/CredScanSuppressions.json

@@ -18,7 +18,7 @@
             "_justification": "This is a false positive"
         },
         {
-            "folder": "\\resources\\backupTemplates",
+            "folder": "/resources/backupTemplates",
             "_justification": "folder to be suppressed because the templates contain lots of fake passwords and secrets"
         }
     ]

extension.bundle.ts

@@ -27,8 +27,8 @@ export * from './src/commands/deleteFunctionApp';
 export * from './src/commands/deploy/deploy';
 export * from './src/commands/deploy/verifyAppSettings';
 export * from './src/commands/initProjectForVSCode/initProjectForVSCode';
-export * from './src/utils/durableUtils';
 export * from './src/constants';
+export * from './src/utils/durableUtils';
 // Export activate/deactivate for main.js
 export { activateInternal, deactivateInternal } from './src/extension';
 export * from './src/extensionVariables';

package-lock.json

@@ -2,7 +2,7 @@
     "name": "vscode-azurefunctions",
     "displayName": "Azure Functions",
     "description": "%azureFunctions.description%",
-    "version": "1.16.2-alpha.0",
+    "version": "1.16.2-alpha",
     "publisher": "ms-azuretools",
     "icon": "resources/azure-functions.png",
     "aiKey": "0c6ae279ed8443289764825290e4f9e2-1a736e7c-1324-4338-be46-fc2a58ae4d14-7255",

package.json

@@ -64,6 +64,11 @@ export function getRandomHexString(length: number = 10): string {
     return buffer.toString('hex').slice(0, length);
 }
 
+export function getRandomAlphanumericString(): string {
+    // toString(36) to convert it into base 36 (26 char + 0 to 9) and slice(2) to remove the '0.'
+    return Math.random().toString(36).slice(2);
+}
+
 export function isPathEqual(fsPath1: string, fsPath2: string, relativeFunc: pathRelativeFunc = path.relative): boolean {
     const relativePath: string = relativeFunc(fsPath1, fsPath2);
     return relativePath === '';

src/utils/fs.ts

@@ -5,12 +5,12 @@
 
 import { type ServiceClient } from '@azure/core-client';
 import { createPipelineRequest } from '@azure/core-rest-pipeline';
-import { createTestActionContext, runWithTestActionContext, type TestInput } from '@microsoft/vscode-azext-dev';
+import { TestInput, createTestActionContext, runWithTestActionContext } from '@microsoft/vscode-azext-dev';
 import { AzExtFsExtra } from '@microsoft/vscode-azext-utils';
 import * as assert from 'assert';
 import * as path from 'path';
 import * as vscode from 'vscode';
-import { FuncVersion, ProjectLanguage, copyFunctionUrl, createGenericClient, createNewProjectInternal, deployProductionSlot, getRandomHexString, nonNullProp } from '../../extension.bundle';
+import { FuncVersion, ProjectLanguage, copyFunctionUrl, createGenericClient, createNewProjectInternal, deployProductionSlot, getRandomAlphanumericString, getRandomHexString, nonNullProp } from '../../extension.bundle';
 import { addParallelSuite, runInSeries, type ParallelTest } from '../addParallelSuite';
 import { getTestWorkspaceFolder } from '../global.test';
 import { NodeModelInput, NodeModelVersion, PythonModelInput, PythonModelVersion, defaultTestFuncVersion, getCSharpValidateOptions, getJavaScriptValidateOptions, getPowerShellValidateOptions, getPythonValidateOptions, getTypeScriptValidateOptions, validateProject, type IValidateProjectOptions } from '../project/validateProject';
@@ -23,18 +23,19 @@ interface CreateProjectAndDeployTestCase extends ICreateProjectAndDeployOptions
 }
 
 const testCases: CreateProjectAndDeployTestCase[] = [
-    { title: 'JavaScript (Model V3)', ...getJavaScriptValidateOptions(true), createProjectInputs: [NodeModelInput[NodeModelVersion.v3]], deployInputs: [getRotatingNodeVersion()], languageModelVersion: NodeModelVersion.v3 },
-    { title: 'JavaScript (Model V4)', ...getJavaScriptValidateOptions(true, undefined, undefined, undefined, NodeModelVersion.v4), createProjectInputs: [NodeModelInput[NodeModelVersion.v4]], deployInputs: [getRotatingNodeVersion()], languageModelVersion: NodeModelVersion.v4 },
-    { title: 'TypeScript (Model V3)', ...getTypeScriptValidateOptions(), createProjectInputs: [NodeModelInput[NodeModelVersion.v3]], deployInputs: [getRotatingNodeVersion()], languageModelVersion: NodeModelVersion.v3 },
-    { title: 'TypeScript (Model V4)', ...getTypeScriptValidateOptions({ modelVersion: NodeModelVersion.v4 }), createProjectInputs: [NodeModelInput[NodeModelVersion.v4]], deployInputs: [getRotatingNodeVersion()], languageModelVersion: NodeModelVersion.v4 },
+    { title: 'JavaScript (Model V3)', ...getJavaScriptValidateOptions(true), createProjectInputs: [NodeModelInput[NodeModelVersion.v3]], deployInputs: [getRotatingNodeVersion(), TestInput.UseDefaultValue /* instance mem size*/, TestInput.UseDefaultValue /*max instance*/], languageModelVersion: NodeModelVersion.v3 },
+    { title: 'JavaScript (Model V4)', ...getJavaScriptValidateOptions(true, undefined, undefined, undefined, NodeModelVersion.v4), createProjectInputs: [NodeModelInput[NodeModelVersion.v4]], deployInputs: [getRotatingNodeVersion(), TestInput.UseDefaultValue /* instance mem size*/, TestInput.UseDefaultValue /*max instance*/], languageModelVersion: NodeModelVersion.v4 },
+    { title: 'TypeScript (Model V3)', ...getTypeScriptValidateOptions(), createProjectInputs: [NodeModelInput[NodeModelVersion.v3]], deployInputs: [getRotatingNodeVersion(), TestInput.UseDefaultValue /* instance mem size*/, TestInput.UseDefaultValue /*max instance*/], languageModelVersion: NodeModelVersion.v3 },
+    { title: 'TypeScript (Model V4)', ...getTypeScriptValidateOptions({ modelVersion: NodeModelVersion.v4 }), createProjectInputs: [NodeModelInput[NodeModelVersion.v4]], deployInputs: [getRotatingNodeVersion(), TestInput.UseDefaultValue /* instance mem size*/, TestInput.UseDefaultValue /*max instance*/], languageModelVersion: NodeModelVersion.v4 },
     // Temporarily disable Ballerina tests until we can install Ballerina on the new pipelines
     // https://github.com/microsoft/vscode-azurefunctions/issues/4210
     // { title: 'Ballerina', ...getBallerinaValidateOptions(), createProjectInputs: ["JVM"], deployInputs: [/java.*11/i] },
-    { title: 'C# .NET Framework', buildMachineOsToSkip: 'darwin', ...getCSharpValidateOptions('net48'), createProjectInputs: [/net.*Framework/i], deployInputs: [/net.*Framework/i], createFunctionInputs: ['Company.Function'] },
-    { title: 'C# .NET 8', ...getCSharpValidateOptions('net8.0', FuncVersion.v4), createProjectInputs: [/net.*8/i], deployInputs: [/net.*8/i], createFunctionInputs: ['Company.Function'] },
-    { title: 'PowerShell', ...getPowerShellValidateOptions(), deployInputs: [/powershell.*7.4/i] },
-    { title: 'Python (Model V1)', ...getPythonValidateOptions('.venv'), createProjectInputs: [PythonModelInput[PythonModelVersion.v1], /3\.9/], deployInputs: [getRotatingPythonVersion()], languageModelVersion: PythonModelVersion.v1 },
-    { title: 'Python (Model V2)', ...getPythonValidateOptions('.venv', undefined, PythonModelVersion.v2), createProjectInputs: [PythonModelInput[PythonModelVersion.v2], /3\.9/], deployInputs: [getRotatingPythonVersion()], languageModelVersion: PythonModelVersion.v2 },
+    { title: 'C# .NET 8', ...getCSharpValidateOptions('net8.0', FuncVersion.v4), createProjectInputs: [/net.*8/i], deployInputs: [/net.*8/i, TestInput.UseDefaultValue /* instance mem size*/, TestInput.UseDefaultValue /*max instance*/], createFunctionInputs: ['Company.Function'] },
+    //  Temporarily disable .NET 9 test for now; it seems to break after running clean release (functions)
+    // { title: 'C# .NET 9', ...getCSharpValidateOptions('net9.0', FuncVersion.v4), createProjectInputs: [/net.*9/i], deployInputs: [/net.*9/i, TestInput.UseDefaultValue /* instance mem size*/, TestInput.UseDefaultValue /*max instance*/], createFunctionInputs: ['Company.Function'] },
+    { title: 'PowerShell', ...getPowerShellValidateOptions(), deployInputs: [/powershell.*7.4/i, TestInput.UseDefaultValue /* instance mem size*/, TestInput.UseDefaultValue /*max instance*/] },
+    { title: 'Python (Model V1)', ...getPythonValidateOptions('.venv'), createProjectInputs: [PythonModelInput[PythonModelVersion.v1], /py/], deployInputs: [getRotatingPythonVersion(), TestInput.UseDefaultValue /* instance mem size*/, TestInput.UseDefaultValue /*max instance*/], languageModelVersion: PythonModelVersion.v1 },
+    { title: 'Python (Model V2)', ...getPythonValidateOptions('.venv', undefined, PythonModelVersion.v2), createProjectInputs: [PythonModelInput[PythonModelVersion.v2], /py/], deployInputs: [getRotatingPythonVersion(), TestInput.UseDefaultValue /* instance mem size*/, TestInput.UseDefaultValue /*max instance*/], languageModelVersion: PythonModelVersion.v2 },
 ]
 
 const parallelTests: ParallelTest[] = [];
@@ -63,7 +64,7 @@ interface ICreateProjectAndDeployOptions extends IValidateProjectOptions {
 }
 
 async function testCreateProjectAndDeploy(options: ICreateProjectAndDeployOptions): Promise<void> {
-    const functionName: string = 'func' + getRandomHexString(); // function name must start with a letter
+    const functionName: string = 'f' + getRandomAlphanumericString(); // function name must only contain alphanumeric
 
     const testWorkspacePath = getTestWorkspaceFolder();
     await runWithTestActionContext('createNewProject', async context => {
@@ -86,11 +87,13 @@ async function testCreateProjectAndDeploy(options: ICreateProjectAndDeployOption
     const routePrefix: string = getRandomHexString();
     await addRoutePrefixToProject(testWorkspacePath, routePrefix);
 
-    const appName: string = 'funcBasic' + getRandomHexString();
+    // TODO: investigate why our SDK calls are throwing errors when app name is over ~12 characters
+    // https://github.com/microsoft/vscode-azurefunctions/issues/4368
+    const appName: string = 'f' + getRandomAlphanumericString();
     resourceGroupsToDelete.push(appName);
     await runWithTestActionContext('deploy', async context => {
         options.deployInputs = options.deployInputs || [];
-        await context.ui.runWithInputs([testWorkspacePath, /create new function app/i, appName, ...options.deployInputs, getRotatingLocation()], async () => {
+        await context.ui.runWithInputs([testWorkspacePath, /create new function app/i, appName, getRotatingLocation(), ...options.deployInputs], async () => {
             await deployProductionSlot(context)
         });
     });

test/nightly/createProjectAndDeploy.test.ts

@@ -11,21 +11,21 @@ export function getRotatingAuthLevel(): string {
 }
 
 let locationCount: number = getStartingIndex();
-const locations: string[] = ['Australia East', 'East Asia', 'East US', 'North Europe', 'South Central US', 'Southeast Asia', 'UK South', 'West Europe'];
+const locations: string[] = ["East US", "South Central US", "West US 2", "West US 3", "Australia East", "Southeast Asia", "North Europe", "Sweden Central", "UK South", "East Asia", "East US 2"];
 export function getRotatingLocation(): string {
     locationCount += 1;
     return locations[locationCount % locations.length];
 }
 
 let nodeVersionCount: number = getStartingIndex();
-const nodeVersions: RegExp[] = [/node.*18/i, /node.*20/i];
+const nodeVersions: RegExp[] = [/node.*20/i];
 export function getRotatingNodeVersion(): RegExp {
     nodeVersionCount += 1;
     return nodeVersions[nodeVersionCount % nodeVersions.length];
 }
 
 let pyVersionCount: number = getStartingIndex();
-const pyVersions: RegExp[] = [/python.*3\.8/i, /python.*3\.9/i, /python.*3\.10/i, /python.*3\.11/i];
+const pyVersions: RegExp[] = [/python.*3\.10/i, /python.*3\.11/i];
 export function getRotatingPythonVersion(): RegExp {
     pyVersionCount += 1;
     return pyVersions[pyVersionCount % pyVersions.length];

test/nightly/getRotatingValue.ts

@@ -28,7 +28,7 @@ suite('Create New Python Project (Model V1)', () => {
         }
         this.timeout(2 * 60 * 1000);
 
-        const alias: string = process.platform === 'win32' ? 'py -3.9' : 'python3.9';
+        const alias: string = process.platform === 'win32' ? 'py' : 'python';
         await runWithTestActionContext('createProject', async context => {
             await createAndValidateProject(context, { ...getPythonValidateOptions('.venv', FuncVersion.v4), inputs: [modelV1Input, /enter/i, alias] });
         });

test/project/createNewPythonProject.test.ts

@@ -39,7 +39,7 @@ extends:
   parameters:
     sdl:
       credscan:
-        suppressionsFile: $(Build.SourcesDirectory)\.azure-pipelines\compliance\CredScanSuppressions.json
+        suppressionsFile: $(Build.SourcesDirectory)/.azure-pipelines/compliance/CredScanSuppressions.json
       codeql:
         language: csharp # only build a codeql database for csharp, since the pipeline at the root handles javascript
       #   enabled: true # TODO: would like to enable only on scheduled builds but CodeQL cannot currently be disabled per https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/codeql/1es-codeql