small changes

Author: motm32

package.json

@@ -501,7 +501,7 @@
                 },
                 {
                     "command": "azureFunctions.convertRemoteConnections",
-                    "when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /applicationSettingItem.*azFunc/i",
+                    "when": "view =~ /(azureResourceGroups|azureFocusView)/ && viewItem =~ /(applicationSettings|applicationSettingItem).*azFunc/i",
                     "group": "1@4"
                 },
                 {

src/commands/convertConnections/ConvertSettingsStep.ts

@@ -27,7 +27,6 @@ export class ConvertSettingsStep extends AzureWizardExecuteStep<IConvertConnecti
                         originalValue: connection.name
                     });
 
-                    // Add role assignments to context
                     context.roles?.push({
                         scopeId: await getScopeHelper(context, storageAccountName, `resourceType eq 'Microsoft.Storage/storageAccounts'`),
                         roleDefinitionId: createRoleId(context.subscriptionId, CommonRoleDefinitions.storageBlobDataOwner),
@@ -49,7 +48,6 @@ export class ConvertSettingsStep extends AzureWizardExecuteStep<IConvertConnecti
                         }
                     );
 
-                    // TODO: test these roles
                     const scope = await getScopeHelper(context, storageAccountName, `resourceType eq 'Microsoft.Storage/storageAccounts'`)
                     context.roles?.push(
                         {
@@ -73,7 +71,6 @@ export class ConvertSettingsStep extends AzureWizardExecuteStep<IConvertConnecti
                         originalValue: connection.name
                     });
 
-                    // TODO: test these roles
                     const scope = await getScopeHelper(context, cosmosDbAccountName, `resourceType eq  'Microsoft.DocumentDB/databaseAccounts'`);
                     context.roles?.push(
                         {
@@ -96,7 +93,6 @@ export class ConvertSettingsStep extends AzureWizardExecuteStep<IConvertConnecti
                         originalValue: connection.name
                     });
 
-                    // TODO: test these roles
                     const scope = await getScopeHelper(context, eventHubNamespace, `resourceType eq  'Microsoft.EventHub/Namespaces'`);
                     context.roles?.push(
                         {
@@ -119,7 +115,6 @@ export class ConvertSettingsStep extends AzureWizardExecuteStep<IConvertConnecti
                         originalValue: connection.name
                     });
 
-                    // TODO: test these roles
                     const scope = await getScopeHelper(context, serviceBusNamespace, `resourceType eq  'Microsoft.ServiceBus/Namespaces'`);
                     context.roles?.push(
                         {

src/commands/convertConnections/SelectConnectionsStep.ts

@@ -69,7 +69,7 @@ export class SelectConnectionsStep extends AzureWizardPromptStep<IConvertConnect
 
             if (localSettings.Values) {
                 for (const [key, value] of Object.entries(localSettings.Values)) {
-                    if (convertibleSetting(key, value)) {
+                    if (!convertibleSetting(key, value)) {
                         continue;
                     }
 
@@ -95,7 +95,7 @@ export class SelectConnectionsStep extends AzureWizardPromptStep<IConvertConnect
             const appSettings: StringDictionary = await client.listApplicationSettings();
             if (appSettings.properties) {
                 for (const [key, value] of Object.entries(appSettings.properties)) {
-                    if (convertibleSetting(key, value)) {
+                    if (!convertibleSetting(key, value)) {
                         continue;
                     }
 

src/tree/localProject/LocalProjectTreeItem.ts

@@ -87,7 +87,7 @@ export class LocalProjectTreeItem extends LocalProjectTreeItemBase implements Di
                     }
                     if (localSettings.Values) {
                         for (const [key, value] of Object.entries(localSettings.Values)) {
-                            if (convertibleSetting(key, value)) {
+                            if (!convertibleSetting(key, value)) {
                                 continue;
                             }