Various bug fixes (#4588)

* Various bug fixes

* Another site init

* Update src/commands/deployments/connectToGitHub.ts

Co-authored-by: Copilot <[email protected]>

* Update connectToGitHub.ts

---------

Co-authored-by: Copilot <[email protected]>

Author: nturinski

src/commands/addMIConnections/addRemoteMIConnections.ts

@@ -20,6 +20,7 @@ export async function addRemoteMIConnections(context: AddMIConnectionsContext, n
     const connections: Connection[] = [];
     if (!node) {
         context.functionapp = await pickFunctionApp(context);
+        await context.functionapp.initSite(context);
         await addRemoteMIConnectionsInternal(context, connections);
     } else {
         if (node instanceof AppSettingTreeItem) {

src/commands/deployments/connectToGitHub.ts

@@ -21,7 +21,10 @@ export async function connectToGitHub(context: IActionContext, target?: GenericT
         deployments = <DeploymentsTreeItem>target.parent;
     }
 
+    await deployments.init(context);
     if (deployments.parent && isSlotTreeItem(deployments.parent)) {
+        const siteItem = deployments.parent;
+        await siteItem.initSite(context);
         await editScmType(context, deployments.site, deployments.subscription, ScmType.GitHub);
         await deployments.refresh(context);
     } else {

src/tree/ResolvedFunctionAppResource.ts

@@ -315,7 +315,7 @@ export class ResolvedFunctionAppResource extends ResolvedFunctionAppBase impleme
                     }
                 }
             }
-
+            const flexError = localize('flexFunctionAppDeploymentsNotSupported', 'Command not supported for Flex Consumption apps.');
             for (const expectedContextValue of expectedContextValues) {
                 if (expectedContextValue instanceof RegExp) {
                     const appSettingsContextValues = [AppSettingsTreeItem.contextValue, AppSettingTreeItem.contextValue];
@@ -324,10 +324,19 @@ export class ResolvedFunctionAppResource extends ResolvedFunctionAppBase impleme
                     }
                     const deploymentsContextValues = [DeploymentsTreeItem.contextValueConnected, DeploymentsTreeItem.contextValueUnconnected, DeploymentTreeItem.contextValue];
                     if (matchContextValue(expectedContextValue, deploymentsContextValues)) {
+                        if (this.isFlex) {
+                            context.errorHandling.rethrow = true;
+                            throw new Error(flexError);
+                        }
+                        await this.deploymentsNode?.init(context);
                         return this.deploymentsNode;
                     }
 
                     if (matchContextValue(expectedContextValue, [ResolvedFunctionAppResource.slotContextValue])) {
+                        if (this.isFlex) {
+                            context.errorHandling.rethrow = true;
+                            throw new Error(flexError);
+                        }
                         return this._slotsTreeItem;
                     }
                 }

src/tree/SlotTreeItem.ts

@@ -13,7 +13,7 @@ import { ProjectSource } from './projectContextValues';
 import { type RemoteFunctionTreeItem } from './remoteProject/RemoteFunctionTreeItem';
 
 export function isSlotTreeItem(treeItem: SlotTreeItem | RemoteFunctionTreeItem | AzExtParentTreeItem): treeItem is SlotTreeItem {
-    return !!(treeItem as SlotTreeItem).site;
+    return !!(treeItem as SlotTreeItem).contextValue.includes('FunctionApp;')
 }
 
 export class SlotTreeItem extends SlotContainerTreeItemBase {