Check for DTS trigger before app creation to ensure premium plan is used (#4529)

* Add new storage type pick and host/local settings logic

* Update host.json preview dep

* Install deps

* Update extension bundle

* Update durable detection logic

* Check for DTS trigger before app creation to ensure premium plan is used.

* Remove extra prop

* Remove some of my code

* Fix weird merge

* Remove todo comment

---------

Co-authored-by: MicroFish91 <[email protected]>

Author: nturinski

src/commands/createFunctionApp/FunctionAppHostingPlanStep.ts

@@ -13,13 +13,14 @@ import { getRandomHexString } from '../../utils/fs';
 import { nonNullProp } from '../../utils/nonNull';
 import { type IFunctionAppWizardContext } from './IFunctionAppWizardContext';
 
+const premiumSkuFilter = /^EP$/i;
 export class FunctionAppHostingPlanStep extends AzureWizardPromptStep<IFunctionAppWizardContext> {
     public async prompt(context: IFunctionAppWizardContext): Promise<void> {
         const placeHolder: string = localize('selectHostingPlan', 'Select a hosting plan.');
         const picks: IAzureQuickPickItem<[boolean, boolean, RegExp | undefined]>[] = [
             { label: localize('flexConsumption', 'Flex Consumption'), data: [false, true, undefined] },
             { label: localize('consumption', 'Linux Consumption'), description: localize('legacy', 'Legacy'), data: [true, false, undefined] },
-            { label: localize('premium', 'Premium'), data: [false, false, /^EP$/i] },
+            { label: localize('premium', 'Premium'), data: [false, false, premiumSkuFilter] },
             { label: localize('dedicated', 'App Service Plan'), data: [false, false, /^((?!EP|Y|FC).)*$/i] }
         ];
 
@@ -33,11 +34,19 @@ export class FunctionAppHostingPlanStep extends AzureWizardPromptStep<IFunctionA
     }
 
     public shouldPrompt(context: IFunctionAppWizardContext): boolean {
-        return context.useFlexConsumptionPlan === undefined && context.dockerfilePath === undefined;
+        return (context.useFlexConsumptionPlan === undefined && context.dockerfilePath === undefined) && !context.planSkuFamilyFilter;
     }
 
     public configureBeforePrompt(context: IFunctionAppWizardContext): void | Promise<void> {
-        if (context.useFlexConsumptionPlan) {
+        if (context.hasDurableTaskScheduler) {
+            // premium is required for DTS
+            if (context.advancedCreation) {
+                // allows users to select/create a Elastic Premium plan
+                context.planSkuFamilyFilter = premiumSkuFilter;
+            } else {
+                setPremiumPlanProperties(context);
+            }
+        } else if (context.useFlexConsumptionPlan) {
             setFlexConsumptionPlanProperties(context);
         }
     }
@@ -56,6 +65,16 @@ function setFlexConsumptionPlanProperties(context: IAppServiceWizardContext): vo
     LocationListStep.setLocationSubset(context, getFlexLocations(context), 'Microsoft.WebFlex');
 }
 
+function setPremiumPlanProperties(context: IAppServiceWizardContext): void {
+    context.newPlanName = `PREMIUM-${nonNullProp(context, 'newSiteName')}-${getRandomHexString(4)}`;
+    context.newPlanSku = {
+        name: 'P1v2',
+        tier: 'Premium V2',
+        size: 'P1v2',
+        family: 'Pv2'
+    };
+}
+
 async function getFlexLocations(context: IAppServiceWizardContext): Promise<string[]> {
     const headers = createHttpHeaders({
         'Content-Type': 'application/json',

src/commands/createFunctionApp/IFunctionAppWizardContext.ts

@@ -31,6 +31,7 @@ export interface IFunctionAppWizardContext extends IAppServiceWizardContext, ICr
     hasAzureStorageConnection?: boolean;
     hasEventHubsConnection?: boolean;
     hasSqlDbConnection?: boolean;
+    hasDurableTaskScheduler?: boolean;
 }
 
 export interface IFlexFunctionAppWizardContext extends IFunctionAppWizardContext {

src/commands/createFunctionApp/containerImage/detectDockerfile.ts

@@ -13,7 +13,8 @@ import { isFunctionProject } from '../../createNewProject/verifyIsProject';
 import path = require('path');
 
 export async function detectDockerfile(context: ICreateFunctionAppContext): Promise<void> {
-    if (vscode.workspace.workspaceFolders) {
+    // don't overwrite the workspace folder on the context if it's already set
+    if (vscode.workspace.workspaceFolders && !context.workspaceFolder) {
         context.workspaceFolder = vscode.workspace.workspaceFolders[0];
         const workspacePath = context.workspaceFolder.uri.fsPath;
         let dockerfilePath: string = workspacePath

src/commands/createFunctionApp/createCreateFunctionAppComponents.ts

@@ -7,10 +7,11 @@ import { AppInsightsCreateStep, AppInsightsListStep, AppKind, AppServicePlanCrea
 import { CommonRoleDefinitions, createRoleId, LocationListStep, ResourceGroupCreateStep, ResourceGroupListStep, RoleAssignmentExecuteStep, StorageAccountCreateStep, StorageAccountKind, StorageAccountListStep, StorageAccountPerformance, StorageAccountReplication, UserAssignedIdentityListStep, type INewStorageAccountDefaults, type Role } from "@microsoft/vscode-azext-azureutils";
 import { type AzureWizardExecuteStep, type AzureWizardPromptStep, type ISubscriptionContext } from "@microsoft/vscode-azext-utils";
 import { FuncVersion, latestGAVersion, tryParseFuncVersion } from "../../FuncVersion";
-import { funcVersionSetting } from "../../constants";
+import { DurableBackend, funcVersionSetting } from "../../constants";
 import { tryGetLocalFuncVersion } from "../../funcCoreTools/tryGetLocalFuncVersion";
 import { type ICreateFunctionAppContext } from "../../tree/SubscriptionTreeItem";
 import { createActivityContext } from "../../utils/activityUtils";
+import { durableUtils } from "../../utils/durableUtils";
 import { getRootFunctionsWorkerRuntime, getWorkspaceSetting, getWorkspaceSettingFromAnyFolder } from "../../vsCodeConfig/settings";
 import { AuthenticationPromptStep } from "./AuthenticationPromptStep";
 import { FunctionAppCreateStep } from "./FunctionAppCreateStep";
@@ -53,6 +54,9 @@ export async function createCreateFunctionAppComponents(context: ICreateFunction
     };
 
     await detectDockerfile(context);
+    if (wizardContext.workspaceFolder) {
+        wizardContext.hasDurableTaskScheduler = await durableUtils.getStorageTypeFromWorkspace(language, wizardContext.workspaceFolder.uri.fsPath) === DurableBackend.DTS;
+    }
 
     promptSteps.push(new SiteNameStep(context.dockerfilePath ? "containerizedFunctionApp" : "functionApp"));
 

src/commands/createFunctionApp/createFunctionApp.ts

@@ -9,6 +9,7 @@ import { localize } from '../../localize';
 import { type SlotTreeItem } from '../../tree/SlotTreeItem';
 import { SubscriptionTreeItem, type ICreateFunctionAppContext } from '../../tree/SubscriptionTreeItem';
 import { type ContainerTreeItem } from '../../tree/containerizedFunctionApp/ContainerTreeItem';
+import { getRootWorkspaceFolder, isMultiRootWorkspace } from '../../utils/workspace';
 
 function isSubscription(item?: AzExtParentTreeItem): boolean {
     try {
@@ -35,6 +36,10 @@ export async function createFunctionApp(context: IActionContext & Partial<ICreat
     }
 
     context.newResourceGroupName = newResourceGroupName;
+    if (!isMultiRootWorkspace()) {
+        // only set the workspace if we're not doing in a multiroot project
+        context.workspaceFolder = await getRootWorkspaceFolder();
+    }
 
     const funcAppNode: SlotTreeItem | ContainerTreeItem = await SubscriptionTreeItem.createChild(context as ICreateFunctionAppContext, node as SubscriptionTreeItem);