Feedback

Author: nturinski

src/commands/identity/EnableSystemIdentityStep.ts

@@ -24,7 +24,7 @@ export class EnableSystemIdentityAssignStep extends AzureWizardExecuteStep<Manag
         site.rawSite.identity = identity;
 
         const enabling: string = localize('enabling', 'Enabling system assigned identity for "{0}"...', site.fullName);
-        const enabled: string = localize('enabled', 'Enabled system assigned identity for "{0}".', site.fullName);
+        const enabled: string = localize('enabled', 'Enabled system assigned identity for "{0}"', site.fullName);
         ext.outputChannel.appendLog(enabling);
 
         await client.webApps.update(site.resourceGroup, site.siteName, site.rawSite);

src/commands/identity/assignManagedIdentity.ts

@@ -35,7 +35,7 @@ export async function assignManagedIdentity(context: IActionContext, node?: User
     const executeSteps: AzureWizardExecuteStep<ManagedIdentityAssignContext>[] = [
         new ManagedIdentityAssignStep()
     ];
-    const title: string = localize('assignManagedIdentity', 'Assign Managed Identity to Function App');
+    const title: string = localize('assignManagedIdentity', 'Assign User Assigned Identity to Function App');
     const wizard: AzureWizard<ManagedIdentityAssignContext> = new AzureWizard(wizardContext, {
         title,
         promptSteps,
@@ -45,7 +45,7 @@ export async function assignManagedIdentity(context: IActionContext, node?: User
 
 
     await wizard.prompt();
-    wizardContext.activityTitle = localize('assigning', 'Assigning user assigned identity "{1}" for "{0}"...', wizardContext.site?.fullName, wizardContext.managedIdentity?.name);
+    wizardContext.activityTitle = localize('assigning', 'Assigned user assigned identity "{1}" for "{0}"', wizardContext.site?.fullName, wizardContext.managedIdentity?.name);
     await node.runWithTemporaryDescription(context, localize('enabling', 'Assigning identity...'), async () => {
         await wizard.execute();
     });

src/commands/identity/enableSystemIdentity.ts

@@ -6,14 +6,13 @@
 import { AzureWizard, type ExecuteActivityContext, type IActionContext } from "@microsoft/vscode-azext-utils";
 import { localize } from "../../localize";
 import { type SystemIdentityTreeItemBase } from "../../tree/remoteProject/SystemIdentityTreeItemBase";
-import { type SlotTreeItem } from "../../tree/SlotTreeItem";
 import { createActivityContext } from "../../utils/activityUtils";
 import { EnableSystemIdentityAssignStep } from "./EnableSystemIdentityStep";
 import { type ManagedIdentityAssignContext } from "./ManagedIdentityAssignContext";
 
 export async function enableSystemIdentity(context: IActionContext, node: SystemIdentityTreeItemBase): Promise<undefined> {
-    const grandparentNode = node.parent.parent as SlotTreeItem;
-    const title: string = localize('enabling', 'Enabling system assigned identity for "{0}"...', grandparentNode.site.fullName);
+    const grandparentNode = node.parent.parent;
+    const title: string = localize('enabling', 'Enabled system assigned identity for "{0}".', grandparentNode.site.fullName);
 
     const wizardContext: ManagedIdentityAssignContext & ExecuteActivityContext = Object.assign(context, {
         site: grandparentNode.site,
@@ -22,8 +21,7 @@ export async function enableSystemIdentity(context: IActionContext, node: System
         activityTitle: title
     });
     const wizard = new AzureWizard(wizardContext, {
-        executeSteps: [new EnableSystemIdentityAssignStep()],
-        title
+        executeSteps: [new EnableSystemIdentityAssignStep()]
     });
 
     await node.runWithTemporaryDescription(context, localize('enabling', 'Enabling system assigned identity...'), async () => {

src/tree/remoteProject/ManagedIdentityTreeItem.ts

@@ -7,15 +7,14 @@ import { type ParsedSite } from '@microsoft/vscode-azext-azureappservice';
 import { AzExtParentTreeItem, createContextValue, type AzExtTreeItem, type IActionContext, type TreeItemIconPath } from '@microsoft/vscode-azext-utils';
 import { ThemeIcon } from 'vscode';
 import { localize } from '../../localize';
-import { type IProjectTreeItem } from '../IProjectTreeItem';
 import { type SlotTreeItem } from '../SlotTreeItem';
 import { SystemIdentityTreeItemBase } from './SystemIdentityTreeItemBase';
 import { UserAssignedIdentitiesTreeItem } from './UserAssignedIdentitiesTreeItem';
 
 export class ManagedIdentityTreeItem extends AzExtParentTreeItem {
     public readonly label: string = localize('Identity', 'Identity');
     public static contextValue: string = 'azFuncManagedIdentity';
-    public readonly parent: AzExtParentTreeItem & IProjectTreeItem & SlotTreeItem;
+    public readonly parent: SlotTreeItem;
     public readonly site: ParsedSite;
     public suppressMaskLabel: boolean = true;