Add comprehensive validation for DTS connection strings including empty Authentication values (#4624)

* Initial plan

* Add comprehensive DTS connection string validation

Co-authored-by: alexweininger <[email protected]>

* Revert main.js changes to use original extension loading mechanism

Co-authored-by: MicroFish91 <[email protected]>

* Add validation for empty Authentication parameter values in DTS connection strings

Co-authored-by: MicroFish91 <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: alexweininger <[email protected]>
Co-authored-by: MicroFish91 <[email protected]>

Author: 3 people

src/commands/appSettings/connectionSettings/durableTaskScheduler/custom/DTSConnectionCustomPromptStep.ts

@@ -19,11 +19,44 @@ export class DTSConnectionCustomPromptStep<T extends IDTSConnectionWizardContext
         return !context.newDTSConnectionSettingValue;
     }
 
-    private validateInput(name: string | undefined): string | undefined {
-        name = name ? name.trim() : '';
-        if (!validationUtils.hasValidCharLength(name)) {
+    private validateInput(connectionString: string | undefined): string | undefined {
+        connectionString = connectionString ? connectionString.trim() : '';
+        
+        // Check for basic character length validation
+        if (!validationUtils.hasValidCharLength(connectionString)) {
             return validationUtils.getInvalidCharLengthMessage();
         }
+
+        // Check if the connection string contains the required "Endpoint=" pattern
+        const endpointMatch = connectionString.match(/Endpoint=([^;]+)/);
+        if (!endpointMatch) {
+            return localize('invalidDTSConnectionStringFormat', 'DTS connection string must contain an "Endpoint=" parameter. Expected format: "Endpoint=<URL>;Authentication=<AuthType>"');
+        }
+
+        // Validate that the endpoint URL is properly formatted
+        const endpoint = endpointMatch[1];
+        try {
+            const url = new URL(endpoint);
+            // Ensure it's using a valid protocol
+            if (!['http:', 'https:'].includes(url.protocol)) {
+                return localize('invalidDTSEndpointProtocol', 'DTS endpoint must use HTTP or HTTPS protocol. Found: {0}', url.protocol);
+            }
+        } catch (error) {
+            return localize('invalidDTSEndpointURL', 'DTS endpoint is not a valid URL: {0}', endpoint);
+        }
+
+        // Check if the connection string contains an Authentication parameter with a non-empty value
+        const authMatch = connectionString.match(/Authentication=([^;]*)/);
+        if (!authMatch) {
+            return localize('missingDTSAuthentication', 'DTS connection string must contain an "Authentication=" parameter. Expected format: "Endpoint=<URL>;Authentication=<AuthType>"');
+        }
+        
+        // Validate that the Authentication parameter has a non-empty value
+        const authValue = authMatch[1];
+        if (!authValue || authValue.trim() === '') {
+            return localize('emptyDTSAuthentication', 'DTS Authentication parameter cannot be empty. Expected format: "Endpoint=<URL>;Authentication=<AuthType>"');
+        }
+
         return undefined;
     }
 }