Ensure durable storage type telemetry is set in all workflows (#4656)

Author: MicroFish91

src/commands/createFunction/createFunction.ts

@@ -71,11 +71,13 @@ export async function createFunctionInternal(context: IActionContext, options: a
     }
 
     const { language, languageModel, version, templateSchemaVersion } = await verifyInitForVSCode(context, projectPath, options.language, options.languageModel, options.version);
-    const hasDurableStorage: boolean = await durableUtils.verifyHasDurableStorage(language, projectPath);
+    const durableStorageType = await durableUtils.getStorageTypeFromWorkspace(language, projectPath);
+    context.telemetry.properties.hasDurableStorageProject = String(!!durableStorageType);
+    context.telemetry.properties.durableStorageType = durableStorageType;
 
     const projectTemplateKey: string | undefined = getWorkspaceSetting(projectTemplateKeySetting, projectPath);
     const wizardContext: IFunctionWizardContext = Object.assign(context, options, await createActivityContext(),
-        { projectPath, workspacePath, workspaceFolder, version, language, languageModel, projectTemplateKey, hasDurableStorage, templateSchemaVersion });
+        { projectPath, workspacePath, workspaceFolder, version, language, languageModel, projectTemplateKey, hasDurableStorage: !!durableStorageType, templateSchemaVersion });
     wizardContext.activityTitle = localize('creatingFunction', 'Create function');
     wizardContext.activityChildren = [];
 

src/commands/createFunction/durableSteps/DurableStorageTypePromptStep.ts

@@ -36,7 +36,9 @@ export class DurableStorageTypePromptStep<T extends IFunctionWizardContext> exte
                 await openUrl('https://aka.ms/durable-storage-providers');
             }
         }
+
         context.newDurableStorageType = pick;
+        context.telemetry.properties.durableStorageType = pick;
     }
 
     public shouldPrompt(context: T): boolean {

src/commands/createFunctionApp/FunctionAppHostingPlanStep.ts

@@ -8,6 +8,7 @@ import { createHttpHeaders, createPipelineRequest } from '@azure/core-rest-pipel
 import { setLocationsTask, WebsiteOS, type IAppServiceWizardContext } from '@microsoft/vscode-azext-azureappservice';
 import { createGenericClient, LocationListStep, type AzExtPipelineResponse, type AzExtRequestPrepareOptions } from '@microsoft/vscode-azext-azureutils';
 import { AzureWizardPromptStep, type IAzureQuickPickItem } from '@microsoft/vscode-azext-utils';
+import { DurableBackend } from '../../constants';
 import { localize } from '../../localize';
 import { getRandomHexString } from '../../utils/fs';
 import { nonNullProp } from '../../utils/nonNull';
@@ -38,7 +39,7 @@ export class FunctionAppHostingPlanStep extends AzureWizardPromptStep<IFunctionA
     }
 
     public configureBeforePrompt(context: IFunctionAppWizardContext): void | Promise<void> {
-        if (context.hasDurableTaskScheduler) {
+        if (context.durableStorageType === DurableBackend.DTS) {
             // premium is required for DTS
             if (context.advancedCreation) {
                 // allows users to select/create a Elastic Premium plan

src/commands/createFunctionApp/IFunctionAppWizardContext.ts

@@ -26,12 +26,6 @@ export interface IFunctionAppWizardContext extends IAppServiceWizardContext, ICr
     durableStorageType?: DurableBackend;
     useFlexConsumptionPlan?: boolean;
     useManagedIdentity?: boolean;
-
-    // Detected local connection string
-    hasAzureStorageConnection?: boolean;
-    hasEventHubsConnection?: boolean;
-    hasSqlDbConnection?: boolean;
-    hasDurableTaskScheduler?: boolean;
 }
 
 export interface IFlexFunctionAppWizardContext extends IFunctionAppWizardContext {

src/commands/createFunctionApp/createCreateFunctionAppComponents.ts

@@ -7,7 +7,7 @@ import { AppInsightsCreateStep, AppInsightsListStep, AppKind, AppServicePlanCrea
 import { CommonRoleDefinitions, createRoleId, LocationListStep, ResourceGroupCreateStep, ResourceGroupListStep, RoleAssignmentExecuteStep, StorageAccountCreateStep, StorageAccountKind, StorageAccountListStep, StorageAccountPerformance, StorageAccountReplication, type INewStorageAccountDefaults, type Role } from "@microsoft/vscode-azext-azureutils";
 import { type AzureWizardExecuteStep, type AzureWizardPromptStep, type ISubscriptionContext } from "@microsoft/vscode-azext-utils";
 import { FuncVersion, latestGAVersion, tryParseFuncVersion } from "../../FuncVersion";
-import { DurableBackend, funcVersionSetting } from "../../constants";
+import { funcVersionSetting } from "../../constants";
 import { tryGetLocalFuncVersion } from "../../funcCoreTools/tryGetLocalFuncVersion";
 import { type ICreateFunctionAppContext } from "../../tree/SubscriptionTreeItem";
 import { createActivityContext } from "../../utils/activityUtils";
@@ -55,7 +55,8 @@ export async function createCreateFunctionAppComponents(context: ICreateFunction
 
     await detectDockerfile(context);
     if (wizardContext.workspaceFolder) {
-        wizardContext.hasDurableTaskScheduler = await durableUtils.getStorageTypeFromWorkspace(language, wizardContext.workspaceFolder.uri.fsPath) === DurableBackend.DTS;
+        wizardContext.durableStorageType = await durableUtils.getStorageTypeFromWorkspace(language, wizardContext.workspaceFolder.uri.fsPath);
+        wizardContext.telemetry.properties.durableStorageType = wizardContext.durableStorageType;
     }
 
     promptSteps.push(new SiteNameStep(context.dockerfilePath ? "containerizedFunctionApp" : "functionApp"));